[Bug 16468] New: Remove last "onclick" from the stage MARC records template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16468 Bug ID: 16468 Summary: Remove last "onclick" from the stage MARC records template Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/tools/stage-marc-import.pl OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Tools Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle@bywatersolutions.com, testopia@bugs.koha-community.org, veron@veron.ch Depends on: 16337 There is one more instance of "onclick" in stage-marc-import.tt which I didn't catch in Bug 16337 somehow. It can be removed in favor of defining events in the JavaScript. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16337 [Bug 16337] Remove the use of "onclick" from the stage MARC records template -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16468 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16468 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 51296 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51296&action=edit Bug 16468 - Remove last "onclick" from the stage MARC records template This patch reviseds the stage MARC records template, removing one more "onclick" attribute from the markup and defining that event in the script. This patch also corrects a missing quotation mark in the HTML. I have done some reindentation to that section. To test, apply the patch and go to Tools -> Stage MARC records for import. - Select a MARC file for import. - Click the "Upload file" button. - Click the "Stage for import" button. Your import should be correctly staged. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16468 Claire Gravely <c.gravely@arts.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16468 Claire Gravely <c.gravely@arts.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51296|0 |1 is obsolete| | --- Comment #2 from Claire Gravely <c.gravely@arts.ac.uk> --- Created attachment 52012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52012&action=edit Bug 16468 - Remove last "onclick" from the stage MARC records template This patch reviseds the stage MARC records template, removing one more "onclick" attribute from the markup and defining that event in the script. This patch also corrects a missing quotation mark in the HTML. I have done some reindentation to that section. To test, apply the patch and go to Tools -> Stage MARC records for import. - Select a MARC file for import. - Click the "Upload file" button. - Click the "Stage for import" button. Your import should be correctly staged. Signed-off-by: Claire Gravely <c.gravely@arts.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16468 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16468 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52012|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 52650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52650&action=edit Bug 16468 - Remove last "onclick" from the stage MARC records template This patch reviseds the stage MARC records template, removing one more "onclick" attribute from the markup and defining that event in the script. This patch also corrects a missing quotation mark in the HTML. I have done some reindentation to that section. To test, apply the patch and go to Tools -> Stage MARC records for import. - Select a MARC file for import. - Click the "Upload file" button. - Click the "Stage for import" button. Your import should be correctly staged. Signed-off-by: Claire Gravely <c.gravely@arts.ac.uk> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16468 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11, thanks Owen! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16468 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #5 from Frédéric Demians <frederic@tamil.fr> --- Pushed in 16.05. Will be in 16.05.02. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16468 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16468 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Tools |Templates CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org