[Bug 31576] New: Cannot place hold even when AllowHoldPolicyOverride should allow it
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31576 Bug ID: 31576 Summary: Cannot place hold even when AllowHoldPolicyOverride should allow it Change sponsored?: --- Product: Koha Version: 21.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com This bug appears in Koha 21.11 only ( behavior changes to bug 31575 with 22.05 and later ). If only some item holds can be forced, but others cannot ( because they have to pickup locations ), the place holds button remains disabled even though the hold can be placed. Test Plan: 1) Set one circ rule to allow 0 holds 2) For Library A, set "Hold pickup library match" to "item's hold group" 3) Enable AllowHoldPolicyOverride 4) Set ReservesControlBranch to "item's home branch" 5) Create a record with an item for Library A, one for Library B, and one for Library C This should create a scenario where A's item cannot be held, and B and C's items must be overridden 6) Note you cannot place the hold because the button is disabled. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31576 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31576 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 140711 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140711&action=edit Bug 31576: Cannot place hold even when AllowHoldPolicyOverride should allow it This bug appears in Koha 21.11 only ( behavior changes to bug 31575 with 22.05 and later ). If only some item holds can be forced, but others cannot ( because they have to pickup locations ), the place holds button remains disabled even though the hold can be placed. Test Plan: 1) Set one circ rule to allow 0 holds 2) For Library A, set "Hold pickup library match" to "item's hold group" 3) Enable AllowHoldPolicyOverride 4) Set ReservesControlBranch to "item's home branch" 5) Create a record with an item for Library A, one for Library B, and one for Library C This should create a scenario where A's item cannot be held, and B and C's items must be overridden 6) Note you cannot place the hold because the button is disabled. 7) Apply this patch 8) Restart all the things! 9) Reload the page, the place hold button should now be enabled! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31576 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31576 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31575 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31576 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30687 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31576 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|kyle@bywatersolutions.com |testopia@bugs.koha-communit | |y.org CC| |david@davidnind.com Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | --- Comment #2 from David Nind <david@davidnind.com> --- Hi Kyle, have changed the assignee to you rather than being the QA Contact. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31576 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31576 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140711|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 140738 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140738&action=edit Bug 31576: Cannot place hold even when AllowHoldPolicyOverride should allow it This bug appears in Koha 21.11 only ( behavior changes to bug 31575 with 22.05 and later ). If only some item holds can be forced, but others cannot ( because they have to pickup locations ), the place holds button remains disabled even though the hold can be placed. Test Plan: 1) Set one circ rule to allow 0 holds 2) For Library A, set "Hold pickup library match" to "item's hold group" 3) Enable AllowHoldPolicyOverride 4) Set ReservesControlBranch to "item's home branch" 5) Create a record with an item for Library A, one for Library B, and one for Library C This should create a scenario where A's item cannot be held, and B and C's items must be overridden 6) Note you cannot place the hold because the button is disabled. 7) Apply this patch 8) Restart all the things! 9) Reload the page, the place hold button should now be enabled! Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31576 --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to David Nind from comment #2)
Hi Kyle, have changed the assignee to you rather than being the QA Contact.
Oops. Thanks David! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31576 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31576 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Shouldnt this be pushed to the queue of the RMaint of 21.11 ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31576 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Cannot place hold even when |[21.11] Cannot place hold |AllowHoldPolicyOverride |even when |should allow it |AllowHoldPolicyOverride | |should allow it -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31576 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Keywords| |rel_21_11_candidate --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Marcel de Rooy from comment #5)
Shouldnt this be pushed to the queue of the RMaint of 21.11 ?
Yes, but still could use a QA eye ;-) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31576 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31576 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140738|0 |1 is obsolete| | --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 145718 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145718&action=edit Bug 31576: Cannot place hold even when AllowHoldPolicyOverride should allow it This bug appears in Koha 21.11 only ( behavior changes to bug 31575 with 22.05 and later ). If only some item holds can be forced, but others cannot ( because they have to pickup locations ), the place holds button remains disabled even though the hold can be placed. Test Plan: 1) Set one circ rule to allow 0 holds 2) For Library A, set "Hold pickup library match" to "item's hold group" 3) Enable AllowHoldPolicyOverride 4) Set ReservesControlBranch to "item's home branch" 5) Create a record with an item for Library A, one for Library B, and one for Library C This should create a scenario where A's item cannot be held, and B and C's items must be overridden 6) Note you cannot place the hold because the button is disabled. 7) Apply this patch 8) Restart all the things! 9) Reload the page, the place hold button should now be enabled! Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Only checked the code, looks good to me. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31576 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|martin.renvoize@ptfs-europe |m.de.rooy@rijksmuseum.nl |.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31576 --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- RM, RMaint: Only for 21.11 ! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31576 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to oldstable CC| |arthur.suzuki@biblibre.com, | |jonathan.druart+koha@gmail. | |com --- Comment #9 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Arthur, this is for you. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org