[Bug 20051] New: Invalid markup in staff client's header.inc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20051 Bug ID: 20051 Summary: Invalid markup in staff client's header.inc Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Depends on: 19851 Bug 19851 contains a markup error: 4 instances of ids which should be a classes. This creates a validation error for duplicate ids. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19851 [Bug 19851] Improve responsive layout handling of staff client menu bar -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20051 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20051 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 70777 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70777&action=edit Bug 20051: Invalid markup in staff client's header.inc This patch corrects markup errors in header.inc which introduced by Bug 19851. For id attributes on <span>s have been replaced with classes, eliminating an HTML validator error about duplicate ids. Minor unrelated change: Updated an element's id with a more descriptive name. Test plan the same as Bug 19851's: - Log in to the staff client and confirm that the appearance of the menu bar at the top of the screen looks correct at various browser widths. - Confirm that the logged-in user menu label and help link expand and collapse according to browser width. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20051 Charles Farmer <charles.farmer@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20051 Charles Farmer <charles.farmer@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70777|0 |1 is obsolete| | --- Comment #2 from Charles Farmer <charles.farmer@inlibro.com> --- Created attachment 70783 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70783&action=edit Bug 20051: Invalid markup in staff client's header.inc This patch corrects markup errors in header.inc which introduced by Bug 19851. For id attributes on <span>s have been replaced with classes, eliminating an HTML validator error about duplicate ids. Minor unrelated change: Updated an element's id with a more descriptive name. Test plan the same as Bug 19851's: - Log in to the staff client and confirm that the appearance of the menu bar at the top of the screen looks correct at various browser widths. - Confirm that the logged-in user menu label and help link expand and collapse according to browser width. Signed-off-by: Charles Farmer <charles.farmer@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20051 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20051 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70783|0 |1 is obsolete| | --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 70973 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70973&action=edit Bug 20051: Invalid markup in staff client's header.inc This patch corrects markup errors in header.inc which introduced by Bug 19851. For id attributes on <span>s have been replaced with classes, eliminating an HTML validator error about duplicate ids. Minor unrelated change: Updated an element's id with a more descriptive name. Test plan the same as Bug 19851's: - Log in to the staff client and confirm that the appearance of the menu bar at the top of the screen looks correct at various browser widths. - Confirm that the logged-in user menu label and help link expand and collapse according to browser width. Signed-off-by: Charles Farmer <charles.farmer@inLibro.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20051 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|Passed QA |Failed QA --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- git grep tells me we are going to affect that line: koha-tmpl/intranet-tmpl/prog/en/modules/circ/offline.tt: $('ul[aria-labelledby="drop3"]').html('<li><a class="toplinks">You cannot change your branch or logout while using offline circulation</a></li>'); -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20051 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20051 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70973|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 71086 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71086&action=edit Bug 20051: Invalid markup in staff client's header.inc This patch corrects markup errors in header.inc which introduced by Bug 19851. For id attributes on <span>s have been replaced with classes, eliminating an HTML validator error about duplicate ids. Minor unrelated change: Updated an element's id with a more descriptive name. Test plan the same as Bug 19851's: - Log in to the staff client and confirm that the appearance of the menu bar at the top of the screen looks correct at various browser widths. - Confirm that the logged-in user menu label and help link expand and collapse according to browser width. Signed-off-by: Charles Farmer <charles.farmer@inLibro.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Fix for QA: Corrected ID reference in circ/offline.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20051 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20051 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Pushed to Master |Pushed to Stable --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all, pushed to stable for 17.11.03 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org