[Bug 22133] New: Wrong layout in OAI-PMH:archiveID syspref description
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22133 Bug ID: 22133 Summary: Wrong layout in OAI-PMH:archiveID syspref description Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org Target Milestone: --- It looks like this: "Identify records at this site with the prefix | KOHA-OAI-TEST | : ." the colon shouldn't be there. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22133 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Assignee|oleonard@myacpl.org |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22133 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22133 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 83950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83950&action=edit Bug 22133: Wrong layout in OAI-PMH:archiveID syspref description This patch fixes a trivial text layout problem on the syspref description. To test: - Search for the OAI-PMH:archiveID syspref on the staff interface => FAIL: Notice the colon is placed *after* the input, and looks weird. - Apply this patch - Reload the page => SUCCESS: The colon is placed *before* the input, and looks more correct. - Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22133 Devinim <kohadevinim@devinim.com.tr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22133 Devinim <kohadevinim@devinim.com.tr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83950|0 |1 is obsolete| | --- Comment #2 from Devinim <kohadevinim@devinim.com.tr> --- Created attachment 83996 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83996&action=edit Bug 22133: Wrong layout in OAI-PMH:archiveID syspref description This patch fixes a trivial text layout problem on the syspref description. To test: - Search for the OAI-PMH:archiveID syspref on the staff interface => FAIL: Notice the colon is placed *after* the input, and looks weird. - Apply this patch - Reload the page => SUCCESS: The colon is placed *before* the input, and looks more correct. - Sign off :-D Signed-off-by: Devinim <kohadevinim@devinim.com.tr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22133 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #3 from David Cook <dcook@prosentient.com.au> --- I think the colon might be after the OAI-PMH:archiveID to show that they don't need to include the colon in the value itself? I've been wondering if it's worth adding the following to the description: http://www.openarchives.org/OAI/openarchivesprotocol.html#UniqueIdentifier http://www.openarchives.org/OAI/2.0/guidelines-oai-identifier.htm I suppose if people are interested in OAI-PMH, they should look it up themselves, but I know it's taken me years to read these documents inside and out. Maybe we could add something like "E.g. <OAI-PMH:archiveID>:<biblionumber>" to make it more obvious about how the identifier is constructed using this system preference?" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22133 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer@bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I agree with David in that I understand the : as a hint to not enter it. Tomas, could you take a look at comment 3 and comment please? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22133 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21926 CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22133 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |DUPLICATE --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- *** This bug has been marked as a duplicate of bug 21926 *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org