[Bug 39062] New: Increase length of items.stocknumber (Inventory Number)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39062 Bug ID: 39062 Summary: Increase length of items.stocknumber (Inventory Number) Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Database Assignee: koha-bugs@lists.koha-community.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org items.stocknumber (labeled as Inventory Number, 952$i, in edit interface) is a field that many libraries use to hold an idiosyncratic bit of local data. For such libraries, the 32 character limit can be an issue. If there's a compelling reason not to increase the size of this field, I haven't thought of or found it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39062 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |andrew@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39062 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39062 --- Comment #1 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 177602 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177602&action=edit Bug 39062: increase length of items.stocknumber and deleteditems.stocknumber in kohastructure.sql To test: 1: try to save a value in the 952$i that is more than 32 characters 2: It does not work. 3: apply patch 4: try to save a value in the 952$i that is more than 32 characters 5: it does work! 6: delete your item and use a report to confirm the full string is in deleteditems.stocknumber 7: Maybe use DESCRIBE from mysql commandline to see the length and confirm it's changed? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39062 --- Comment #2 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 177603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177603&action=edit Bug 39062: Increase stocknumber length in items and deleteditems -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39062 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177603|0 |1 is obsolete| | --- Comment #3 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 177604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177604&action=edit Bug 39062: Increase stocknumber length in items and deleteditems But this time I spelled deleted correctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39062 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #4 from David Cook <dcook@prosentient.com.au> --- At a glance, I think you've accidentally obsoleted a patch you shouldn't have. I'll try to restore that... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39062 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177603|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39062 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177602|0 |1 is obsolete| | --- Comment #5 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 177697 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177697&action=edit Bug 39062: increase length of items.stocknumber and deleteditems.stocknumber in kohastructure.sql To test: 1: try to save a value in the 952$i that is more than 32 characters 2: It does not work. 3: apply patch 4: try to save a value in the 952$i that is more than 32 characters 5: it does work! 6: delete your item and use a report to confirm the full string is in deleteditems.stocknumber 7: Maybe use DESCRIBE from mysql commandline to see the length and confirm it's changed? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39062 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177603|0 |1 is obsolete| | Attachment #177604|0 |1 is obsolete| | --- Comment #6 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 177698 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177698&action=edit Bug 39062: Increase stocknumber length in items and deleteditems -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39062 --- Comment #7 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- (In reply to David Cook from comment #4)
At a glance, I think you've accidentally obsoleted a patch you shouldn't have. I'll try to restore that...
Thanks, I think I've successfully fixed those into one patch! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39062 --- Comment #8 from David Cook <dcook@prosentient.com.au> --- (In reply to Andrew Fuerste-Henry from comment #7)
(In reply to David Cook from comment #4)
At a glance, I think you've accidentally obsoleted a patch you shouldn't have. I'll try to restore that...
Thanks, I think I've successfully fixed those into one patch!
Looks good! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39062 --- Comment #9 from David Cook <dcook@prosentient.com.au> --- The test report should probably mentioning needing to update the database in addition to applying the patch, but all good... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39062 --- Comment #10 from David Cook <dcook@prosentient.com.au> --- QA tools complaining about tidiness but I think we're not caring about that anymore... WARN installer/data/mysql/atomicupdate/bug_39062_increase_stocknumber_length.pl WARN tidiness The file is less tidy than before (bad/messy lines before: 0, now: 2) OK installer/data/mysql/kohastructure.sql -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39062 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39062 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177697|0 |1 is obsolete| | --- Comment #11 from David Cook <dcook@prosentient.com.au> --- Created attachment 177716 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177716&action=edit Bug 39062: increase length of items.stocknumber and deleteditems.stocknumber in kohastructure.sql To test: 1: try to save a value in the 952$i that is more than 32 characters 2: It does not work. 3: apply patch 4: try to save a value in the 952$i that is more than 32 characters 5: it does work! 6: delete your item and use a report to confirm the full string is in deleteditems.stocknumber 7: Maybe use DESCRIBE from mysql commandline to see the length and confirm it's changed? Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39062 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177698|0 |1 is obsolete| | --- Comment #12 from David Cook <dcook@prosentient.com.au> --- Created attachment 177717 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177717&action=edit Bug 39062: Increase stocknumber length in items and deleteditems Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39062 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Status|Signed Off |Failed QA --- Comment #13 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- FAIL installer/data/mysql/atomicupdate/bug_39062_increase_stocknumber_length.pl FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl installer/data/mysql/atomicupdate/bug_39062_increase_stocknumber_length.pl` -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39062 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39062 --- Comment #14 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 179114 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179114&action=edit Bug 39062: (QA follow-up): Tidying the atomic update -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39062 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39062 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177716|0 |1 is obsolete| | --- Comment #15 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 179793 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179793&action=edit Bug 39062: increase length of items.stocknumber and deleteditems.stocknumber in kohastructure.sql To test: 1: try to save a value in the 952$i that is more than 32 characters 2: It does not work. 3: apply patch 4: try to save a value in the 952$i that is more than 32 characters 5: it does work! 6: delete your item and use a report to confirm the full string is in deleteditems.stocknumber 7: Maybe use DESCRIBE from mysql commandline to see the length and confirm it's changed? Signed-off-by: David Cook <dcook@prosentient.com.au> Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39062 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177717|0 |1 is obsolete| | --- Comment #16 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 179794 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179794&action=edit Bug 39062: Increase stocknumber length in items and deleteditems Signed-off-by: David Cook <dcook@prosentient.com.au> Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39062 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179114|0 |1 is obsolete| | --- Comment #17 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 179795 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179795&action=edit Bug 39062: (QA follow-up): Tidying the atomic update Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39062 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Increase length of |Increase length of |items.stocknumber |items.stocknumber |(Inventory Number) |(inventory number) --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Please always use the "say_success" for the success message in the database udpate! I've also squashed the tidy patch into the previous on trying to avoid tidy only patches now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39062 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |baptiste.wojtkowski@biblibr |y.org |e.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39062 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39062 --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39062 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |The length of the inventory release notes| |(items.stocknumber) field | |was increased from 32 | |characters to 80 | |characters. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39062 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Increase length of |Increase length of |items.stocknumber |inventory number field in |(inventory number) |database -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39062 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to main |Needs documenting --- Comment #20 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 24.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org