[Bug 33798] New: Vendor details - improve consistency of edit forms and display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33798 Bug ID: 33798 Summary: Vendor details - improve consistency of edit forms and display Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: david@davidnind.com QA Contact: testopia@bugs.koha-community.org For vendor details in acquisitions, there are some inconsistencies in the display of the edit forms and vendor details. This could do with some tidy ups. Specific items: 1. Field labels when displaying vendor details - bold and plain text: for some sections, field labels are in bold, others are just plain text (for example: 'Vendor details' labels are in plain text, for 'Ordering information' they are bold). 2. Edit form for 'Interface details' missing colons after the labels. 2. Accessibility issues: using the WAVE Evaluation Tool browser extension (https://wave.webaim.org/), it shows lots of errors and warnings, such as missing or multiple form labels, and empty buttons and links (some of which may or may not be valid). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33798 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33798 --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 151893 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151893&action=edit Bug 33798: Add colons after the labels on the edit form -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33798 --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 151894 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151894&action=edit Bug 33798: Improve consistency of the vendor display view It was not consistent: indentation, bold, etc. This patch is suggesting a new style using .page-section and .rows Is it what we want? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33798 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart+koha@gmail. |ity.org |com CC| |jonathan.druart+koha@gmail. | |com, oleonard@myacpl.org Status|NEW |In Discussion --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Owen, can I get your opinion on the second patch please? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33798 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Jonathan Druart from comment #3)
Owen, can I get your opinion on the second patch please?
Looks like a good improvement to me! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33798 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33798 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33798 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151893|0 |1 is obsolete| | --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 152069 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152069&action=edit Bug 33798: Add colons after the labels on the edit form Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33798 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151894|0 |1 is obsolete| | --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 152070 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152070&action=edit Bug 33798: Improve consistency of the vendor display view It was not consistent: indentation, bold, etc. This patch is suggesting a new style using .page-section and .rows Is it what we want? Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33798 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes display errors release notes| |and improves the | |consistency of the vendor | |page and edit forms in | |acquisitions. Includes | |adding colons to field | |labels when adding an | |interface, making field | |labels all bold, and | |addressing some | |accessibility issues. --- Comment #7 from David Nind <david@davidnind.com> --- Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33798 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33798 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33798 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152070|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 152191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152191&action=edit Bug 33798: Improve consistency of the vendor display view It was not consistent: indentation, bold, etc. This patch is suggesting a new style using .page-section and .rows Is it what we want? Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33798 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33798 --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33798 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.11.00 |23.11.00,23.05.02 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33798 --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks for all the hard work! Pushed to 23.05.x for the next release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33798 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33104 CC| |matt.blenkinsop@ptfs-europe | |.com Status|Pushed to stable |RESOLVED Resolution|--- |FIXED --- Comment #11 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Appears to be dependent on 33104 which has not been backported to 22.11.x - not backporting on this basis Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 [Bug 33104] Add vendor interfaces -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33798 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35272 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35272 [Bug 35272] Add padding above vendor contracts section -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org