[Bug 31991] New: Restore style of sidebar forms
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31991 Bug ID: 31991 Summary: Restore style of sidebar forms Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Depends on: 30952 A lot of changes were made the the style of sidebar forms (usually filter forms in an <aside> which I don't think were necessary to keep with the new design. I think it would be better to keep (and tweak) the old CSS. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31991 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31991 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 142673 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142673&action=edit Bug 31991: Restore style of sidebar forms This patch restores the aside{} section of staff-global.scss from before the staff redesign and makes some tweaks to make it consisten with the redesign. The goal is to make the spacing of the form more compact but still readable, and to correct some layout inconsistencies. The patch also modifies the order filter form to fix the layout of some checkboxes. To test, apply the patch and rebuild the staff interface CSS. Test various pages with sidebar forms to confirm that the form looks readable and usable. For example: - Patrons - Acquisitions -> Invoices - Tools -> Tags - Serials -> Subscription search results - Overdues - Holds to pull -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31991 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31991 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142673|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 142684 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142684&action=edit Bug 31991: Restore style of sidebar forms This patch restores the aside{} section of staff-global.scss from before the staff redesign and makes some tweaks to make it consisten with the redesign. The goal is to make the spacing of the form more compact but still readable, and to correct some layout inconsistencies. The patch also modifies the order filter form to fix the layout of some checkboxes. To test, apply the patch and rebuild the staff interface CSS. Test various pages with sidebar forms to confirm that the form looks readable and usable. For example: - Patrons - Acquisitions -> Invoices - Tools -> Tags - Serials -> Subscription search results - Overdues - Holds to pull Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31991 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31991 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- Not sure about these ones, as I think they are outside the scope of this bug. Happy to add separate bugs for these to fix up the form inconsistencies. 1. Acquisitions > Suggestions management: has expandable sections that open when clicked with the form for each option - there is no space between the last field and the button(s), there is no space before the left margin for the "Filter by:" heading. 2. Administration > Budgets > All funds: "Filters" link outside the filter box, here is no space between the last field and the button(s), grey space after before the other sidebar options. 3. Tools > Tags: apply filters button has no colour 4. Tools > News: the heading "Filter" is outside the box with the white background, there is no "Action" button - but selections work, however, there is a grey background line after the end of the filter and the other sidebar options. 5. Tools > Pages: same as for Tools > News. 6. Reports > Use saved: Gray space before buttons, no white space after. Others checked: - Acquisitions > Late orders: OK. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31991 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31998 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31991 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 142685 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142685&action=edit k -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31991 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31991 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142684|0 |1 is obsolete| | Attachment #142685|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 142686 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142686&action=edit Bug 31991: Restore style of sidebar forms This patch restores the aside{} section of staff-global.scss from before the staff redesign and makes some tweaks to make it consisten with the redesign. The goal is to make the spacing of the form more compact but still readable, and to correct some layout inconsistencies. The patch also modifies the order filter form to fix the layout of some checkboxes. To test, apply the patch and rebuild the staff interface CSS. Test various pages with sidebar forms to confirm that the form looks readable and usable. For example: - Patrons - Acquisitions -> Invoices - Tools -> Tags - Serials -> Subscription search results - Overdues - Holds to pull Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31991 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31991 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31991 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31991 Bug 31991 depends on bug 30952, which changed state. Bug 30952 Summary: New design for staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org