[Bug 30756] New: Get skip block out of Koha_Authority.t and add TestBuilder
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30756 Bug ID: 30756 Summary: Get skip block out of Koha_Authority.t and add TestBuilder Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: m.de.rooy@rijksmuseum.nl QA Contact: testopia@bugs.koha-community.org This test contains 3 skips on Jenkins. It uses a MARC file. We could quite easily resolve this with TestBuilder. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30756 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30756 --- Comment #1 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 134998 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134998&action=edit Bug 30756: Ground work for improving Koha_Authority.t Move stuff into two subtests. Test plan: Run t/db_dependent/Koha_Authority.t. If you have no imported auths, you will still see skips. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30756 --- Comment #2 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 134999 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134999&action=edit Bug 30756: Further adjustments to Koha_Authority.t Remove use of exported_records file in favor of TestBuilder. Remove conditional tests with SKIP block. Create reservoir record. Test plan: Run t/db_dependent/Koha_Authority.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30756 --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 135000 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135000&action=edit Bug 30756: Rename to Koha_MetadataRecord_Authority What we are actually testing here. No test plan. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30756 --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- So we should no longer see these 3 on Jenkins: t_db_dependent_Koha_Authority_t 0.82 sec 0 3 8 11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30756 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris@bigballofwax.co.nz |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30756 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30756 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134998|0 |1 is obsolete| | --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 135004 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135004&action=edit Bug 30756: Ground work for improving Koha_Authority.t Move stuff into two subtests. Test plan: Run t/db_dependent/Koha_Authority.t. If you have no imported auths, you will still see skips. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30756 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134999|0 |1 is obsolete| | --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 135005 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135005&action=edit Bug 30756: Further adjustments to Koha_Authority.t Remove use of exported_records file in favor of TestBuilder. Remove conditional tests with SKIP block. Create reservoir record. Test plan: Run t/db_dependent/Koha_Authority.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30756 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135000|0 |1 is obsolete| | --- Comment #7 from David Nind <david@davidnind.com> --- Created attachment 135006 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135006&action=edit Bug 30756: Rename to Koha_MetadataRecord_Authority What we are actually testing here. No test plan. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30756 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #8 from David Nind <david@davidnind.com> --- I tested in koha-testing-docker: 1. Ran tests before applying patches and these passed: prove t/db_dependent/Koha_Authority.t 2. Ran tests using new name after applying patches, and these passed: prove t/db_dependent/Koha_MetadataRecord_Authority.t Hope that is sufficient. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30756 --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to David Nind from comment #8)
I tested in koha-testing-docker:
1. Ran tests before applying patches and these passed: prove t/db_dependent/Koha_Authority.t
2. Ran tests using new name after applying patches, and these passed: prove t/db_dependent/Koha_MetadataRecord_Authority.t
Hope that is sufficient.
Great. Thx -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30756 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30756 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135004|0 |1 is obsolete| | Attachment #135005|0 |1 is obsolete| | Attachment #135006|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 135104 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135104&action=edit Bug 30756: Ground work for improving Koha_Authority.t Move stuff into two subtests. Test plan: Run t/db_dependent/Koha_Authority.t. If you have no imported auths, you will still see skips. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30756 --- Comment #11 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 135105 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135105&action=edit Bug 30756: Further adjustments to Koha_Authority.t Remove use of exported_records file in favor of TestBuilder. Remove conditional tests with SKIP block. Create reservoir record. Test plan: Run t/db_dependent/Koha_Authority.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30756 --- Comment #12 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 135106 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135106&action=edit Bug 30756: Rename to Koha_MetadataRecord_Authority What we are actually testing here. No test plan. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> JD amended patch: remove Dumper Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30756 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30756 --- Comment #13 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30756 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #14 from Nick Clemens <nick@bywatersolutions.com> --- Search.t failing now, the records file was being used there as well t/db_dependent/Search.t: 277 $mock_zebra->load_records( 278 sprintf( "%s/%s/zebraexport/authority", $sourcedir, lc($marcflavour) ), 279 'iso2709', 'authorities', 1 280 ); -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30756 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30756 --- Comment #15 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Nick Clemens from comment #14)
Search.t failing now, the records file was being used there as well
t/db_dependent/Search.t: 277 $mock_zebra->load_records( 278 sprintf( "%s/%s/zebraexport/authority", $sourcedir, lc($marcflavour) ), 279 'iso2709', 'authorities', 1 280 );
Will have a look -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30756 --- Comment #16 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 135702 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135702&action=edit Bug 30756: (follow-up) Restore MARC21 authority file Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30756 --- Comment #17 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Tomás Cohen Arazi from comment #16)
Created attachment 135702 [details] [review] Bug 30756: (follow-up) Restore MARC21 authority file
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Thx. Considering this at least a temporary fix? When I grepped on this exported_records file, I couldnt find a reference, but it is pumped into zebraidx via the folder where it is (without file name). A discussion on itself is how we should test the search engine. We are starting Zebra and Elastic now to do so. Calling it a mock ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30756 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Version(s)|22.11.00 |22.11.00, 22.05.01 released in| | Status|Pushed to master |Pushed to stable --- Comment #18 from Lucas Gass <lucas@bywatersolutions.com> --- Pushed to 22.05.x for 22.05.01 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30756 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|22.11.00, 22.05.01 |22.11.00, 22.05.01, released in| |21.11.07 CC| |arthur.suzuki@biblibre.com --- Comment #19 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- thx, pushed to 21.11.x for 21.11.07 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30756 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED CC| |victor@tuxayo.net --- Comment #20 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document, marking resolved. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30756 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org