[Bug 21272] New: Marc import should warn about mis-matched branch and item-type fields in 952 during marc import.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Bug ID: 21272 Summary: Marc import should warn about mis-matched branch and item-type fields in 952 during marc import. Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: barton@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org When importing a record that has homebranch (952$a), holding branch (952$b) or item type (952$y) populated, but not matching values in branches.branchcode or itemtypes.itemtype, koha will indicate that items were not imported (via the count of imported items), but not why. This causes frequent confusion among new users. It would be nice to offer mappings between detected branches / item types and the branches and item types already in the system. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@collect | |o.ca -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Marc import should warn |MARC import should warn |about mis-matched branch |about mis-matched branch |and item-type fields in 952 |and item-type fields in 952 |during marc import. |during staged import -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala@iki.fi --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 14768 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hammat.wele@inlibro.com Assignee|koha-bugs@lists.koha-commun |hammat.wele@inlibro.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 --- Comment #2 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 155038 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155038&action=edit Bug 21272: MARC import should warn about mis-matched branch and item-type fields in 952 during staged import This plugin add a warning message to show missing branches during staged import, it also ignore item with wrong banches. To test Before make sure backgroundjobs process is running (/misc/workers/background_jobs_worker.pl --queue long_tasks) 1- Go to Cataloging -> Stage records for import 2 - Upload a MARC file (koha.mrc) that contain items with homebranch and/or homelibraary set and is not present in your installation 3- Click on Stage for import 4- Click on View batch --> There is no message for the missing branches 5- Click on "Import this batch into the catalog" --> The importation failed 6- Apply the patch 7- Run prove -t t/db_dependent/ImportBatch.t 8- Click on "Manage imported batch" --> There is a warning message showing the missing branches in a link 9- Click on "Import this batch into the catalog" again --> The records are imported --> The items with wrong branches are ignored https://bugs.koha-community.org/show_bug.cgi?id=12532 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 --- Comment #3 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 155039 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155039&action=edit Bug 21272: Unit test https://bugs.koha-community.org/show_bug.cgi?id=12532 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 --- Comment #4 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 155043 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155043&action=edit Exported Marc file that contains items with branche code -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com, | |philippe.blouin@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155038|0 |1 is obsolete| | --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 155523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155523&action=edit Bug 21272: MARC import should warn about mis-matched branch and item-type fields in 952 during staged import This plugin add a warning message to show missing branches during staged import, it also ignore item with wrong banches. To test Before make sure backgroundjobs process is running (/misc/workers/background_jobs_worker.pl --queue long_tasks) 1- Go to Cataloging -> Stage records for import 2 - Upload a MARC file (koha.mrc) that contain items with homebranch and/or homelibraary set and is not present in your installation 3- Click on Stage for import 4- Click on View batch --> There is no message for the missing branches 5- Click on "Import this batch into the catalog" --> The importation failed 6- Apply the patch 7- Run prove -t t/db_dependent/ImportBatch.t 8- Click on "Manage imported batch" --> There is a warning message showing the missing branches in a link 9- Click on "Import this batch into the catalog" again --> The records are imported --> The items with wrong branches are ignored Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155039|0 |1 is obsolete| | --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 155524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155524&action=edit Bug 21272: Unit test Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement adds a release notes| |warning message when | |importing staged records to | |show library codes in the | |imported file that do not | |match with what is | |configured in Koha. It also | |does not import these | |items. CC| |david@davidnind.com --- Comment #7 from David Nind <david@davidnind.com> --- Thanks for adding a sample MARC file! I amended the commit messages to remove the link to bug 12532 (hope I have done this correctly!). I will add a follow-up to fix terminology and formatting: - In US English for the warning message: no space between the end of the warning message and the colon - "...missing branches...": changed to "...missing libraries..." (see https://wiki.koha-community.org/wiki/Terminology#B) For me, this did not seem to show a warning message when the item types in 952 don't match. I'm assuming these patches only cover library code mismatches. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 --- Comment #8 from David Nind <david@davidnind.com> --- Created attachment 155525 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155525&action=edit Bug 21272: (follow-up) Terminology and formatting Change warning message to "..missing libraries...". Remove space before colon for the warning message. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Comment on attachment 155523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155523 Bug 21272: MARC import should warn about mis-matched branch and item-type fields in 952 during staged import Review of attachment 155523: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=21272&attachment=155523) ----------------------------------------------------------------- ::: C4/ImportBatch.pm @@ +819,5 @@
+ my ( $holdingbranchfield, $holdingbranchsubfield ) = GetMarcFromKohaField('items.holdingbranch'); + my $holdingbranch = $item_marc->subfield( $holdingbranchfield, $holdingbranchsubfield ); + + my @branches = map { $_->branchcode } Koha::Libraries->search->as_list; + my %branches = map { $_ => 1 } @branches;
why not use https://perldoc.perl.org/List::Util#any and get rid of %branches @@ +1235,5 @@
+ WHERE import_batch_id = ? + ORDER BY import_items_id"; + my @params; + push( @params, $batch_id ); + my $sth = $dbh->prepare_cached($query);
Should this be a cached querey? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 --- Comment #10 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 158683 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158683&action=edit Bug 21272: (follow-up) using List::MoreUtils#any to get rid of %branches and fixing GetImportItemsBranches in ImportBatch.pm -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Please also fix the bug description, I think this bug only covers one half of it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Signed Off |Failed QA --- Comment #12 from Kyle M Hall <kyle@bywatersolutions.com> --- I don't feel that the language "There are some missing libraries in your installation:" is good or sound. I think the better presumption is that the record has incorrect values, rather than those values should be created to accommodate those records. It just feels a bit wild to have a link to create new branches from the cataloging module. Are catalogers often charged with creating new branches? It looks like there is no permission check for this link either. I this feature simply needs to report the record values that don't match up with anything already in the database. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Matthias Le Gac <matthias.le-gac@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|MARC import should warn |MARC import should warn |about mis-matched branch |about mis-matched branch |and item-type fields in 952 |during staged import |during staged import | CC| |matthias.le-gac@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Matthias Le Gac <matthias.le-gac@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|hammat.wele@inlibro.com |matthias.le-gac@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Matthias Le Gac <matthias.le-gac@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 --- Comment #13 from Matthias Le Gac <matthias.le-gac@inlibro.com> --- Created attachment 163646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163646&action=edit Bug 21272: Change warning message To test Before make sure backgroundjobs process is running (/misc/workers/background_jobs_worker.pl --queue long_tasks) 1- Go to Cataloging -> Stage records for import 2 - Upload a MARC file (koha.mrc) that contain items with homebranch and/or homelibraary set and is not present in your installation 3- Click on Stage for import 4- Click on View batch --> There is no message for the missing branches 5- Click on "Import this batch into the catalog" --> The importation failed 6- Apply the patch 7- Run prove -t t/db_dependent/ImportBatch.t 8- Click on "Manage imported batch" --> There is a warning message showing the missing branches in a link 9- Click on "Import this batch into the catalog" again --> The records are imported --> The items with wrong branches are ignored -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Matthias Le Gac <matthias.le-gac@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Matthias Le Gac <matthias.le-gac@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Matthias Le Gac <matthias.le-gac@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163646|0 |1 is obsolete| | --- Comment #14 from Matthias Le Gac <matthias.le-gac@inlibro.com> --- Created attachment 163648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163648&action=edit Bug 21272: Change warning message To test Before make sure backgroundjobs process is running (/misc/workers/background_jobs_worker.pl --queue long_tasks) 1- Go to Cataloging -> Stage records for import 2 - Upload a MARC file (koha.mrc) that contain items with homebranch and/or homelibraary set and is not present in your installation 3- Click on Stage for import 4- Click on View batch --> There is no message for the missing branches 5- Click on "Import this batch into the catalog" --> The importation failed 6- Apply the patch 7- Run prove -t t/db_dependent/ImportBatch.t 8- Click on "Manage imported batch" --> There is a warning message showing the missing branches in a link 9- Click on "Import this batch into the catalog" again --> The records are imported --> The items with wrong branches are ignored -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Esther Melander <esther.melander@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |esther.melander@bywatersolu | |tions.com --- Comment #15 from Esther Melander <esther.melander@bywatersolutions.com> --- I tested this. I had 5 bibliographic records with attached items. Each bibliographic record had multiple copies/items. I edited the first item on the first bibliographic record in the import file to have an incorrect branch code. When staging, I selected the option to always add the items. After staging the file, I received the warning that an item has an incorrect branchcode (nice!). I proceeded to import the file. None of the bibliographic records imported any items. I did not see a link in the warning message? I would have expected the one item with the incorrect branch code to be ignored. I could even expect the bibliographic record that contained this item would not have any items brought in. But I would expect the rest of the bibliographic records would import their items. It would be even more helpful if the warning message was more specific. If this was a large import file with a few hundred items, finding the one item with the bad branch code would be quite time consuming. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 --- Comment #16 from Matthias Le Gac <matthias.le-gac@inlibro.com> --- Would it be possible for you to make the file you import available? Because when I run the test with the file provided by Hammat, it works correctly. I agree with you, I'll see if I can improve the display. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Matthias Le Gac <matthias.le-gac@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Matthias Le Gac <matthias.le-gac@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 --- Comment #17 from Matthias Le Gac <matthias.le-gac@inlibro.com> --- Created attachment 164143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164143&action=edit Bug 21272: Improve warning message To test Before make sure backgroundjobs process is running (/misc/workers/background_jobs_worker.pl --queue long_tasks) 1- Go to Cataloging -> Stage records for import 2 - Upload a MARC file (koha.mrc) that contain items with homebranch and/or homelibraary set and is not present in your installation 3- Click on Stage for import 4- Click on View batch --> There is no message for the missing branches 5- Click on "Import this batch into the catalog" --> The importation failed 6- Apply the patch 7- Run prove -t t/db_dependent/ImportBatch.t 8- Click on "Manage imported batch" --> There is a warning message showing the missing branches --> There is a warning message showing the titles of the wrong items 9- Click on "Import this batch into the catalog" again --> The records are imported --> The items with wrong branches are ignored -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Matthias Le Gac <matthias.le-gac@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #18 from Matthias Le Gac <matthias.le-gac@inlibro.com> --- I have to add tests for the two new methods I added in Import.pm but tell me if the warning is better ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 --- Comment #19 from Esther Melander <esther.melander@bywatersolutions.com> --- Created attachment 164147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164147&action=edit Import file with an attached items and bad branch code on one Here is the import file I tested with. Only one item on one bibliographic record has a bad branch code. That bibliographic record is Working effectively with legacy code, the first item has a branch code of MPAL instead of MPL. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 --- Comment #20 from Esther Melander <esther.melander@bywatersolutions.com> --- I tested again and the error message is improved. It would be nice if the error message was retained in some way so that it can be referenced again after the import in the Manage Stage records for the file. Hammat's file works and the items with bad codes are ignored and the other items are brought in. My import file contains bibliographic records with multiple items for each. The error message was triggered correctly for the one item with a bad branch code. However, none of the items were brought in. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Matthias Le Gac <matthias.le-gac@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164143|0 |1 is obsolete| | --- Comment #21 from Matthias Le Gac <matthias.le-gac@inlibro.com> --- Created attachment 164148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164148&action=edit Bug 21272: Improve warning message To test Before make sure backgroundjobs process is running (/misc/workers/background_jobs_worker.pl --queue long_tasks) 1- Go to Cataloging -> Stage records for import 2 - Upload a MARC file (koha.mrc) that contain items with homebranch and/or homelibraary set and is not present in your installation 3- Click on Stage for import 4- Click on View batch --> There is no message for the missing branches 5- Click on "Import this batch into the catalog" --> The importation failed 6- Apply the patch 7- Run prove -t t/db_dependent/ImportBatch.t 8- Click on "Manage imported batch" --> There is a warning message showing the missing branches --> There is a warning message showing the titles of the wrong items 9- Click on "Import this batch into the catalog" again --> The records are imported --> The items with wrong branches are ignored Current status: Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 --- Comment #22 from Matthias Le Gac <matthias.le-gac@inlibro.com> --- (In reply to Matthias Le Gac from comment #21)
Created attachment 164148 [details] [review] Bug 21272: Improve warning message
To test
Before make sure backgroundjobs process is running (/misc/workers/background_jobs_worker.pl --queue long_tasks)
1- Go to Cataloging -> Stage records for import 2 - Upload a MARC file (koha.mrc) that contain items with homebranch and/or homelibraary set and is not present in your installation 3- Click on Stage for import 4- Click on View batch --> There is no message for the missing branches 5- Click on "Import this batch into the catalog" --> The importation failed 6- Apply the patch 7- Run prove -t t/db_dependent/ImportBatch.t 8- Click on "Manage imported batch" --> There is a warning message showing the missing branches --> There is a warning message showing the titles of the wrong items 9- Click on "Import this batch into the catalog" again --> The records are imported --> The items with wrong branches are ignored
Current status: Failed QA
Just make tideness -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 --- Comment #23 from Matthias Le Gac <matthias.le-gac@inlibro.com> --- (In reply to Esther Melander from comment #20)
I tested again and the error message is improved. It would be nice if the error message was retained in some way so that it can be referenced again after the import in the Manage Stage records for the file.
Hammat's file works and the items with bad codes are ignored and the other items are brought in.
My import file contains bibliographic records with multiple items for each. The error message was triggered correctly for the one item with a bad branch code. However, none of the items were brought in.
Ok I will check with your file -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 --- Comment #24 from Matthias Le Gac <matthias.le-gac@inlibro.com> --- Created attachment 164149 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164149&action=edit Bug 21272: Unit test for methods GetBadBranchesImportItems and GetTitleImportRecord Current status: Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Matthias Le Gac <matthias.le-gac@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #25 from Matthias Le Gac <matthias.le-gac@inlibro.com> --- I tested with your file and the items that are good imported well and those with bad branches did not. For the record "Working effectively with legacy code" I have the item with homebranch "FPL" but not the item with homebranch "MPAL". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|matthias.le-gac@inlibro.com |hammat.wele@inlibro.com CC|matthias.le-gac@inlibro.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Miranda Nero <mnero@oslri.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mnero@oslri.net -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155523|0 |1 is obsolete| | --- Comment #26 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 178921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178921&action=edit Bug 21272: MARC import should warn about mis-matched branch and item-type fields in 952 during staged import This plugin add a warning message to show missing branches during staged import, it also ignore item with wrong banches. To test Before make sure backgroundjobs process is running (/misc/workers/background_jobs_worker.pl --queue long_tasks) 1- Go to Cataloging -> Stage records for import 2 - Upload a MARC file (koha.mrc) that contain items with homebranch and/or homelibraary set and is not present in your installation 3- Click on Stage for import 4- Click on View batch --> There is no message for the missing branches 5- Click on "Import this batch into the catalog" --> The importation failed 6- Apply the patch 7- Run prove -t t/db_dependent/ImportBatch.t 8- Click on "Manage imported batch" --> There is a warning message showing the missing branches in a link 9- Click on "Import this batch into the catalog" again --> The records are imported --> The items with wrong branches are ignored Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155524|0 |1 is obsolete| | --- Comment #27 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 178922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178922&action=edit Bug 21272: Unit test Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155525|0 |1 is obsolete| | --- Comment #28 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 178923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178923&action=edit Bug 21272: (follow-up) Terminology and formatting Change warning message to "..missing libraries...". Remove space before colon for the warning message. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158683|0 |1 is obsolete| | --- Comment #29 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 178924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178924&action=edit Bug 21272: (follow-up) using List::MoreUtils#any to get rid of %branches and fixing GetImportItemsBranches in ImportBatch.pm -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163648|0 |1 is obsolete| | --- Comment #30 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 178925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178925&action=edit Bug 21272: Change warning message -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164148|0 |1 is obsolete| | --- Comment #31 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 178926 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178926&action=edit Bug 21272: Improve warning message To test Before make sure backgroundjobs process is running (/misc/workers/background_jobs_worker.pl --queue long_tasks) 1- Go to Cataloging -> Stage records for import 2 - Upload a MARC file (koha.mrc) that contain items with homebranch and/or homelibraary set and is not present in your installation 3- Click on Stage for import 4- Click on View batch --> There is no message for the missing branches 5- Click on "Import this batch into the catalog" --> The importation failed 6- Apply the patch 7- Run prove -t t/db_dependent/ImportBatch.t 8- Click on "Manage imported batch" --> There is a warning message showing the missing branches --> There is a warning message showing the titles of the wrong items 9- Click on "Import this batch into the catalog" again --> The records are imported --> The items with wrong branches are ignored -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164149|0 |1 is obsolete| | --- Comment #32 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 178927 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178927&action=edit Bug 21272: Unit test for methods GetBadBranchesImportItems and GetTitleImportRecord -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 --- Comment #33 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 178928 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178928&action=edit Bug 21272: (follow-up) tidy code -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178921|0 |1 is obsolete| | --- Comment #34 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 179837 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179837&action=edit Bug 21272: MARC import should warn about mis-matched branch and item-type fields in 952 during staged import This plugin add a warning message to show missing branches during staged import, it also ignore item with wrong banches. To test Before make sure backgroundjobs process is running (/misc/workers/background_jobs_worker.pl --queue long_tasks) 1- Go to Cataloging -> Stage records for import 2 - Upload a MARC file (koha.mrc) that contain items with homebranch and/or homelibraary set and is not present in your installation 3- Click on Stage for import 4- Click on View batch --> There is no message for the missing branches 5- Click on "Import this batch into the catalog" --> The importation failed 6- Apply the patch 7- Run prove -t t/db_dependent/ImportBatch.t 8- Click on "Manage imported batch" --> There is a warning message showing the missing branches in a link 9- Click on "Import this batch into the catalog" again --> The records are imported --> The items with wrong branches are ignored Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178922|0 |1 is obsolete| | --- Comment #35 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 179838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179838&action=edit Bug 21272: Unit test Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178923|0 |1 is obsolete| | --- Comment #36 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 179839 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179839&action=edit Bug 21272: (follow-up) Terminology and formatting Change warning message to "..missing libraries...". Remove space before colon for the warning message. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178924|0 |1 is obsolete| | --- Comment #37 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 179840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179840&action=edit Bug 21272: (follow-up) using List::MoreUtils#any to get rid of %branches and fixing GetImportItemsBranches in ImportBatch.pm -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178925|0 |1 is obsolete| | --- Comment #38 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 179841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179841&action=edit Bug 21272: Change warning message -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178926|0 |1 is obsolete| | --- Comment #39 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 179842 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179842&action=edit Bug 21272: Improve warning message To test Before make sure backgroundjobs process is running (/misc/workers/background_jobs_worker.pl --queue long_tasks) 1- Go to Cataloging -> Stage records for import 2 - Upload a MARC file (koha.mrc) that contain items with homebranch and/or homelibraary set and is not present in your installation 3- Click on Stage for import 4- Click on View batch --> There is no message for the missing branches 5- Click on "Import this batch into the catalog" --> The importation failed 6- Apply the patch 7- Run prove -t t/db_dependent/ImportBatch.t 8- Click on "Manage imported batch" --> There is a warning message showing the missing branches --> There is a warning message showing the titles of the wrong items 9- Click on "Import this batch into the catalog" again --> The records are imported --> The items with wrong branches are ignored -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178927|0 |1 is obsolete| | --- Comment #40 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 179843 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179843&action=edit Bug 21272: Unit test for methods GetBadBranchesImportItems and GetTitleImportRecord -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178928|0 |1 is obsolete| | --- Comment #41 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 179844 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179844&action=edit Bug 21272: (follow-up) tidy code -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 --- Comment #42 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 180383 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180383&action=edit Bug 21272: (follow-up) Fix unit test -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Philip Orr <philip.orr@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |philip.orr@lmscloud.de --- Comment #43 from Philip Orr <philip.orr@lmscloud.de> --- First of all: tests worked, will sign off. Secondly I have some minor suggestions for the warning messages. - it would be nice to show the records on newlines and not separated by | on the same line, easier to read. - "One and more": should be "One or more" (or just: "Several" if you know there is more than one) - the warning message is using the dialog alert class. But it's not very easy to visually directly interpret as a warning message if you ask me, it's gray text on gray background, not quickly noticeable. I would have expected it to stand out more from the other content. I will leave it to the QA people though as I'm not experienced enough in this kind of thing.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Philip Orr <philip.orr@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Philip Orr <philip.orr@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179837|0 |1 is obsolete| | --- Comment #44 from Philip Orr <philip.orr@lmscloud.de> --- Created attachment 180534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180534&action=edit Bug 21272: MARC import should warn about mis-matched branch and item-type fields in 952 during staged import This plugin add a warning message to show missing branches during staged import, it also ignore item with wrong banches. To test Before make sure backgroundjobs process is running (/misc/workers/background_jobs_worker.pl --queue long_tasks) 1- Go to Cataloging -> Stage records for import 2 - Upload a MARC file (koha.mrc) that contain items with homebranch and/or homelibraary set and is not present in your installation 3- Click on Stage for import 4- Click on View batch --> There is no message for the missing branches 5- Click on "Import this batch into the catalog" --> The importation failed 6- Apply the patch 7- Run prove -t t/db_dependent/ImportBatch.t 8- Click on "Manage imported batch" --> There is a warning message showing the missing branches in a link 9- Click on "Import this batch into the catalog" again --> The records are imported --> The items with wrong branches are ignored Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: PhilipOrr <philip.orr@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Philip Orr <philip.orr@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179838|0 |1 is obsolete| | --- Comment #45 from Philip Orr <philip.orr@lmscloud.de> --- Created attachment 180535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180535&action=edit Bug 21272: Unit test Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: PhilipOrr <philip.orr@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Philip Orr <philip.orr@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179839|0 |1 is obsolete| | --- Comment #46 from Philip Orr <philip.orr@lmscloud.de> --- Created attachment 180536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180536&action=edit Bug 21272: (follow-up) Terminology and formatting Change warning message to "..missing libraries...". Remove space before colon for the warning message. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: PhilipOrr <philip.orr@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Philip Orr <philip.orr@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179840|0 |1 is obsolete| | --- Comment #47 from Philip Orr <philip.orr@lmscloud.de> --- Created attachment 180537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180537&action=edit Bug 21272: (follow-up) using List::MoreUtils#any to get rid of %branches and fixing GetImportItemsBranches in ImportBatch.pm Signed-off-by: PhilipOrr <philip.orr@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Philip Orr <philip.orr@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179841|0 |1 is obsolete| | --- Comment #48 from Philip Orr <philip.orr@lmscloud.de> --- Created attachment 180538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180538&action=edit Bug 21272: Change warning message Signed-off-by: PhilipOrr <philip.orr@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Philip Orr <philip.orr@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179842|0 |1 is obsolete| | --- Comment #49 from Philip Orr <philip.orr@lmscloud.de> --- Created attachment 180539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180539&action=edit Bug 21272: Improve warning message To test Before make sure backgroundjobs process is running (/misc/workers/background_jobs_worker.pl --queue long_tasks) 1- Go to Cataloging -> Stage records for import 2 - Upload a MARC file (koha.mrc) that contain items with homebranch and/or homelibraary set and is not present in your installation 3- Click on Stage for import 4- Click on View batch --> There is no message for the missing branches 5- Click on "Import this batch into the catalog" --> The importation failed 6- Apply the patch 7- Run prove -t t/db_dependent/ImportBatch.t 8- Click on "Manage imported batch" --> There is a warning message showing the missing branches --> There is a warning message showing the titles of the wrong items 9- Click on "Import this batch into the catalog" again --> The records are imported --> The items with wrong branches are ignored Signed-off-by: PhilipOrr <philip.orr@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Philip Orr <philip.orr@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179843|0 |1 is obsolete| | --- Comment #50 from Philip Orr <philip.orr@lmscloud.de> --- Created attachment 180540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180540&action=edit Bug 21272: Unit test for methods GetBadBranchesImportItems and GetTitleImportRecord Signed-off-by: PhilipOrr <philip.orr@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Philip Orr <philip.orr@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179844|0 |1 is obsolete| | --- Comment #51 from Philip Orr <philip.orr@lmscloud.de> --- Created attachment 180541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180541&action=edit Bug 21272: (follow-up) tidy code Signed-off-by: PhilipOrr <philip.orr@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Philip Orr <philip.orr@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180383|0 |1 is obsolete| | --- Comment #52 from Philip Orr <philip.orr@lmscloud.de> --- Created attachment 180542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180542&action=edit Bug 21272: (follow-up) Fix unit test Signed-off-by: PhilipOrr <philip.orr@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Signed Off |Failed QA --- Comment #53 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Can you please check your patches for tidiness? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Koha collecto <koha@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha@collecto.ca -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 --- Comment #54 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 185334 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185334&action=edit (follow-up) Tidy manage-marc-import.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185334|0 |1 is obsolete| | --- Comment #55 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 185335 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185335&action=edit (follow-up) Tidy manage-marc-import.tt https://bugs.koha-community.org/show_bug.cgi?id=21272 Signed-off-by: Hammat Wele <hammat.wele@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185335|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180541|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180542|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 --- Comment #56 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 186389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186389&action=edit Bug 21272: (QA follow-up) Fix tidiness and unit test -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186389|0 |1 is obsolete| | --- Comment #57 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 186390 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186390&action=edit Bug 21272: (QA follow-up) Fix tidiness and unit test Signed-off-by: Hammat Wele <hammat.wele@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |lisette@bywatersolutions.co |y.org |m CC| |lisette@bywatersolutions.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #58 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- I might run into problems doing migrations because of this. I don't know if we're the only ones who do things this way, but sometimes we get bibliographic records as a MARC file, but the items come as a CSV file. So we create barebones bibliographic records with just either the 035$a or the 001 from the record and a 952 containing the item information (whatever can be used to match the records and items). I use the stage marc files tool to import the item records and ignore the records only to import the items. One of the patches here checks the incoming records' 245$a. But our barebones records don't have 245$a. Only some sort of control number (001 or 035$a usually) and a 952. (Like I said, maybe we're the only ones doing this, but the check on 245$a is new and changes the current behaviour.) I took an example from a migration I'm currently doing to recreate: 1. Import the record 1record_bz21272.mrc (either using the staff interface or bulkmarcimport.pl) 2. Create a record matching rule to check 001 2.1. Go to Administration > Record matching rules 2.2. Click "New record matching rule" 2.3. Fill out the form - Matching rule code: 001 - Description: Control number (001) - Match threshold: 1000 - Record type: Bibliographic records - Match point 1: - Search index: control-number - Score: 1000 - Matchpoint components: - Tag: 001 - Subfields: (leave empty) - Offset: (leave empty) - Length: (leave empty) - Normalization rule: None 2.3. Click "Save" 3. Import the item using the staff interface (I haven't found the correct combination of parameters to only import items using bulkmarcimport) 3.1. Go to Cataloging > Stage records for import 3.2. Choose the file 1item_bz21272.mrc 3.3. Click "Upload file" 3.4. Fill out the form - Profile: Do not use profile - Comments about this file: (fill out if needed) - Record type: Bibliographic - Character encoding: UTF-8 - Format: MARC - Record matching rule: 001 (Control number (001)) - Action if matching record found: Ignore incoming record (its items may still be processed) - Action if no match is found: Ignore incoming record - Check for embedded item record data? Yes - How to process items: Add item only if matching bib was found - Profile name: (leave empty) 3.4. Click "Stage for import" 3.5. Click "View batch" --> In the "Citation" column, there is no title because there is no title in the item record (normal) --> The item record should have matched the bibliographic record "Fundamentalisms and the state" 3.6. Click "Import this batch into the catalog" 3.7. Click "View detail of the enqueued job" 3.8. If needed, refresh the page until the job is marked as finished (mine is marked as failed, but the item was added... I'll file another bug for this) Without the patches, the item is processed and added. With the patches, I get an error at step 3.5. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 --- Comment #59 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 187929 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187929&action=edit Test record without an item Record for above test. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 --- Comment #60 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 187930 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187930&action=edit Empty record with a 952 Item record for above test. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 --- Comment #61 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 188234 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188234&action=edit Bug 21272: (follow-up) fix error 500 when there is no title To test: 1. Import the record 1record_bz21272.mrc 2. Create a record matching rule to check 001 2.1. Go to Administration > Record matching rules 2.2. Click "New record matching rule" 2.3. Fill out the form - Matching rule code: 001 - Description: Control number (001) - Match threshold: 1000 - Record type: Bibliographic records - Match point 1: - Search index: control-number - Score: 1000 - Matchpoint components: - Tag: 001 2.3. Click "Save" 3. Import the item using the staff interface 3.1. Go to Cataloging > Stage records for import 3.2. Choose the file 1item_bz21272.mrc 3.3. Click "Upload file" 3.4. Set these field - Record matching rule: 001 (Control number (001)) - Action if matching record found: Ignore incoming record (its items may still be processed) - Action if no match is found: Ignore incoming record 3.4. Click "Stage for import" 3.5. Click "View batch" ==> Error 500 4. Apply the path 5. Refresh the page or repeat step 3 ==> There is no Error -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Mathieu Saby <mathsabypro@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathsabypro@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Ayoub Glizi-Vicioso <ayoub.glizi-vicioso@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Ayoub Glizi-Vicioso <ayoub.glizi-vicioso@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180534|0 |1 is obsolete| | --- Comment #62 from Ayoub Glizi-Vicioso <ayoub.glizi-vicioso@inLibro.com> --- Created attachment 191441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191441&action=edit Bug 21272: MARC import should warn about mis-matched branch and item-type fields in 952 during staged import This plugin add a warning message to show missing branches during staged import, it also ignore item with wrong banches. To test Before make sure backgroundjobs process is running (/misc/workers/background_jobs_worker.pl --queue long_tasks) 1- Go to Cataloging -> Stage records for import 2 - Upload a MARC file (koha.mrc) that contain items with homebranch and/or homelibraary set and is not present in your installation 3- Click on Stage for import 4- Click on View batch --> There is no message for the missing branches 5- Click on "Import this batch into the catalog" --> The importation failed 6- Apply the patch 7- Run prove -t t/db_dependent/ImportBatch.t 8- Click on "Manage imported batch" --> There is a warning message showing the missing branches in a link 9- Click on "Import this batch into the catalog" again --> The records are imported --> The items with wrong branches are ignored MERGE CONFLICT RESOLVED. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Ayoub Glizi-Vicioso <ayoub.glizi-vicioso@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180535|0 |1 is obsolete| | --- Comment #63 from Ayoub Glizi-Vicioso <ayoub.glizi-vicioso@inLibro.com> --- Created attachment 191442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191442&action=edit Bug 21272: Unit test Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: PhilipOrr <philip.orr@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Ayoub Glizi-Vicioso <ayoub.glizi-vicioso@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180536|0 |1 is obsolete| | --- Comment #64 from Ayoub Glizi-Vicioso <ayoub.glizi-vicioso@inLibro.com> --- Created attachment 191443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191443&action=edit Bug 21272: (follow-up) Terminology and formatting Change warning message to "..missing libraries...". Remove space before colon for the warning message. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: PhilipOrr <philip.orr@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Ayoub Glizi-Vicioso <ayoub.glizi-vicioso@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180537|0 |1 is obsolete| | --- Comment #65 from Ayoub Glizi-Vicioso <ayoub.glizi-vicioso@inLibro.com> --- Created attachment 191444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191444&action=edit Bug 21272: (follow-up) using List::MoreUtils#any to get rid of %branches and fixing GetImportItemsBranches in ImportBatch.pm Signed-off-by: PhilipOrr <philip.orr@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Ayoub Glizi-Vicioso <ayoub.glizi-vicioso@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180538|0 |1 is obsolete| | --- Comment #66 from Ayoub Glizi-Vicioso <ayoub.glizi-vicioso@inLibro.com> --- Created attachment 191445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191445&action=edit Bug 21272: Change warning message Signed-off-by: PhilipOrr <philip.orr@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Ayoub Glizi-Vicioso <ayoub.glizi-vicioso@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180539|0 |1 is obsolete| | --- Comment #67 from Ayoub Glizi-Vicioso <ayoub.glizi-vicioso@inLibro.com> --- Created attachment 191446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191446&action=edit Bug 21272: Improve warning message To test Before make sure backgroundjobs process is running (/misc/workers/background_jobs_worker.pl --queue long_tasks) 1- Go to Cataloging -> Stage records for import 2 - Upload a MARC file (koha.mrc) that contain items with homebranch and/or homelibraary set and is not present in your installation 3- Click on Stage for import 4- Click on View batch --> There is no message for the missing branches 5- Click on "Import this batch into the catalog" --> The importation failed 6- Apply the patch 7- Run prove -t t/db_dependent/ImportBatch.t 8- Click on "Manage imported batch" --> There is a warning message showing the missing branches --> There is a warning message showing the titles of the wrong items 9- Click on "Import this batch into the catalog" again --> The records are imported --> The items with wrong branches are ignored Signed-off-by: PhilipOrr <philip.orr@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Ayoub Glizi-Vicioso <ayoub.glizi-vicioso@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180540|0 |1 is obsolete| | --- Comment #68 from Ayoub Glizi-Vicioso <ayoub.glizi-vicioso@inLibro.com> --- Created attachment 191447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191447&action=edit Bug 21272: Unit test for methods GetBadBranchesImportItems and GetTitleImportRecord Signed-off-by: PhilipOrr <philip.orr@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Ayoub Glizi-Vicioso <ayoub.glizi-vicioso@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186390|0 |1 is obsolete| | --- Comment #69 from Ayoub Glizi-Vicioso <ayoub.glizi-vicioso@inLibro.com> --- Created attachment 191448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191448&action=edit Bug 21272: (QA follow-up) Fix tidiness and unit test Signed-off-by: Hammat Wele <hammat.wele@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Ayoub Glizi-Vicioso <ayoub.glizi-vicioso@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188234|0 |1 is obsolete| | --- Comment #70 from Ayoub Glizi-Vicioso <ayoub.glizi-vicioso@inLibro.com> --- Created attachment 191449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191449&action=edit Bug 21272: (follow-up) fix error 500 when there is no title To test: 1. Import the record 1record_bz21272.mrc 2. Create a record matching rule to check 001 2.1. Go to Administration > Record matching rules 2.2. Click "New record matching rule" 2.3. Fill out the form - Matching rule code: 001 - Description: Control number (001) - Match threshold: 1000 - Record type: Bibliographic records - Match point 1: - Search index: control-number - Score: 1000 - Matchpoint components: - Tag: 001 2.3. Click "Save" 3. Import the item using the staff interface 3.1. Go to Cataloging > Stage records for import 3.2. Choose the file 1item_bz21272.mrc 3.3. Click "Upload file" 3.4. Set these field - Record matching rule: 001 (Control number (001)) - Action if matching record found: Ignore incoming record (its items may still be processed) - Action if no match is found: Ignore incoming record 3.4. Click "Stage for import" 3.5. Click "View batch" ==> Error 500 4. Apply the path 5. Refresh the page or repeat step 3 ==> There is no Error -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Ayoub Glizi-Vicioso <ayoub.glizi-vicioso@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ayoub.glizi-vicioso@inLibro | |.com Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Ayoub Glizi-Vicioso <ayoub.glizi-vicioso@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 --- Comment #71 from Esther Melander <esther.melander@bywatersolutions.com> --- Created attachment 204058 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204058&action=edit Error Trace I followed the test plan to step 5. I received an Error Trace when attempting to view the batch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191448|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191449|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 --- Comment #72 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 205075 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205075&action=edit Bug 21272: (QA follow-up) Fix tidiness and unit test Signed-off-by: Hammat Wele <hammat.wele@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 --- Comment #73 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 205076 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205076&action=edit Bug 21272: (follow-up) fix error 500 when there is no title To test: 1. Import the record 1record_bz21272.mrc 2. Create a record matching rule to check 001 2.1. Go to Administration > Record matching rules 2.2. Click "New record matching rule" 2.3. Fill out the form - Matching rule code: 001 - Description: Control number (001) - Match threshold: 1000 - Record type: Bibliographic records - Match point 1: - Search index: control-number - Score: 1000 - Matchpoint components: - Tag: 001 2.3. Click "Save" 3. Import the item using the staff interface 3.1. Go to Cataloging > Stage records for import 3.2. Choose the file 1item_bz21272.mrc 3.3. Click "Upload file" 3.4. Set these field - Record matching rule: 001 (Control number (001)) - Action if matching record found: Ignore incoming record (its items may still be processed) - Action if no match is found: Ignore incoming record 3.4. Click "Stage for import" 3.5. Click "View batch" ==> Error 500 4. Apply the path 5. Refresh the page or repeat step 3 ==> There is no Error -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |Main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #205076|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 --- Comment #74 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 205400 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205400&action=edit Bug 21272: (follow-up) fix error 500 when there is no title To test: 1. Import the record 1record_bz21272.mrc 2. Create a record matching rule to check 001 2.1. Go to Administration > Record matching rules 2.2. Click "New record matching rule" 2.3. Fill out the form - Matching rule code: 001 - Description: Control number (001) - Match threshold: 1000 - Record type: Bibliographic records - Match point 1: - Search index: control-number - Score: 1000 - Matchpoint components: - Tag: 001 2.3. Click "Save" 3. Import the item using the staff interface 3.1. Go to Cataloging > Stage records for import 3.2. Choose the file 1item_bz21272.mrc 3.3. Click "Upload file" 3.4. Set these field - Record matching rule: 001 (Control number (001)) - Action if matching record found: Ignore incoming record (its items may still be processed) - Action if no match is found: Ignore incoming record - How to process items: Add item only if matching bib was found 3.4. Click "Stage for import" 3.5. Click "View batch" ==> Error 500 4. Apply the path 5. Refresh the page or repeat step 3 ==> There is no Error -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 --- Comment #75 from Hammat wele <hammat.wele@inlibro.com> --- (In reply to Esther Melander from comment #71)
Created attachment 204058 [details] Error Trace
I followed the test plan to step 5. I received an Error Trace when attempting to view the batch.
Hi Esther, Thanks for testing! When testing with KTD, you need to restart `koha-plack` after applying the patch ($ koha-plack --restart kohadev). That’s why you encountered the error when trying to view the batch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21272 --- Comment #76 from Hammat wele <hammat.wele@inlibro.com> --- I've updated the test plan for the "fixing the 500 error when there is no title" patch by adding the missing "How to process items step". -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org