[Bug 17966] New: TT syntax for notices - Prove that ISSUESLIP is compatible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17966 Bug ID: 17966 Summary: TT syntax for notices - Prove that ISSUESLIP is compatible Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17966 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17965 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17965 [Bug 17965] TT syntax for notices - Prove that DUEDGST is compatible -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17966 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17971 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17971 [Bug 17971] TT syntax for notices - Add support for plurals -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17966 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17974, 17973 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17973 [Bug 17973] Add the Koha::Checkout->item method https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17974 [Bug 17974] Add the Koha::Item->biblio method -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17966 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17960 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17960 [Bug 17960] Rename opac_news.new with opac_news.content -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17966 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15283 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17966 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|17965 |17975 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17965 [Bug 17965] TT syntax for notices - Prove that DUEDGST is compatible https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17975 [Bug 17975] TT syntax for notices - Prove that HOLD_SLIP is compatible -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17966 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17966 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 59450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59450&action=edit Bug 17966: TT syntax for notices - Prove that ISSUESLIP is compatible Here we go, you will notice at the dependency list that this one is a bit different. In our former syntax we have 2 custom tags <checkedout> and <overdue>. These tags were allowed to permit loop on the checked out items and the overdue items. In this patch, we will use the "loops" parameter, introduced by bug 17971, to pass the list of checkouts and overdues to the template. Note that Kyle suggested another approach on bug 15283: all the checkouts were send into the same array and each element of this array calls the is_from_today method, to know if the checkout is an overdue. I don't think we should rely on the Koha API, that's why I suggest to pass 2 differents object list, 1 which contains the checkouts and another one with the overdues. Note that we do rely on the Koha API, we call the Koha::Checkout->item and Koha::Item->biblio to propose an equivalent TT notice. But I think we can accept that. Test plan: Define the ISSUESLIP and ISSUEQSLIP notice templates to generate the same notices you generated with the historical syntax. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17966 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17967 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17967 [Bug 17967] TT syntax for notices - Prove that ODUE is compatible -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17966 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- The patch will not applied cleanly but you can use a version with all conflicts fixed on https://github.com/joubu/Koha/tree/bug_17966 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17966 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17961 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17961 [Bug 17961] TT syntax for notices - Prove we have an equivalent for our historical custom syntax -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17966 Bug 17966 depends on bug 17960, which changed state. Bug 17960 Summary: Rename opac_news.new with opac_news.content https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17960 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17966 Bug 17966 depends on bug 17973, which changed state. Bug 17973 Summary: Add the Koha::Checkout->item method https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17973 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17966 Bug 17966 depends on bug 17974, which changed state. Bug 17974 Summary: Add the Koha::Item->biblio method https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17974 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17966 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17966 Bug 17966 depends on bug 17971, which changed state. Bug 17971 Summary: TT syntax for notices - Add support for plurals https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17971 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17966 Bug 17966 depends on bug 17974, which changed state. Bug 17974 Summary: Add the Koha::Item->biblio method https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17974 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17966 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- The remove branch has been rebased. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17966 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59450|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 63975 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63975&action=edit Bug 17966: TT syntax for notices - Prove that ISSUESLIP is compatible Here we go, you will notice at the dependency list that this one is a bit different. In our former syntax we have 2 custom tags <checkedout> and <overdue>. These tags were allowed to permit loop on the checked out items and the overdue items. In this patch, we will use the "loops" parameter, introduced by bug 17971, to pass the list of checkouts and overdues to the template. Note that Kyle suggested another approach on bug 15283: all the checkouts were send into the same array and each element of this array calls the is_from_today method, to know if the checkout is an overdue. I don't think we should rely on the Koha API, that's why I suggest to pass 2 differents object list, 1 which contains the checkouts and another one with the overdues. Note that we do rely on the Koha API, we call the Koha::Checkout->item and Koha::Item->biblio to propose an equivalent TT notice. But I think we can accept that. Test plan: Define the ISSUESLIP and ISSUEQSLIP notice templates to generate the same notices you generated with the historical syntax. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17966 Bug 17966 depends on bug 17975, which changed state. Bug 17975 Summary: TT syntax for notices - Prove that HOLD_SLIP is compatible https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17975 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17966 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18527 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17966 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63975|0 |1 is obsolete| | CC| |kyle@bywatersolutions.com --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 65683 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65683&action=edit Bug 17966: TT syntax for notices - Prove that ISSUESLIP is compatible -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17966 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17966 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17966 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65683|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 66773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66773&action=edit Bug 17966: TT syntax for notices - Prove that ISSUESLIP is compatible Here we go, you will notice at the dependency list that this one is a bit different. In our former syntax we have 2 custom tags <checkedout> and <overdue>. These tags were allowed to permit loop on the checked out items and the overdue items. In this patch, we will use the "loops" parameter, introduced by bug 17971, to pass the list of checkouts and overdues to the template. Note that Kyle suggested another approach on bug 15283: all the checkouts were send into the same array and each element of this array calls the is_from_today method, to know if the checkout is an overdue. I don't think we should rely on the Koha API, that's why I suggest to pass 2 differents object list, 1 which contains the checkouts and another one with the overdues. Note that we do rely on the Koha API, we call the Koha::Checkout->item and Koha::Item->biblio to propose an equivalent TT notice. But I think we can accept that. Test plan: Define the ISSUESLIP and ISSUEQSLIP notice templates to generate the same notices you generated with the historical syntax. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> https://bugs.koha-community.org/show_bug.cgi?id=17969 Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17966 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17966 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19277 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19277 [Bug 19277] TT syntax - Data is not ordered in notices -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17966 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED CC| |fridolin.somers@biblibre.co | |m --- Comment #8 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Enhancement not pushed to 17.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org