[Bug 33436] New: Use template wrapper for breadcrumbs: Reports part 1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33436 Bug ID: 33436 Summary: Use template wrapper for breadcrumbs: Reports part 1 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Depends on: 32507 To continue the process started by Bug 32507, this patch will update several reports templates so that they use the new template wrapper for breadcrumbs. - reports/acquisitions_stats.tt - reports/bor_issues_top.tt - reports/borrowers_out.tt - reports/borrowers_stats.tt - reports/cash_register_stats.tt Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32507 [Bug 32507] Use template wrapper to build breadcrumb navigation -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33436 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33436 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 149272 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149272&action=edit Bug 33436: Use template wrapper for breadcrumbs: Reports part 1 This patch updates several reports templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Reports -> - Acquisitions statistics - Results - Patrons with the most checkouts - Results - Patrons who haven't checked out - Results - Patron statistics wizard - Results -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33436 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33436 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149272|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 149294 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149294&action=edit Bug 33436: Use template wrapper for breadcrumbs: Reports part 1 This patch updates several reports templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Reports -> - Acquisitions statistics - Results - Patrons with the most checkouts - Results - Patrons who haven't checked out - Results - Patron statistics wizard - Results Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33436 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. I disabled SQL strict mode[1] to run these reports: - Patrons with the most checkouts - Patrons who haven't checked out [1] To disable SQL struct mode: 1. Edit /etc/koha/sites/kohadev/koha-conf.xml 2. Change <strict_sql_modes>0</strict_sql_modes> from 1 to 0 3. Restart everything: restart_all -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33436 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33436 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149294|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 149299 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149299&action=edit Bug 33436: Use template wrapper for breadcrumbs: Reports part 1 This patch updates several reports templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Reports -> - Acquisitions statistics - Results - Patrons with the most checkouts - Results - Patrons who haven't checked out - Results - Patron statistics wizard - Results Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33436 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33436 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33436 Jacob O'Mara <jacob.omara@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.05 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33436 --- Comment #6 from Jacob O'Mara <jacob.omara@ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33436 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |37030 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37030 [Bug 37030] Use template wrapper for breadcrumbs: Cash register stats -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org