[Bug 35036] New: Incorrect chopping to punctuation in 245$b
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35036 Bug ID: 35036 Summary: Incorrect chopping to punctuation in 245$b Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Bibliographic data support Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org To recreate: 1. Add a 245$b to a record that ends with punctuation. ie. 'E.B.' 2. Go the record detail page on both the staff interface and OPAC. 3. The last period does not display. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35036 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Incorrect chopping to |Incorrect chopping to |punctuation in 245$b |punctuation in 246 fields -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35036 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- I meant 246$b, not 245. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35036 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35036 --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 156881 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156881&action=edit Bug 35036: Do not remove punctuaction of 246 fields -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35036 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156881|0 |1 is obsolete| | --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 156882 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156882&action=edit Bug 35036: Do not remove punctuaction of 246 fields To test: 1. Add a 245$b to a record that ends with punctuation. ie. 'E.B.' 2. Go the record detail page on both the staff interface and OPAC. 3. The last period does not display. 4. APPLY patch and restart services 5. Look at the OPAC detail and staff interface detail pages again, the display should include punctuation -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35036 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35036 --- Comment #4 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 156883 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156883&action=edit Bug 35036: Remove extra puncuation from staff results page To test: 1. Look at the a results set on the staff interface that contains titles with a 246. 2. It now contains too much puncuation. 3. Apply patch 4. It now looks like the other pages. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35036 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35036 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35036 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156882|0 |1 is obsolete| | --- Comment #5 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 156986 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156986&action=edit Bug 35036: Do not remove punctuaction of 246 fields To test: 1. Add a 245$b to a record that ends with punctuation. ie. 'E.B.' 2. Go the record detail page on both the staff interface and OPAC. 3. The last period does not display. 4. APPLY patch and restart services 5. Look at the OPAC detail and staff interface detail pages again, the display should include punctuation Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35036 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156883|0 |1 is obsolete| | --- Comment #6 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 156987 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156987&action=edit Bug 35036: Remove extra puncuation from staff results page To test: 1. Look at the a results set on the staff interface that contains titles with a 246. 2. It now contains too much puncuation. 3. Apply patch 4. It now looks like the other pages. Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35036 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156987|0 |1 is obsolete| | --- Comment #7 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 156991 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156991&action=edit Bug 35036: Remove extra puncuation from staff results page To test: 1. Look at the a results set on the staff interface that contains titles with a 246. 2. It now contains too much puncuation. 3. Apply patch 4. It now looks like the other pages. Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Esther <esther@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35036 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- There are some issues with this this patch set: * If a library does the ending . at the end of fields, it will now keep showing. As we always always remove it, that will be inconsistent. The chop punctuation is thought to remove that ending dot, but the problem is that we cannot distinguish between an abbreviation dot and the field ending punctuation. This is not only a problem for 246, it's a general known issue. * Removing the common separator | on the staff results page doesn't give the expected result (missing space at least, but also no longer consistent) Other title: TitleA : RemainderA.TitleB : RamainderB. I think if we want to change this, we need to find a general solution and apply it to more than only the 246 field. I believe this needs more thought. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35036 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24833 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35036 --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- This is not only a problem for 246, it's a general known
issue.
Is there an open bug for the general issue? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35036 --- Comment #10 from Lucas Gass <lucas@bywatersolutions.com> ---
I think if we want to change this, we need to find a general solution and apply it to more than only the 246 field. I believe this needs more thought.
Can we at least make the logic behind the displaying of the 246 consistent for staff detail/results and OPAC detail/results? Right now we do something different in each of the 4 XSLT files. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35036 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Lucas Gass from comment #9)
This is not only a problem for 246, it's a general known
issue.
Is there an open bug for the general issue?
I already linked it: bug 24833 Sorry I that came across kind of harsh before - of course I think consistency would be good. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35036 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|lucas@bywatersolutions.com |koha-bugs@lists.koha-commun | |ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org