[Bug 30455] New: Incorrect template filter breaks holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30455 Bug ID: 30455 Summary: Incorrect template filter breaks holds Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: critical Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Depends on: 30063 An incorrect filter was added to patron-search.inc: let defer_loading = [% defer_loading | html ? 1 : 0 %]; Filters don't belong inside conditionals. This makes request.pl break with an error: Template process failed: file error - parse error - patron-search.inc line 252: unexpected token (?) [% defer_loading | html ? 1 : 0 %] at /kohadevbox/koha/C4/Templates.pm line 127 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 [Bug 30063] Make the main patron search use the /patrons REST API route -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30455 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Owen Leonard from comment #0)
This makes request.pl break with an error
...Or any other page which uses patron-search.inc. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30455 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30455 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 132957 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132957&action=edit Bug 30455: Incorrect template filter breaks holds This patch removes an incorrect template filter from inside a T:T conditional. This change should fix a non-functional request.pl and anywhere else patron-search.inc is used. The QA failure for a missing filter is a false positive. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30455 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Trivial patch |--- Status|Needs Signoff |RESOLVED Resolution|--- |INVALID --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Will be patched on 30063 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30455 Bug 30455 depends on bug 30063, which changed state. Bug 30063 Summary: Make the main patron search use the /patrons REST API route https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org