[Bug 17228] New: Make two versions of SIPconfig.xml identical
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17228 Bug ID: 17228 Summary: Make two versions of SIPconfig.xml identical Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Packaging Assignee: magnus@libriotech.no Reporter: magnus@libriotech.no QA Contact: testopia@bugs.koha-community.org CC: mirko@abunchofthings.net We have two versions of SIPconfig.xml: etc/SIPconfig.xml debian/templates/SIPconfig.xml The former has been updated with some changes to the possible configuration of SIP2 servers, e.g. by bug 15006. The latter has not been updated with the same information. Since debian/templates/SIPconfig.xml contains no special placeholders or variables, this bug proposes to simply copy etc/SIPconfig.xml to debian/templates/SIPconfig.xml, so that admins using the packages will see an up-to-date SIP2 config example when they have enabled SIP2 for a site. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17228 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17228 --- Comment #1 from Magnus Enger <magnus@libriotech.no> --- Created attachment 55051 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55051&action=edit Bug 17228 - Make two versions of SIPconfig.xml identical Several bugs have made changes to etc/SIPconfig.xml but not updated debian/templates/SIPconfig.xml. This means that an admin using the Debian packages who enables SIP2 for a site and looks at /etc/koha/sites/<instance>/SIPconfig.xml will not see an up-to-date version of that file, with the risk of missing possible config opportunities. Since debian/templates/SIPconfig.xml contains no placeholders or other magic stuff related to the Debian packaging, this patch simply copies etc/SIPconfig.xml to debian/templates/SIPconfig.xml To test: $ diff etc/SIPconfig.xml debian/templates/SIPconfig.xml There should be no difference between the files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17228 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55051|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17228 --- Comment #2 from Magnus Enger <magnus@libriotech.no> --- Created attachment 55052 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55052&action=edit Bug 17228 - Make two versions of SIPconfig.xml identical Several bugs have made changes to etc/SIPconfig.xml but not updated debian/templates/SIPconfig.xml. This means that an admin using the Debian packages who enables SIP2 for a site and looks at /etc/koha/sites/<instance>/SIPconfig.xml will not see an up-to-date version of that file, with the risk of missing possible config opportunities. Since debian/templates/SIPconfig.xml contains no placeholders or other magic stuff related to the Debian packaging, this patch simply copies etc/SIPconfig.xml to debian/templates/SIPconfig.xml To test: $ diff etc/SIPconfig.xml debian/templates/SIPconfig.xml There should be no difference between the files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17228 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55052|0 |1 is obsolete| | --- Comment #3 from Magnus Enger <magnus@libriotech.no> --- Created attachment 55053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55053&action=edit Bug 17228 - Fix whitespace in etc/SIPconfig.xml Remove trailing whitespace and replace tabs with 4 spaces. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17228 --- Comment #4 from Magnus Enger <magnus@libriotech.no> --- Created attachment 55054 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55054&action=edit Bug 17228 - Make two versions of SIPconfig.xml identical Several bugs have made changes to etc/SIPconfig.xml but not updated debian/templates/SIPconfig.xml. This means that an admin using the Debian packages who enables SIP2 for a site and looks at /etc/koha/sites/<instance>/SIPconfig.xml will not see an up-to-date version of that file, with the risk of missing possible config opportunities. Since debian/templates/SIPconfig.xml contains no placeholders or other magic stuff related to the Debian packaging, this patch simply copies etc/SIPconfig.xml to debian/templates/SIPconfig.xml To test: $ diff etc/SIPconfig.xml debian/templates/SIPconfig.xml There should be no difference between the files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17228 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17228 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55054|0 |1 is obsolete| | --- Comment #5 from Claire Gravely <claire_gravely@hotmail.com> --- Created attachment 55090 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55090&action=edit Bug 17228 - Make two versions of SIPconfig.xml identical Several bugs have made changes to etc/SIPconfig.xml but not updated debian/templates/SIPconfig.xml. This means that an admin using the Debian packages who enables SIP2 for a site and looks at /etc/koha/sites/<instance>/SIPconfig.xml will not see an up-to-date version of that file, with the risk of missing possible config opportunities. Since debian/templates/SIPconfig.xml contains no placeholders or other magic stuff related to the Debian packaging, this patch simply copies etc/SIPconfig.xml to debian/templates/SIPconfig.xml To test: $ diff etc/SIPconfig.xml debian/templates/SIPconfig.xml There should be no difference between the files Signed-off-by: Claire Gravely <claire_gravely@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17228 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17228 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55053|0 |1 is obsolete| | --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 55106 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55106&action=edit Bug 17228 - Fix whitespace in etc/SIPconfig.xml Remove trailing whitespace and replace tabs with 4 spaces. Signed-off-by: Claire Gravely <claire_gravely@hotmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17228 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55090|0 |1 is obsolete| | --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 55107 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55107&action=edit Bug 17228 - Make two versions of SIPconfig.xml identical Several bugs have made changes to etc/SIPconfig.xml but not updated debian/templates/SIPconfig.xml. This means that an admin using the Debian packages who enables SIP2 for a site and looks at /etc/koha/sites/<instance>/SIPconfig.xml will not see an up-to-date version of that file, with the risk of missing possible config opportunities. Since debian/templates/SIPconfig.xml contains no placeholders or other magic stuff related to the Debian packaging, this patch simply copies etc/SIPconfig.xml to debian/templates/SIPconfig.xml To test: diff etc/SIPconfig.xml debian/templates/SIPconfig.xml There should be no difference between the files Signed-off-by: Claire Gravely <claire_gravely@hotmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17228 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17228 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11, thanks Magnus! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17228 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17228 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |frederic@tamil.fr --- Comment #9 from Frédéric Demians <frederic@tamil.fr> --- Pushed in 16.05. Will be in 16.05.04. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17228 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #10 from Julian Maurice <julian.maurice@biblibre.com> --- Pushed to 3.22.x, will be in 3.22.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17228 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55107|0 |1 is obsolete| | --- Comment #11 from David Gustafsson <glasklas@gmail.com> --- Created attachment 157677 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157677&action=edit Bug 17228 - Make two versions of SIPconfig.xml identical Several bugs have made changes to etc/SIPconfig.xml but not updated debian/templates/SIPconfig.xml. This means that an admin using the Debian packages who enables SIP2 for a site and looks at /etc/koha/sites/<instance>/SIPconfig.xml will not see an up-to-date version of that file, with the risk of missing possible config opportunities. Since debian/templates/SIPconfig.xml contains no placeholders or other magic stuff related to the Debian packaging, this patch simply copies etc/SIPconfig.xml to debian/templates/SIPconfig.xml To test: diff etc/SIPconfig.xml debian/templates/SIPconfig.xml There should be no difference between the files Signed-off-by: Claire Gravely <claire_gravely@hotmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> (cherry picked from commit d0d8bd18225483c3c28ba9e0bd368301c6835a66) Signed-off-by: Frédéric Demians <f.demians@tamil.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17228 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |glasklas@gmail.com --- Comment #12 from David Gustafsson <glasklas@gmail.com> --- Please ignore, I messed up and attached to this bug by mistake. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org