[Bug 17308] New: 'New patron attribute type' button does not work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17308 Bug ID: 17308 Summary: 'New patron attribute type' button does not work Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: arouss1980@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Description of the problem: In the Staff client, the 'New patron attribute type' button in the Patron attribute types page does not work. Steps to reproduce (in the current master 0254fd7): Go to Home > Administration > Patron attribute types, and click on the 'New patron attribute type' button. You cannot create a new patron attribute type and you get the following Software error in the browser: Not a HASH reference at /home/aroussos/kohaclone/admin/patron-attr-types.pl line 89. I've found a way to fix this and will submit a patch soon. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17308 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17308 Andreas Roussos <arouss1980@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |arouss1980@gmail.com |ity.org | URL| |/cgi-bin/koha/admin/patron- | |attr-types.pl Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17308 --- Comment #1 from Andreas Roussos <arouss1980@gmail.com> --- Created attachment 55627 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55627&action=edit Bug 17308 - 'New patron attribute type' button does not work In the Staff client, the 'New patron attribute type' button in the Patron attribute types page does not work. This patch fixes that. Test plan: 1) In the Staff client, go to Home > Administration > Patron attribute types, and click on the 'New patron attribute type' button. You cannot create a new patron attribute type and you get the following Software error: Not a HASH reference at [...] 2) Apply the patch. 3) Repeat step 1). The 'New patron attribute type' button now works. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17308 Andreas Roussos <arouss1980@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17308 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55627|0 |1 is obsolete| | --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 55628 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55628&action=edit Bug 17308 - 'New patron attribute type' button does not work In the Staff client, the 'New patron attribute type' button in the Patron attribute types page does not work. This patch fixes that. Test plan: 1) In the Staff client, go to Home > Administration > Patron attribute types, and click on the 'New patron attribute type' button. You cannot create a new patron attribute type and you get the following Software error: Not a HASH reference at [...] 2) Apply the patch. 3) Repeat step 1). The 'New patron attribute type' button now works. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17308 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17308 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55628|0 |1 is obsolete| | --- Comment #3 from Marc Véron <veron@veron.ch> --- Created attachment 55629 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55629&action=edit Bug 17308 - 'New patron attribute type' button does not work In the Staff client, the 'New patron attribute type' button in the Patron attribute types page does not work. This patch fixes that. Test plan: 1) In the Staff client, go to Home > Administration > Patron attribute types, and click on the 'New patron attribute type' button. You cannot create a new patron attribute type and you get the following Software error: Not a HASH reference at [...] 2) Apply the patch. 3) Repeat step 1). The 'New patron attribute type' button now works. Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17308 --- Comment #4 from Marc Véron <veron@veron.ch> --- Sorry, forgot sign-off line with previous patch... (Comment #2) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17308 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17308 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17308 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55629|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 55643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55643&action=edit [PASSED QA] Bug 17308 - 'New patron attribute type' button does not work In the Staff client, the 'New patron attribute type' button in the Patron attribute types page does not work. This patch fixes that. Test plan: 1) In the Staff client, go to Home > Administration > Patron attribute types, and click on the 'New patron attribute type' button. You cannot create a new patron attribute type and you get the following Software error: Not a HASH reference at [...] 2) Apply the patch. 3) Repeat step 1). The 'New patron attribute type' button now works. Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17308 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11, thanks Andreas! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org