[Bug 40431] New: Subject should be mandatory when using the free form to send an email to a patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40431 Bug ID: 40431 Summary: Subject should be mandatory when using the free form to send an email to a patron Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: michaela.sieber@kit.edu QA Contact: testopia@bugs.koha-community.org With Bug 29393 the ability to send emails from patron details page was introduced. This is a great feature, but the subject should be a mandatory field. to reproduce: - go to a patron's details page - click on "Add message" in tools bar - choose "Email" in "Add a message for" - fill the body / message manually but leave the subject emty - Save - Check the message in the patrons notices cgi-bin/koha/members/notices.pl?borrowernumber=xxxxx -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40431 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29393 Depends on| |29393 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29393 [Bug 29393] Ability to send emails from patron details page -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40431 Eric Garcia <cubingguy714@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40431 --- Comment #1 from Eric Garcia <cubingguy714@gmail.com> --- Created attachment 184446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184446&action=edit Bug 40431: Make subject required for emails in Add message modal Test Plan: 1. Apply patch 2. Go to patron's detail page 3. Click "Add message" in tools bar 4. Fill the body, but leave the subject empty 5. Notice it requires you to fill out subject before saving -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40431 Eric Garcia <cubingguy714@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cubingguy714@gmail.com Assignee|koha-bugs@lists.koha-commun |cubingguy714@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40431 --- Comment #2 from David Flater <flaterdavid@gmail.com> --- Created attachment 184450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184450&action=edit Bug 40431: Make subject required for emails in Add message modal Test Plan: 1. Apply patch 2. Go to patron's detail page 3. Click "Add message" in tools bar 4. Fill the body, but leave the subject empty 5. Notice it requires you to fill out subject before saving Signed-off-by: David Flater <flaterdavid@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40431 David Flater <flaterdavid@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |flaterdavid@gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40431 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Attachment #184446|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40431 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Please explain: <li class="form-group form-row" id="subject_form" style="display: none;"> <label for="borrower_subject" class="col-form-label">Subject:</label> - <input type="text" size="60" name="borrower_subject" class="form-control" id="borrower_subject" /> + <input type="text" size="60" name="borrower_subject" class="form-control" id="borrower_subject" required="required" /> The field is not displayed but required ? Changing status for need of feedback. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40431 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40431 Katie Bliss <kebliss@dmpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss@dmpl.org -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org