[Bug 16860] New: Catch warning t/db_dependent/ClassSource.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16860 Bug ID: 16860 Summary: Catch warning t/db_dependent/ClassSource.t Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Test Suite Assignee: mtompset@hotmail.com Reporter: mtompset@hotmail.com QA Contact: gmcharlt@gmail.com $ prove t/db_dependent/ClassSource.t t/db_dependent/ClassSource.t .. 3/24 attempting to use non-existent class sorting routine routine1 t/db_dependent/ClassSource.t .. ok All tests successful. Files=1, Tests=24, 1 wallclock secs ( 0.02 usr 0.00 sys + 0.66 cusr 0.02 csys = 0.70 CPU) Result: PASS The above warning might be scary to those unfamiliar with the test. Add a test to catch the warning. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16860 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16860 --- Comment #1 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 53141 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53141&action=edit Bug 16860: Catch warning t/db_dependent/ClassSource.t $ prove t/db_dependent/ClassSource.t t/db_dependent/ClassSource.t .. 3/24 attempting to use non-existent class sorting routine routine1 t/db_dependent/ClassSource.t .. ok All tests successful. Files=1, Tests=24, 1 wallclock secs ( 0.02 usr 0.00 sys + 0.66 cusr 0.02 csys = 0.70 CPU) Result: PASS The above warning might be scary to those unfamiliar with the test. Add a test to catch the warning. TEST PLAN --------- 1) prove t/db_dependent/ClassSource.t -- as above 2) apply patch 3) prove t/db_dependent/ClassSource.t -- no message 4) prove -v t/db_dependent/ClassSource.t -- test 13 is the new test 5) run koha qa test tools -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16860 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53141|0 |1 is obsolete| | --- Comment #2 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 53167 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53167&action=edit [SIGNED-OFF]Bug 16860: Catch warning t/db_dependent/ClassSource.t $ prove t/db_dependent/ClassSource.t t/db_dependent/ClassSource.t .. 3/24 attempting to use non-existent class sorting routine routine1 t/db_dependent/ClassSource.t .. ok All tests successful. Files=1, Tests=24, 1 wallclock secs ( 0.02 usr 0.00 sys + 0.66 cusr 0.02 csys = 0.70 CPU) Result: PASS The above warning might be scary to those unfamiliar with the test. Add a test to catch the warning. TEST PLAN --------- 1) prove t/db_dependent/ClassSource.t -- as above 2) apply patch 3) prove t/db_dependent/ClassSource.t -- no message 4) prove -v t/db_dependent/ClassSource.t -- test 13 is the new test 5) run koha qa test tools Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Workas as advertised -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16860 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx@gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16860 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16860 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53167|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 53186 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53186&action=edit Bug 16860: Catch warning t/db_dependent/ClassSource.t $ prove t/db_dependent/ClassSource.t t/db_dependent/ClassSource.t .. 3/24 attempting to use non-existent class sorting routine routine1 t/db_dependent/ClassSource.t .. ok All tests successful. Files=1, Tests=24, 1 wallclock secs ( 0.02 usr 0.00 sys + 0.66 cusr 0.02 csys = 0.70 CPU) Result: PASS The above warning might be scary to those unfamiliar with the test. Add a test to catch the warning. TEST PLAN --------- 1) prove t/db_dependent/ClassSource.t -- as above 2) apply patch 3) prove t/db_dependent/ClassSource.t -- no message 4) prove -v t/db_dependent/ClassSource.t -- test 13 is the new test 5) run koha qa test tools Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Workas as advertised Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16860 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 53187 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53187&action=edit Bug 16860: Remove the comment about the warning It is no longer necessary. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16860 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11, thanks Mark, Jonathan! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16860 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |frederic@tamil.fr --- Comment #6 from Frédéric Demians <frederic@tamil.fr> --- Pushed in 16.05. Will be in 16.05.02. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16860 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #7 from Julian Maurice <julian.maurice@biblibre.com> --- Patches pushed to 3.22.x, will be in 3.22.10 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org