[Bug 36237] New: Improve set-library UI after 34478
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36237 Bug ID: 36237 Summary: Improve set-library UI after 34478 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Bug 34478 added a new step when setting a library, desk, or register. I could use a few UI improvements. To recreate: 1. Enable UseCirculationDesks, make some desks via UseCashRegisters > Circulation desks 2. Enable UseCashRegisters, make some registers via UseCashRegisters > Registers 3. Go to set library page. Try changing the branch, desk, or register. 4. See that UI could use some improvements. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36237 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36237 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 162793 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162793&action=edit Bug 36237: UI improvments for set-library page To test: 1. Enable UseCirculationDesks, make some desks via UseCashRegisters > Circulation desks 2. Enable UseCashRegisters, make some registers via UseCashRegisters > Registers 3. Go to set library page. Try changing the branch, desk, or register. 4. See that UI could use some improvements. 5. APPLY patch 6. Try 3 again, making sure everything works right. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36237 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |34478 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34478 [Bug 34478] Full CSRF protection -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36237 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36237 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36237 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162793|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 163013 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163013&action=edit Bug 36237: UI improvments for set-library page To test: 1. Enable UseCirculationDesks, make some desks via UseCashRegisters > Circulation desks 2. Enable UseCashRegisters, make some registers via UseCashRegisters > Registers 3. Go to set library page. Try changing the branch, desk, or register. 4. See that UI could use some improvements. 5. APPLY patch 6. Try 3 again, making sure everything works right. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36237 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This improves the user release notes| |interface when setting or | |editing the library, desk, | |and cash register | |(Circulation > Set library | |and desk): | |- Adds white | |background for the update | |successful page | |- Improves | |the messages about the | |updates made CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36237 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=36480 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36237 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=36481 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36237 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36481 See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=36481 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36481 [Bug 36481] Add GET /libraries/:library_id/cash_registers -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36237 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|36481 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36481 [Bug 36481] Add GET /libraries/:library_id/cash_registers -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36237 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- What is the reason for the new step? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36237 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com --- Comment #4 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Owen Leonard from comment #3)
What is the reason for the new step?
It is related to Bug 34478 and CSRF protection, I believe. Im CC'ing Jonathan here as he will have a much better answer to that question. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36237 --- Comment #5 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Lucas Gass from comment #4)
(In reply to Owen Leonard from comment #3)
What is the reason for the new step?
It is related to Bug 34478 and CSRF protection, I believe. Im CC'ing Jonathan here as he will have a much better answer to that question.
I don't remember to be honest. If there is a behaviour change it's coming from It's coming from Bug 34478: Fix circ/set-library Where I asked "Why do not we simply redirect instead of POSTing?". There can be a problem if you are redirecting with op starting with cud-, but otoh it can be a problem if you POST op not starting with cud-! I would open a separate bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36237 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- In my test it's working to change library but not working to change desk and register. Maybe I rebased wrong? Could someone else take a look? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36237 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #7 from David Nind <david@davidnind.com> --- Went to retest for Owen, but patch no longer applies: git bz apply 36237 Bug 36237 - Improve set-library UI after 34478 163013 - Bug 36237: UI improvments for set-library page Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 36237: UI improvments for set-library page Using index info to reconstruct a base tree... M circ/set-library.pl Falling back to patching base and 3-way merge... Auto-merging circ/set-library.pl CONFLICT (content): Merge conflict in circ/set-library.pl error: Failed to merge in the changes. Patch failed at 0001 Bug 36237: UI improvments for set-library page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36237 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |RESOLVED Resolution|--- |INVALID --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Owen Leonard from comment #3)
What is the reason for the new step?
Some changes in 34478 brought some much older code back to life. It seems like the 'Updated' step was always there but we were never hitting the condition. To preserve existing behavior and clean up the set library page I filed Bug 36572. I think this one can now be set to RESOLVED - INVALID -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36237 Bug 36237 depends on bug 34478, which changed state. Bug 34478 Summary: Full CSRF protection https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34478 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org