[Bug 29015] New: Add option to limit Holds Queue report by shelving location / collection
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29015 Bug ID: 29015 Summary: Add option to limit Holds Queue report by shelving location / collection Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com In large consortia it can take a long time to load the whole holds queue - additionally staff may only work on a section at a time. We should add options for limiting to a specific location/collection -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29015 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29015 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 124871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124871&action=edit Bug 29015: Add options for itemtpye, collection, and shelving location to view_holdsqueue.pl This patch makes the code for itemtypeslimit work, and adds options for shelving location and collection code This also remove the 'post' method from the form to allow easy bookmarking To test: 1 - Add holds to your system 2 - Run the holds queue builder 3 - Browse to Circulation->Holds queue 4 - Note the library dropdown 5 - Apply patch 6 - Reload and note new options 7 - Test that both limits and 'All' options work as expected 8 - Note that description at top includes options when selected "### items found for All libraries and item type:(Books)" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29015 --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 124881 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124881&action=edit Bug 29015: Unit tests -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29015 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 124883 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124883&action=edit Bug 29015: (follow-up) Show sidebar filter form with results This patch adds the new filter form in the sidebar when showing results. To do so the form markup is moved into a BLOCK so that it can be reused. This patch also adds pre-selection of submitted options on the filter form so that it reflects the user's choices. To test, apply the patch and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - Go to Circulation -> Holds queue. - Submit the form with one or more filters selected. - On the results page the queue should be correctly filtered and the sidebar should show your search fields preselected. - Test with the CircSidebar preference enabled and disabled. The circulation menu should appear correctly, with the filter form only displaying in the sidebar after submitting the form. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29015 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- I think the original patches work well, and I hope my follow-up makes it even better. I do have one request because I think as it is this patch changes a behavior that libraries depend on: The form when it is initially displayed should pre-select the logged-in user's home library. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29015 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29015 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29015 --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 124903 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124903&action=edit Bug 29015: (follow-up) Default to logged in branch unless viewing queue -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29015 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29015 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124871|0 |1 is obsolete| | Attachment #124881|0 |1 is obsolete| | Attachment #124883|0 |1 is obsolete| | Attachment #124903|0 |1 is obsolete| | --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 124907 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124907&action=edit Bug 29015: Add options for itemtpye, collection, and shelving location to view_holdsqueue.pl This patch makes the code for itemtypeslimit work, and adds options for shelving location and collection code This also remove the 'post' method from the form to allow easy bookmarking To test: 1 - Add holds to your system 2 - Run the holds queue builder 3 - Browse to Circulation->Holds queue 4 - Note the library dropdown 5 - Apply patch 6 - Reload and note new options 7 - Test that both limits and 'All' options work as expected 8 - Note that description at top includes options when selected "### items found for All libraries and item type:(Books)" Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29015 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 124908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124908&action=edit Bug 29015: Unit tests Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29015 --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 124909 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124909&action=edit Bug 29015: (follow-up) Show sidebar filter form with results This patch adds the new filter form in the sidebar when showing results. To do so the form markup is moved into a BLOCK so that it can be reused. This patch also adds pre-selection of submitted options on the filter form so that it reflects the user's choices. To test, apply the patch and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - Go to Circulation -> Holds queue. - Submit the form with one or more filters selected. - On the results page the queue should be correctly filtered and the sidebar should show your search fields preselected. - Test with the CircSidebar preference enabled and disabled. The circulation menu should appear correctly, with the filter form only displaying in the sidebar after submitting the form. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29015 --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 124910 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124910&action=edit Bug 29015: (follow-up) Default to logged in branch unless viewing queue Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29015 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29015 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124907|0 |1 is obsolete| | Attachment #124908|0 |1 is obsolete| | Attachment #124909|0 |1 is obsolete| | Attachment #124910|0 |1 is obsolete| | --- Comment #10 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 124915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124915&action=edit Bug 29015: Add options for itemtpye, collection, and shelving location to view_holdsqueue.pl This patch makes the code for itemtypeslimit work, and adds options for shelving location and collection code This also remove the 'post' method from the form to allow easy bookmarking To test: 1 - Add holds to your system 2 - Run the holds queue builder 3 - Browse to Circulation->Holds queue 4 - Note the library dropdown 5 - Apply patch 6 - Reload and note new options 7 - Test that both limits and 'All' options work as expected 8 - Note that description at top includes options when selected "### items found for All libraries and item type:(Books)" Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29015 --- Comment #11 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 124916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124916&action=edit Bug 29015: Unit tests Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29015 --- Comment #12 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 124917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124917&action=edit Bug 29015: (follow-up) Show sidebar filter form with results This patch adds the new filter form in the sidebar when showing results. To do so the form markup is moved into a BLOCK so that it can be reused. This patch also adds pre-selection of submitted options on the filter form so that it reflects the user's choices. To test, apply the patch and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - Go to Circulation -> Holds queue. - Submit the form with one or more filters selected. - On the results page the queue should be correctly filtered and the sidebar should show your search fields preselected. - Test with the CircSidebar preference enabled and disabled. The circulation menu should appear correctly, with the filter form only displaying in the sidebar after submitting the form. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29015 --- Comment #13 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 124918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124918&action=edit Bug 29015: (follow-up) Default to logged in branch unless viewing queue Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29015 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28966 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28966 [Bug 28966] Holds queue viewer too slow to load for large numbers of holds -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29015 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124915|0 |1 is obsolete| | Attachment #124916|0 |1 is obsolete| | Attachment #124917|0 |1 is obsolete| | Attachment #124918|0 |1 is obsolete| | --- Comment #14 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 125419 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125419&action=edit Bug 29015: Add options for itemtpye, collection, and shelving location to view_holdsqueue.pl This patch makes the code for itemtypeslimit work, and adds options for shelving location and collection code This also remove the 'post' method from the form to allow easy bookmarking To test: 1 - Add holds to your system 2 - Run the holds queue builder 3 - Browse to Circulation->Holds queue 4 - Note the library dropdown 5 - Apply patch 6 - Reload and note new options 7 - Test that both limits and 'All' options work as expected 8 - Note that description at top includes options when selected "### items found for All libraries and item type:(Books)" Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29015 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125419|0 |1 is obsolete| | --- Comment #15 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 125420 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125420&action=edit Bug 29015: Add options for itemtype, collection, and shelving location to view_holdsqueue.pl This patch makes the code for itemtypeslimit work, and adds options for shelving location and collection code This also remove the 'post' method from the form to allow easy bookmarking To test: 1 - Add holds to your system 2 - Run the holds queue builder 3 - Browse to Circulation->Holds queue 4 - Note the library dropdown 5 - Apply patch 6 - Reload and note new options 7 - Test that both limits and 'All' options work as expected 8 - Note that description at top includes options when selected "### items found for All libraries and item type:(Books)" Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29015 --- Comment #16 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 125421 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125421&action=edit Bug 29015: Unit tests Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29015 --- Comment #17 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 125422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125422&action=edit Bug 29015: (follow-up) Show sidebar filter form with results This patch adds the new filter form in the sidebar when showing results. To do so the form markup is moved into a BLOCK so that it can be reused. This patch also adds pre-selection of submitted options on the filter form so that it reflects the user's choices. To test, apply the patch and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - Go to Circulation -> Holds queue. - Submit the form with one or more filters selected. - On the results page the queue should be correctly filtered and the sidebar should show your search fields preselected. - Test with the CircSidebar preference enabled and disabled. The circulation menu should appear correctly, with the filter form only displaying in the sidebar after submitting the form. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29015 --- Comment #18 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 125423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125423&action=edit Bug 29015: (follow-up) Default to logged in branch unless viewing queue Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29015 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The tests are failing for me, can you please check? kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ prove t/db_dependent/HoldsQueue.t t/db_dependent/HoldsQueue.t .. 56/58 Use of uninitialized value in hash element at /home/vagrant/kohaclone/C4/HoldsQueue.pm line 466. # No tests run! # Failed test 'No tests run for subtest "Remove holds on check-in match"' # at t/db_dependent/HoldsQueue.t line 1739. Can't call method "branchcode" on an undefined value at /home/vagrant/kohaclone/Koha/Item.pm line 664. # Looks like your test exited with 255 just after 57. t/db_dependent/HoldsQueue.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 2/58 subtests Test Summary Report ------------------- t/db_dependent/HoldsQueue.t (Wstat: 65280 Tests: 57 Failed: 1) Failed test: 57 Non-zero exit status: 255 Parse errors: Bad plan. You planned 58 tests but ran 57. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29015 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #20 from Nick Clemens <nick@bywatersolutions.com> --- I don't recreate failure, it looks like you have a hold with no pickup location on your system -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29015 --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Testing this again and all seems to work as advertised, but there are some things that keep irritating me (unrelated to this patch, so not blocker): * If I have a record level hold and I have 2 items for the record, that are identical apart from collection, how is the collection that shows on holds queue chosen? Only one shows and I can only filter on the one that shows... * We can limit on library, so then I know which library I am looking at. But... when I choose "All", there seems to be no clue in the table about the library that owns the item and is supposed to provide it? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29015 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29015 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125422|0 |1 is obsolete| | --- Comment #22 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 127191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127191&action=edit Bug 29015: (follow-up) Show sidebar filter form with results This patch adds the new filter form in the sidebar when showing results. To do so the form markup is moved into a BLOCK so that it can be reused. This patch also adds pre-selection of submitted options on the filter form so that it reflects the user's choices. To test, apply the patch and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - Go to Circulation -> Holds queue. - Submit the form with one or more filters selected. - On the results page the queue should be correctly filtered and the sidebar should show your search fields preselected. - Test with the CircSidebar preference enabled and disabled. The circulation menu should appear correctly, with the filter form only displaying in the sidebar after submitting the form. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29015 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125423|0 |1 is obsolete| | --- Comment #23 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 127192 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127192&action=edit Bug 29015: (follow-up) Default to logged in branch unless viewing queue Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29015 --- Comment #24 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 127193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127193&action=edit Bug 29015: (QA follow-up) Change collection code to be just collection We did some clean-up in that area a little while ago, agreeing that as we acutally display the descriptions, the label should be just "collection". This patch also removes some (): Before: 4 items found for Centerville and item type:(Books) and collection: (Reference) and shelving location: (General Stacks) Now: 4 items found for Centerville and item type: Books and collection: Reference and shelving location: General Stacks Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29015 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125420|0 |1 is obsolete| | --- Comment #25 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 127194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127194&action=edit Bug 29015: Add options for itemtype, collection, and shelving location to view_holdsqueue.pl This patch makes the code for itemtypeslimit work, and adds options for shelving location and collection code This also remove the 'post' method from the form to allow easy bookmarking To test: 1 - Add holds to your system 2 - Run the holds queue builder 3 - Browse to Circulation->Holds queue 4 - Note the library dropdown 5 - Apply patch 6 - Reload and note new options 7 - Test that both limits and 'All' options work as expected 8 - Note that description at top includes options when selected "### items found for All libraries and item type:(Books)" Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29015 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125421|0 |1 is obsolete| | --- Comment #26 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 127195 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127195&action=edit Bug 29015: Unit tests Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29015 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127191|0 |1 is obsolete| | --- Comment #27 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 127196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127196&action=edit Bug 29015: (follow-up) Show sidebar filter form with results This patch adds the new filter form in the sidebar when showing results. To do so the form markup is moved into a BLOCK so that it can be reused. This patch also adds pre-selection of submitted options on the filter form so that it reflects the user's choices. To test, apply the patch and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - Go to Circulation -> Holds queue. - Submit the form with one or more filters selected. - On the results page the queue should be correctly filtered and the sidebar should show your search fields preselected. - Test with the CircSidebar preference enabled and disabled. The circulation menu should appear correctly, with the filter form only displaying in the sidebar after submitting the form. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29015 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127192|0 |1 is obsolete| | --- Comment #28 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 127197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127197&action=edit Bug 29015: (follow-up) Default to logged in branch unless viewing queue Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29015 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127193|0 |1 is obsolete| | --- Comment #29 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 127198 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127198&action=edit Bug 29015: (QA follow-up) Change collection code to be just collection We did some clean-up in that area a little while ago, agreeing that as we acutally display the descriptions, the label should be just "collection". This patch also removes some (): Before: 4 items found for Centerville and item type:(Books) and collection: (Reference) and shelving location: (General Stacks) Now: 4 items found for Centerville and item type: Books and collection: Reference and shelving location: General Stacks Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29015 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29389 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29389 [Bug 29389] Add holding branch to holds queue report -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29015 --- Comment #30 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #21)
Testing this again and all seems to work as advertised, but there are some things that keep irritating me (unrelated to this patch, so not blocker):
* If I have a record level hold and I have 2 items for the record, that are identical apart from collection, how is the collection that shows on holds queue chosen? Only one shows and I can only filter on the one that shows...
Yes, the holds queue chooses a single item to fill the hold, so you see the one chosen. The script uses a lot of logic to determine which is the 'best' item, and we choose only one so that only one library attempts to fill the hold
* We can limit on library, so then I know which library I am looking at. But... when I choose "All", there seems to be no clue in the table about the library that owns the item and is supposed to provide it?
Bug 29389 filed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29015 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127195|0 |1 is obsolete| | --- Comment #31 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 127261 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127261&action=edit Bug 29015: Unit tests Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> JD Amended patch: perltidy! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29015 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29015 --- Comment #32 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29015 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29015 Sara Brown <sbrown@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30411 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org