[Bug 7644] New: Invalid markup in staff client language chooser
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7644 Priority: P5 - low Change sponsored?: --- Bug ID: 7644 Assignee: oleonard@myacpl.org Summary: Invalid markup in staff client language chooser QA Contact: koha.sekjal@gmail.com Severity: normal Classification: Unclassified OS: All Reporter: oleonard@myacpl.org Hardware: All Status: NEW Version: master Component: Templates Product: Koha The language chooser which is displayed in the staff client if there are more than one translations enabled contains invalid markup: <div id="changelanguage" class="ft"> <ul id="i18nMenu" class="footermenu"> <div class="lang"> <li>English</li> </div> <div class="lang"> <li><a href="/cgi-bin/koha/changelanguage.pl?language=fr-FR">Français</a></li> </div> </ul> </div> It is not valid to wrap a <li> with a <div>. It would be better to find a valid way to constrict this so that "real" validation problems are easier to identify when testing. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7644 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=7108 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7644 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7366 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7644 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 8033 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8033&action=edit Bug 7644 - Invalid markup in staff client language chooser This patch removes invalid markup from the language chooser in the intranet. It also copies the markup and style of the staff client include to the OPAC so the two are more consistent. I hope that will make future changes and debugging a little easier. I believe this patch also fixes Bug 7366, "Language chooser display problems." -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7644 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7644 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- To test this patch fully one should apply the patch and then (re)install several translations (including at least two language variants like fr-FR and fr-CA). I tested with en, fr-FR, fr-CA, and de-DE enabled. The language chooser menu in the OPAC and staff client should both look and work as expected, and patch should not re-create Bug 7108. Running pages from the OPAC and staff client through a validator should not show errors related to the language chooser markup. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7644 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8033|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 8167 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8167&action=edit [SIGNED-OFF] Bug 7644 - Invalid markup in staff client language chooser This patch removes invalid markup from the language chooser in the intranet. It also copies the markup and style of the staff client include to the OPAC so the two are more consistent. I hope that will make future changes and debugging a little easier. I believe this patch also fixes Bug 7366, "Language chooser display problems." Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Patch fixes bug 7366, but there is still a difference between staff and OPAC. Installed languages: en, en-NZ, de-DE, fr-FR Activated langauges: en, en-NZ, fr-FR OPC shows English, staff shows en-NZ as label for the list. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7644 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7644 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #4 from Ian Walls <koha.sekjal@gmail.com> --- Template and CSS only change. Produces valid HTML. Marking as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7644 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com Version|master |rel_3_6 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7644 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Validator on master shows no more errors related to the language chooser. Choosing languages works nicely too. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7644 --- Comment #6 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This bug will be included in the Koha 3.6.5 release. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org