https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41075 --- Comment #1 from Brendan Lawlor <blawlor@clamsnet.org> --- Although I guess this could be by design so that a patron would be able to get a digest of holds filled at different locations, then it might make sense for it to come from the patron home library. But in practice it confuses library staff and patrons who expect it to come from the pickup location -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41075 --- Comment #3 from Brendan Lawlor <blawlor@clamsnet.org> --- This is hard for me to test because I haven't been able to get SMTP fully working in ktd, but this is my understanding of what needs to change. I did test and confirm this bug in a production environment by changing the message preference Hold filled digest only setting and filling holds. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41075 --- Comment #5 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- (In reply to Brendan Lawlor from comment #1)

Although I guess this could be by design so that a patron would be able to get a digest of holds filled at different locations, then it might make sense for it to come from the patron home library.

But in practice it confuses library staff and patrons who expect it to come from the pickup location

This is by design - this case will work when a single hold is filled, but if two holds are filled at different libraries in the digest window it may not look like what is expected either. I think, at the very least, it needs a switch to say which notice you prefer to use. Possibly more ideal would be to have a generic hold digest wrapper - so each hold could be generated library specific, and the generic wrapper used as the base to collect all of those? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41075 --- Comment #7 from Brendan Lawlor <blawlor@clamsnet.org> --- Thanks Nick! I understand for a digest of something like autorenewals, it makes perfect sense for them to come from the home library. With hold pickup notices it's a little odd because it causes people to second guess where they requested the pickup. I think partly the issue is the process_message_queue cron runs so frequently that hold pickup notices are rarely actually digested. Patrons mostly get single notices and get confused when it's not from the pick.up location they requested. Maybe a system preference like DigestHoldPickupNoticesBy with the options Home Library, Pickup Library could control this behavior. In a consortia, the pickup library might want something in their pickup notice and that becomes irrelevant if the sender and the pickup location don't match. Maybe it's possible to restructure this without a system preference, but that seems like it would probably be more complicated. Thanks for the tip to check the message_queue table for testing! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41075 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon@cdalibrary.org --- Comment #8 from Christopher Brannon <cbrannon@cdalibrary.org> --- I'm wondering if digests could be grouped by pickup library. Either that, or the notice needs to be able to list what is available where, and have a reply button next to each pickup location. -- You are receiving this mail because: You are watching all bug changes.