[Bug 34336] New: Can we get rid of Test::DBIx::Class?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34336 Bug ID: 34336 Summary: Can we get rid of Test::DBIx::Class? Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: m.de.rooy@rijksmuseum.nl QA Contact: testopia@bugs.koha-community.org See 33833 Our use is limited. The tests are harder to read imo than the TestBuilder tests, but that could be a personal idea. Using the module may hide/oversimplify what we actually need. When removing the module somewhere, a constraint came up that was hidden by TDC but should be dealt with in the test. The module has a history of laborious installing but that is probably history. I opt for removing it in the few tests using it. What do you think? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34336 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au, | |jonathan.druart+koha@gmail. | |com, mtj@kohaaloha.com, | |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34336 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33833 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34336 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34336 --- Comment #1 from David Cook <dcook@prosentient.com.au> --- I don't know enough about its usage but it looks like it hasn't been updated since 2016. At a glance, it seems like it might be better for smaller simpler projects. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34336 --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I don't really see any real benefit of keeping it around at this stage. As some point, I like the idea of trying to make a more database independent test set.. but in reality, the integration tests we have are in many ways more helpful. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34336 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |34415 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34415 [Bug 34415] Remove Test::DBIx::Class from t/EdiTransport.t -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34336 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |m.de.rooy@rijksmuseum.nl |ity.org | Status|NEW |ASSIGNED Summary|Can we get rid of |Test::DBIx::Class should be |Test::DBIx::Class? |removed --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Go ahead! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34336 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33833, 33869, 33870 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33833 [Bug 33833] Remove Test::DBIx::Class from t/SocialData.t https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33869 [Bug 33869] Move Matcher.t to db_dependent https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33870 [Bug 33870] Remove T::D::C from Sitemapper.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34336 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |34812 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34812 [Bug 34812] Remove Test::DBIx::Class from Koha.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34336 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |34825 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34825 [Bug 34825] Move Letters.t to t/db_dependent -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34336 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |34887 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34887 [Bug 34887] Merge Patron.t into t/db/Koha/Patron.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34336 --- Comment #4 from Mason James <mtj@kohaaloha.com> --- (In reply to Marcel de Rooy from comment #0)
See 33833
The module has a history of laborious installing but that is probably history.
some good news, the package has arrived in debian/ubuntu stable https://packages.debian.org/bookworm/all/libtest-dbix-class-perl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34336 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |34967, 34968, 34969, 34970 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34967 [Bug 34967] Move Prices.t to t/db_dependent https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34968 [Bug 34968] t/Search.t does not do anything with Test::DBIx::Class https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34969 [Bug 34969] t/Search/buildQuery.t does not do anything with Test::DBIx::Class https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34970 [Bug 34970] t/SuggestionEngine_AuthorityFile.t does not do anything with Test::DBIx::Class -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34336 --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Mason James from comment #4)
(In reply to Marcel de Rooy from comment #0)
See 33833
The module has a history of laborious installing but that is probably history.
some good news, the package has arrived in debian/ubuntu stable
https://packages.debian.org/bookworm/all/libtest-dbix-class-perl
More good news: We are almost ready to remove it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34336 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34336 --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 156589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156589&action=edit Bug 34336: Remove the dependency for Test::DBIx::Class The module is removed from t. We only have 01-test_dbic.t and we do not need it any longer. Test plan: git grep for Test::DBIx::Class. You should only see release notes. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34336 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Trivial last patch in a series: Self SO -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34336 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |dependency -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34336 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34336 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156589|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 156616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156616&action=edit Bug 34336: Remove the dependency for Test::DBIx::Class The module is removed from t. We only have 01-test_dbic.t and we do not need it any longer. Test plan: git grep for Test::DBIx::Class. You should only see release notes. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34336 --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Thank you guys. You are awesome. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34336 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34336 --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34336 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #11 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 23.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34336 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34336 Bug 34336 depends on bug 34415, which changed state. Bug 34415 Summary: Remove Test::DBIx::Class from t/EdiTransport.t https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34415 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34336 Bug 34336 depends on bug 34812, which changed state. Bug 34812 Summary: Remove Test::DBIx::Class from Koha.t https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34812 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org