[Bug 13896] New: PID is created in /tmp/ instead of in /var/run/koha/...
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13896 Bug ID: 13896 Summary: PID is created in /tmp/ instead of in /var/run/koha/... Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: Linux Status: NEW Severity: trivial Priority: P5 - low Component: Packaging Assignee: koha-bugs@lists.koha-community.org Reporter: attila@kinali.ch QA Contact: testopia@bugs.koha-community.org CC: robin@catalyst.net.nz The daemon command uses /tmp/ as default directory for creating pid files unless the directory has been specified explicitly. This affects only the debian start scripts. The following patch fixes this --- a/debian/scripts/koha-start-zebra +++ b/debian/scripts/koha-start-zebra @@ -40,6 +40,7 @@ start_zebra_instance() "/var/log/koha/$instancename/zebra-output.log" daemon \ --name="$instancename-koha-zebra" \ + --pidfiles="/var/run/koha/$instancename/" \ --errlog="/var/log/koha/$instancename/zebra-error.log" \ --stdout="/var/log/koha/$instancename/zebra.log" \ --output="/var/log/koha/$instancename/zebra-output.log" \ -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13896 Attila Kinali <attila@kinali.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.18 |master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13896 --- Comment #1 from Attila Kinali <attila@kinali.ch> --- Created attachment 37164 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37164&action=edit patch Add patch file as requested by cait -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13896 Attila Kinali <attila@kinali.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13896 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13896 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37164|0 |1 is obsolete| | --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 37434 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37434&action=edit Bug 13896: Fix pid file creation, use proper directory instead of /tmp/ daemon uses by default /tmp/ for pid files, if they are unspecified. Pass the right directory to daemon, so it knows where to put the pid file. Signed-off-by: Attila Kinali <attila@kinali.ch> TEST PLAN --------- 1) Roll a distribution and confirm it works. OR 1) Hack all the /var directories to point to git directories 2) Add a dummy user for the instance name 3) sudo the script with the faked instance name. -- the daemon should be running and the pid file should be in the expected directory. The first way is the proper way to test, I did the latter. :) Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13896 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13896 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37434|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 37460 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37460&action=edit [PASSED QA] Bug 13896: Fix pid file creation, use proper directory instead of /tmp/ daemon uses by default /tmp/ for pid files, if they are unspecified. Pass the right directory to daemon, so it knows where to put the pid file. Signed-off-by: Attila Kinali <attila@kinali.ch> TEST PLAN --------- 1) Roll a distribution and confirm it works. OR 1) Hack all the /var directories to point to git directories 2) Add a dummy user for the instance name 3) sudo the script with the faked instance name. -- the daemon should be running and the pid file should be in the expected directory. The first way is the proper way to test, I did the latter. :) Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13896 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 37589 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37589&action=edit Bug 13896: (QA followup) fix koha-{stop|restart}-zebra too Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13896 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Pushed to Master --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Attila! Congratulations for your patch! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13896 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.18.x will be in 3.18.6 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org