[Bug 8368] New: List email broken for non english templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8368 Priority: P5 - low Change sponsored?: --- Bug ID: 8368 Assignee: oleonard@myacpl.org Summary: List email broken for non english templates Severity: major Classification: Unclassified OS: All Reporter: katrin.fischer@bsz-bw.de Hardware: All Status: NEW Version: master Component: OPAC Product: Koha This is the same problem as for bug 8062 only for sending out lists. Copying description with some changes: To reproduce: - Create a list that you can access - Open list in OPAC or staff - log in, if you didn't before - Send list to any email address - Check email text and attachements The mail sent from the translated templates has subject "no subject" and is empty. The marc files are attached. The mail sent from the english templates is all correct. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8368 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8062 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8368 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |critical -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8368 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9218 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8368 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |9189 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8368 Sophie MEYNIEUX <sophie.meynieux@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sophie.meynieux@biblibre.co | |m Assignee|oleonard@myacpl.org |fridolyn.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8368 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #1 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 21427 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21427&action=edit Proposed patch This patch ports to list sending by email, the technic used in sending cart, ie (1) format email in HTML, and (2) transform it into Text with TT filter html2text. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8368 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8368 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- This works for me except where the template tries to show subtitles. I get something like this: Swiss Family Robinson ARRAY(0xc0a58b4) Your patch removes this: - [% IF ( BIBLIO_RESULT.subtitle.size ) %] [% FOREACH subtitle IN BIBLIO_RESULT.subtitle %][% subtitle.subfield %][% END %][% END %] ...in favor of this: + [% IF ( BIBLIO_RESULT.subtitle ) %] [% BIBLIO_RESULT.subtitle %][% END %] BIBLIO_RESULT.subtitle is not a simple variable, hence the way it was handled previously. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8368 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21427|0 |1 is obsolete| | --- Comment #3 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 21447 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21447&action=edit [SIGNED-OFF] Bug 8368 List email broken for non english templates This patch ports to list sending by email, the technic used in sending cart, ie (1) format email in HTML, and (2) transform it into Text with TT filter html2text. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Work as described. No koha-qa errors Test 1) Installed language other than english 2) Create new list, add a few books 3) Send list in english, subject Ok 4) Swith opac lang, send list, No subject 5) Apply patch 6) Send list in english, subject Ok 7) Switch opac lang, send list, subject Ok -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8368 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21447|0 |1 is obsolete| | Status|Failed QA |Needs Signoff Assignee|fridolyn.somers@biblibre.co |frederic@tamil.fr |m | --- Comment #4 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 21448 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21448&action=edit Proposed patch (v2 see Owen comment) Restore proper subtitle display? Thanks Owen. Something in my devel DB, or in UNIMARC, prevent subtitle display. I hope it works for MARC21/your DB. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8368 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21427|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8368 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21427|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8368 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8368 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21448|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 21457 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21457&action=edit [SIGNED-OFF] Bug 8368 List email broken for non english templates This patch ports to list sending by email, the technic used in sending cart, ie (1) format email in HTML, and (2) transform it into Text with TT filter html2text. Note: V2 of this patch: Restore proper subtile display. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8368 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8368 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21457|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 21529 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21529&action=edit [PASSED QA] Bug 8368 List email broken for non english templates This patch ports to list sending by email, the technic used in sending cart, ie (1) format email in HTML, and (2) transform it into Text with TT filter html2text. Note: V2 of this patch: Restore proper subtile display. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Fixes a very annoying translation bug successfully. Also passes all tests and QA script. To test: - Add a few records to a shelf, ideally use some with diacritics. - Send shelf from English templates, verify email is ok - Send shelf from translated templates (de-DE or similar) - verify email content is broken. - Apply patches, update po files and reinstall the language. - Send shelf from English templates again, verify there is no regression. - Send shelf form translates templates - verify this email is now also working correctly. Patch also changes the name of the file attachement from shelf.iso2709 to list.iso2709. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8368 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #7 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master, along with follow-ups to restore the display of ISBNs in the email, porting the template change to the new Bootstrap theme, and restoring the use of encode_qp(). Thanks, Frédéric! As a side note, perhaps the email templates should probably be moved outside of the OPAC theme template directories. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8368 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Tomas, I think we shoudl have this in 3.12 as list emails are still broken there. Could you consider for your next release? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8368 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This patch has been pushed to 3.12.x, will be in 3.12.8. Thanks Frederic! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org