[Bug 26937] New: Add an optional delay to the CheckPrevCheckout system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26937 Bug ID: 26937 Summary: Add an optional delay to the CheckPrevCheckout system preference Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: matthias.meusburger@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com The CheckPrevCheckout system preference allows to check a borrower's checkout history to see if the current item has been checked out before. It would be nice to be able to specify the maximum number of days since the last checkin that will trigger CheckPrevCheckout's warning. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26937 --- Comment #1 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- Created attachment 113101 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113101&action=edit Bug 26937: Add an optional delay to the CheckPrevCheckout syspref. The CheckPrevCheckout allows to check a borrower's checkout history to see if the current item has been checked out before. This patch adds an optional syspref: CheckPrevCheckoutDelay It allows to specify the maximum number of days since the last checkin that will trigger CheckPrevCheckout's warning. Test plan: - Apply the patch. - Set CheckPrevCheckout to "Do" and CheckPrevCheckoutDelay to n. - Checkout and check-in an item for a patron. - Try to checkout the same item. - Check that you have a warning: "Patron has previously checked out this title: Check out anyway?" - Update the returndate column from the old_issues table to have a returndate older than n days ago. - Try to checkout the same item. - Check that you don't have the warning. - Prove t/db_dependent/Patron/Borrower_PrevCheckout.t -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26937 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |matthias.meusburger@biblibr |ity.org |e.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26937 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26937 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113101|0 |1 is obsolete| | --- Comment #2 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- Created attachment 113102 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113102&action=edit Bug 26937: Add an optional delay to the CheckPrevCheckout syspref. The CheckPrevCheckout allows to check a borrower's checkout history to see if the current item has been checked out before. This patch adds an optional syspref: CheckPrevCheckoutDelay It allows to specify the maximum number of days since the last checkin that will trigger CheckPrevCheckout's warning. Test plan: - Apply the patch. - Set CheckPrevCheckout to "Do" and CheckPrevCheckoutDelay to n. - Checkout and check-in an item for a patron. - Try to checkout the same item. - Check that you have a warning: "Patron has previously checked out this title: Check out anyway?" - Update the returndate column from the old_issues table to have a returndate older than n days ago. - Try to checkout the same item. - Check that you don't have the warning. - Prove t/db_dependent/Patron/Borrower_PrevCheckout.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26937 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113102|0 |1 is obsolete| | --- Comment #3 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 113343 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113343&action=edit Bug 26937: Add an optional delay to the CheckPrevCheckout syspref. The CheckPrevCheckout allows to check a borrower's checkout history to see if the current item has been checked out before. This patch adds an optional syspref: CheckPrevCheckoutDelay It allows to specify the maximum number of days since the last checkin that will trigger CheckPrevCheckout's warning. Test plan: - Apply the patch. - Set CheckPrevCheckout to "Do" and CheckPrevCheckoutDelay to n. - Checkout and check-in an item for a patron. - Try to checkout the same item. - Check that you have a warning: "Patron has previously checked out this title: Check out anyway?" - Update the returndate column from the old_issues table to have a returndate older than n days ago. - Try to checkout the same item. - Check that you don't have the warning. - Prove t/db_dependent/Patron/Borrower_PrevCheckout.t Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26937 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk Status|Needs Signoff |Signed Off --- Comment #4 from Sally <sally.healey@cheshiresharedservices.gov.uk> --- Works as expected, signed off. NB. If you're using a sandbox to test, you can perform this step: Update the returndate column from the old_issues table to have a returndate older than n days ago. by using the 'Specify return date' option in Circulation > Check in -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26937 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26937 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113343|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 116904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116904&action=edit Bug 26937: Add an optional delay to the CheckPrevCheckout syspref. The CheckPrevCheckout allows to check a borrower's checkout history to see if the current item has been checked out before. This patch adds an optional syspref: CheckPrevCheckoutDelay It allows to specify the maximum number of days since the last checkin that will trigger CheckPrevCheckout's warning. Test plan: - Apply the patch. - Set CheckPrevCheckout to "Do" and CheckPrevCheckoutDelay to n. - Checkout and check-in an item for a patron. - Try to checkout the same item. - Check that you have a warning: "Patron has previously checked out this title: Check out anyway?" - Update the returndate column from the old_issues table to have a returndate older than n days ago. - Try to checkout the same item. - Check that you don't have the warning. - Prove t/db_dependent/Patron/Borrower_PrevCheckout.t Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26937 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 116905 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116905&action=edit Bug 26937: (QA follow-up) Rephrase and link CheckPrevCheckoutDelay description Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26937 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This adds a new system release notes| |preference | |CheckPrevCheckoutDelay that | |allows to specify a number | |of days that is used with | |the CheckPrevCheckout | |feature to determine, if a | |warning should be shown or | |not. If the checkin date of | |the item that is about to | |be checked out is longer | |ago than | |CheckPrefCheckoutDelay | |days, no warning will be | |displayed. Keywords| |Manual --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Tried to write release notes, a native speaker might be able to improve them. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26937 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Does it make sense to have a global setting when the check prev checkout feature can be tweak at 3 different levels (pref, patron's category, individual patron)? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26937 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26937 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think as this is about the general behaviour, not an on/off switch starting on a global level would be perfectly fine. It would be possible to extend this to granular if there is a need later without having to disrupt any existing workflows. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26937 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26937 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26937 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26937 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #11 from Fridolin Somers <fridolin.somers@biblibre.com> --- Nice enhancement. I'm not sure about backport to stable, see comment 8. Without this pref, this delay depends on issues anonymize, if I understand well the code. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26937 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26591 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26937 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think this is a clear enhancement of an existing feature and should not be backported. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26937 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com Keywords|Manual |Manual-updated -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org