https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38940 Sara Brown <sbrown@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|ConsiderLibraryHoursInCircu |ConsiderLibraryHoursInCircu |lation set to "shorten the |lation set to "shorten the |loan period and set the |loan period and set the |checkout to be due at the |checkout to be due at the |library’s close time" does |library’s close time" is |not appear to work |not working -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38940 Koha collecto <koha@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha@collecto.ca --- Comment #2 from Koha collecto <koha@collecto.ca> --- Hi ! Are all of your open time et close time filled ? I was having the same issue but my saturday and sunday were "null" since the library is closed on the weekend. I then filled the hours for the two days and I was able to make it work. Tho there's still a problem with that because I've put 00:00 in both the open time and close time thinking that Koha would understand that the library is not open on that day, but when I tried the "extend the loan period and set the checkout to be due at the library's open time" option my loan period was extended to saturday 00:00 wich is not wat I want. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38940 Ray Delahunty <r.delahunty@arts.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |r.delahunty@arts.ac.uk -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38940 --- Comment #4 from Ray Delahunty <r.delahunty@arts.ac.uk> --- We are extensively testing loan shortening in 24.11 to try to get it to work with how we have to configure circcontrol (to keep max loans entitlement under control in our multi-site setup given Bug 27834) and are replicating what Raina reports. And while an attempt to trick Koha by adding in a 5 minute opening time at 03:00 on the closed day tomorrow appears to work (the loan period is shortened correctly today) Koha requires the staff member to manually approve the loan, so I don't see our laptops loans units and self issue kiosks tolerating that. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38940 --- Comment #5 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 188622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188622&action=edit Bug 38940: Fix ConsiderLibraryHoursInCirculation when next day has no hours When ConsiderLibraryHoursInCirculation is set to "shorten the loan period and set the checkout to be due at the library's close time", the feature fails to work if the next day has null/blank library hours (e.g., weekends or closed days). The code was incorrectly forcing the system to ignore library hours entirely whenever EITHER today's hours OR tomorrow's hours were undefined. This was too restrictive because: - The 'close' option only needs today's closing time - The 'open' option needs tomorrow's opening time This patch modifies the logic to: 1. Only ignore library hours if today's hours are missing 2. For 'open' mode, require tomorrow's hours to extend the loan 3. For 'close' mode, allow it to work with just today's hours 4. Gracefully handle null tomorrow hours in both code paths Test plan: 1. Apply patch and run tests: prove t/db_dependent/Circulation/CalcDateDue.t prove t/db_dependent/Circulation.t 2. Set up a library with operating hours in Tools > Libraries and hours > [Your library] - Monday-Friday: 09:00-17:00 - Saturday-Sunday: Leave blank (no hours defined) 3. Set system preferences: - ConsiderLibraryHoursInCirculation: shorten the loan period - useDaysMode: Use the calendar to skip days the library is closed 4. Create a circulation rule with hourly loan: - Go to Administration > Circulation and fine rules - Set loan period to 4 hours for a patron category/itemtype 5. On a Friday at 2:00 PM, check out an item with the 4-hour loan rule - Without patch: Due date would be Friday 6:00 PM (ignoring library hours because Saturday has no hours) - With patch: Due date should be Friday 5:00 PM (correctly shortened to library closing time) 6. Verify that checking out at 3:00 PM still shortens to 5:00 PM close 7. Test with ConsiderLibraryHoursInCirculation set to "extend to next opening time" - Checkout should fall back to standard loan duration when next day has no hours (since we can't extend to an undefined opening time) NOTES FOR REVIEW: When ConsiderLibraryHoursInCirculation is set to "extend the loan period to the library's next opening time" and the next day has no defined hours, this patch falls back to using the standard loan duration (ignoring library hours). Question for reviewers: Should we instead roll forward to find the next day that HAS defined opening hours? For example, if checking out Friday evening with the library closed Saturday/Sunday, should we extend the due date to Monday's opening time rather than falling back to ignoring library hours? Sponsored-by: Open Fifth <https://openfith.co.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38940 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|24.05 |Main -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38940 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |s.graham4@herts.ac.uk -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38940 --- Comment #6 from David Nind <david@davidnind.com> --- At a loss on how to do step 5. Tried setting server date and time, but I couldn't get it to change. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38940 --- Comment #8 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 189155 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189155&action=edit Bug 38940: Consider calendar holidays when extending loans to next opening time This follow-up patch addresses a limitation in the previous fix where ConsiderLibraryHoursInCirculation='open' mode would extend loans to tomorrow's opening time even when tomorrow was marked as a holiday in the calendar. The issue: A library might have operating hours defined for every day of the week (e.g., Monday-Sunday 09:00-17:00), but have specific days marked as holidays in the calendar (e.g., public holidays, special closures). The previous code only checked if operating hours were defined, not whether the library was actually open according to the calendar. This patch modifies the logic to: 1. When in 'open' mode with Calendar daysmode, check if tomorrow is a holiday in the calendar 2. If tomorrow is a holiday, look forward up to 7 days to find the next day that is: - Not marked as a holiday in the calendar AND - Has defined operating hours 3. Extend the loan to that day's opening time 4. If no suitable day is found within 7 days, fall back to standard loan duration (ignoring library hours) Note: 'close' mode is unaffected since we only need today's closing time, and checkouts can only happen on open days. Test plan: 1. Apply patch and run tests: prove t/db_dependent/Circulation/CalcDateDue.t 2. Note the current time and day of week for your testing. Configure Koha based on the current time to test the functionality. 3. Configure library operating hours at Administration > Libraries > [Select your library] > Hours Set operating hours for multiple consecutive days: - TODAY (your current day): Set hours that include the current time Example: If it's currently 14:30, set hours like 09:00-17:00 - TOMORROW: Set hours (e.g., 10:00-18:00) - DAY AFTER TOMORROW: Set hours (e.g., 10:00-18:00) - THIRD DAY: Set hours (e.g., 10:00-18:00) Example if testing on Friday at 14:30: - Friday: 09:00-17:00 (must include current time) - Saturday: 10:00-18:00 - Sunday: 10:00-18:00 - Monday: 10:00-18:00 4. Mark tomorrow as a holiday at Tools > Calendar > [Select your library] - Click "New holiday" or "Holidays repeating weekly" - If testing on Friday, mark Saturday as a single-day holiday - Save the holiday Note: This creates a scenario where tomorrow HAS operating hours defined, but is marked as closed in the calendar (e.g., a public holiday that falls on a normally-open day) 5. Set system preferences: - ConsiderLibraryHoursInCirculation: "extend the loan period to the library's next opening time" - useDaysMode: "Use the calendar to skip days the library is closed" 6. Create a circulation rule with hourly loan period: - Go to Administration > Circulation and fine rules - Set loan period in hours that would extend past today's closing time - Calculate: (Closing time - Current time) + 1 hour minimum Example: If it's 14:30 now and library closes at 17:00, set loan period to 4 or 5 hours 7. Test the 'open' behavior with calendar holidays: - Check out an item using the hourly loan rule Without patch: Due date/time would extend to tomorrow's opening time (e.g., Saturday 10:00), even though Saturday is a holiday With patch: Due date/time should extend to the next open day's opening time (e.g., if Saturday is a holiday, should extend to Sunday 10:00, or if Sunday is also a holiday, to Monday 10:00) 8. Verify the behavior: - The due date should skip over the calendar holiday - Check out multiple items - they should all have the same due time (next open day's opening time) 9. Test with multiple consecutive holidays: - Mark both TOMORROW and DAY AFTER as holidays in the calendar - Check out an item - Should extend to THIRD DAY's opening time (first non-holiday day with defined hours) 10. Test fallback behavior: - Configure library with NO operating hours for any day after today - Mark tomorrow as a holiday - Check out should fall back to standard loan duration since there's no suitable day to extend to 11. Test with 'close' mode to verify it's unaffected: - Change ConsiderLibraryHoursInCirculation to "shorten the loan period to end when the library closes" - Check out an item - Should still shorten to today's closing time (calendar holidays don't affect this mode since we only need today's hours) NOTES FOR REVIEW: This patch looks ahead up to 7 days to find a suitable open day. This limit prevents infinite loops and matches typical library closure patterns (weekend + public holiday = 3-4 days max). When no suitable day is found within 7 days, the system falls back to standard loan duration, which then uses the calendar's normal day- skipping logic when the loan comes due. This patch only affects Calendar daysmode. When using Days mode (ignore calendar), the behavior is unchanged from the previous patch. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38940 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #10 from David Cook <dcook@prosentient.com.au> --- One of my librarians has just gotten bitten by this. We don't have many libraries using hourly loans, which is probably why it hasn't come up for us sooner. We have used the "00:00" workaround when ConsiderLibraryHoursInCirculation is set to "shorten the loan period and set the checkout to be due at the library's close time", but it's not a brilliant workaround. I'll make a note to review Martin's patches. -- You are receiving this mail because: You are watching all bug changes.