[Bug 37556] New: Add project folders of popular IDEs to .gitignore
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37556 Bug ID: 37556 Summary: Add project folders of popular IDEs to .gitignore Change sponsored?: Sponsored Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Developer documentation Assignee: koha-bugs@lists.koha-community.org Reporter: rudolfbyker@gmail.com QA Contact: testopia@bugs.koha-community.org Ignoring the .idea and .vscode folders makes working with the Koha repo using IntelliJ IDEA or VS Code easier. Patch incoming. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37556 Rudolf Byker <rudolfbyker@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rudolfbyker@gmail.com Assignee|koha-bugs@lists.koha-commun |rudolfbyker@gmail.com |ity.org | Status|NEW |ASSIGNED --- Comment #1 from Rudolf Byker <rudolfbyker@gmail.com> --- Created attachment 169991 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169991&action=edit Ignore .idea and .vscode -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37556 Rudolf Byker <rudolfbyker@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37556 Rudolf Byker <rudolfbyker@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Developer documentation |Architecture, internals, | |and plumbing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37556 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim@ptfs-europe.co | |m --- Comment #2 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Rudolf, I believe this is ready for others to look at? If so, you should update its status to "Needs Signoff" or else it won't show up in people's TODO lists. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37556 Rudolf Byker <rudolfbyker@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #3 from Rudolf Byker <rudolfbyker@gmail.com> --- Oh, I forgot that. Thanks -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37556 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37556 --- Comment #4 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 169999 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169999&action=edit Bug 37556: Add project folders of popular IDEs to .gitignore Ignoring the .idea and .vscode folders makes working with the Koha repo using IntelliJ IDEA or VS Code easier. To test: 1. Clone the Koha repo. 2. Open the repo folder in an IDE like IntelliJ IDEA or VS Code. 3. Observe that the IDE creates an .idea or .vscode folder but does not try to commit it. Sponsored-by: Reformational Study Centre <www.refstudycentre.com> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37556 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #5 from Julian Maurice <julian.maurice@biblibre.com> --- Just in case you don't already know: you can ignore these files without touching .gitignore, either globally using $HOME/.config/git/ignore or locally using .../koha/.git/info/exclude I use that to ignore vim temporary files. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37556 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Julian Maurice from comment #5)
Just in case you don't already know: you can ignore these files without touching .gitignore, either globally using $HOME/.config/git/ignore or locally using .../koha/.git/info/exclude I use that to ignore vim temporary files.
I can confirm that this works. I looked it up remembering Julian hat pointed it out a while ago. I was going to suggest adding a hint to the wiki, only to realize it's already there :) https://wiki.koha-community.org/wiki/Koha-testing-docker Maybe this would be better than adding IDE specific code to Koha codebase? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37556 --- Comment #7 from Rudolf Byker <rudolfbyker@gmail.com> ---
Maybe this would be better than adding IDE specific code to Koha codebase?
Sorry to nit-pick here, but it's IDE-specific config, not IDE-specific code (i.e., it has no effect on the end product, only on the developer experience). It's conceptually similar to something like `.editorconfig`. It's standard practice in many projects that I have seen to have IDE-specific stuff in `.gitignore`. The reason why I would not want to do this in my `.git` settings, it because I have other projects on my machine where `.idea` and/or `.vscode` should not be ignored. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37556 --- Comment #8 from Julian Maurice <julian.maurice@biblibre.com> ---
It's conceptually similar to something like `.editorconfig` Except .editorconfig is not specific to a single editor/IDE and *should* be committed to the repository. How are they similar in this context ?
The reason why I would not want to do this in my `.git` settings, it because I have other projects on my machine where `.idea` and/or `.vscode` should not be ignored. You can still ignore it in the repository specific .git/info/exclude file, or ignore it globally and then de-ignore it in a project specific file. Honestly it's easier than asking every project you work on to add rules for your
(In reply to Rudolf Byker from comment #7) preferred tools. (Never had seen a .swp file even once since I learned that ;)) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37556 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com Attachment #169991|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37556 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #9 from Jonathan Druart <jonathan.druart@gmail.com> --- I am on Julian's side, setting to in discussion. Feel free to bring the topic to a dev meeting. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org