[Bug 28216] New: Fix vendor list group by in serials statistics wizard
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28216 Bug ID: 28216 Summary: Fix vendor list group by in serials statistics wizard Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Serials Assignee: koha-bugs@lists.koha-community.org Reporter: fridolin.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org Bug 24940 added sort vendor list by aqbookseller.name but removed accidentally the group by. Now vendors are repeated in the list. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28216 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24940 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24940 [Bug 24940] Serials statistics wizard: order vendor list alphabetically -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28216 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |fridolin.somers@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28216 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28216 --- Comment #1 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 120163 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120163&action=edit Bug 28216: Fix vendor list group by in serials statistics wizard Bug 24940 added sort vendor list by aqbookseller.name but removed accidentally the group by. Now vendors are repeated in the list. Test plan : 1) Create several subscriptions for same vendor 2) Go to Reports > Serials 3) Check list of vendors => Without patch you see the same vendor several times => With patch you seen it once 4) Check sort is still on vendor name -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28216 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- I get an error: Plack::App::WrapCGI::call(): DBI Exception: DBD::mysql::st execute failed: 'koha_kohadev.subscription.aqbooksellerid' isn't in GROUP BY [for Statement "SELECT aqbooksellerid, aqbooksellers.name FROM subscription LEFT JOIN aqbooksellers ON (subscription.aqbooksellerid=aqbooksellers.id ) GROUP BY aqbooksellers.id ORDER BY aqbooksellers.name ASC "] at /usr/share/perl5/Plack/Component.pm line 50 at /usr/share/perl5/DBIx/Class/Exception.pm line 77 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28216 --- Comment #3 from Fridolin Somers <fridolin.somers@biblibre.com> --- Oh I see -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28216 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28216 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120163|0 |1 is obsolete| | --- Comment #4 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 120755 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120755&action=edit Bug 28216: Fix vendor list group by in serials statistics wizard Bug 24940 added sort vendor list by aqbookseller.name but removed accidentally the group by. Now vendors are repeated in the list. Test plan : 1) Create several subscriptions for same vendor 2) Go to Reports > Serials 3) Check list of vendors => Without patch you see the same vendor several times => With patch you seen it once 4) Check sort is still on vendor name -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28216 Hinet Romain <romain.hinet-debain@univ-amu.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |romain.hinet-debain@univ-am | |u.fr --- Comment #5 from Hinet Romain <romain.hinet-debain@univ-amu.fr> --- I have a message "Error trace" when i click to "Serials statistics wizard" https://staff-amu.sandboxes.biblibre.eu/cgi-bin/koha/reports/serials_stats.p... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28216 --- Comment #6 from Hinet Romain <romain.hinet-debain@univ-amu.fr> --- Hi, Without the patch I have the same message error trace, when clic to "serial statistics wizards https://staff-amu.sandboxes.biblibre.eu/cgi-bin/koha/reports/serials_stats.p... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28216 --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Ah another mistake : DBD::mysql::st execute failed: 'aqbooksellers.name' isn't in GROUP BY -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28216 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120755|0 |1 is obsolete| | --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 125446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125446&action=edit Bug 28216: Fix vendor list group by in serials statistics wizard Bug 24940 added sort vendor list by aqbookseller.name but removed accidentally the group by. Now vendors are repeated in the list. Test plan : 1) Create several subscriptions for same vendor 2) Go to Reports > Serials 3) Check list of vendors => Without patch you see the same vendor several times => With patch you seen it once 4) Check sort is still on vendor name -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28216 Samu Heiskanen <samu.heiskanen@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28216 Samu Heiskanen <samu.heiskanen@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125446|0 |1 is obsolete| | --- Comment #9 from Samu Heiskanen <samu.heiskanen@hypernova.fi> --- Created attachment 128424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128424&action=edit Bug 28216: Fix vendor list group by in serials statistics wizard Bug 24940 added sort vendor list by aqbookseller.name but removed accidentally the group by. Now vendors are repeated in the list. Test plan : 1) Create several subscriptions for same vendor 2) Go to Reports > Serials 3) Check list of vendors => Without patch you see the same vendor several times => With patch you seen it once 4) Check sort is still on vendor name Signed-off-by: Samu Heiskanen <samu.heiskanen@hypernova.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28216 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28216 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128424|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 128462 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128462&action=edit Bug 28216: Fix vendor list group by in serials statistics wizard Bug 24940 added sort vendor list by aqbookseller.name but removed accidentally the group by. Now vendors are repeated in the list. Test plan : 1) Create several subscriptions for same vendor 2) Go to Reports > Serials 3) Check list of vendors => Without patch you see the same vendor several times => With patch you seen it once 4) Check sort is still on vendor name Signed-off-by: Samu Heiskanen <samu.heiskanen@hypernova.fi> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28216 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28216 --- Comment #11 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28216 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This fixes an issue where release notes| |vendors are repeated in the | |serials report. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28216 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00 |22.05.00,21.05.08 released in| | CC| |andrew@bywatersolutions.com --- Comment #12 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Pushed to 21.05.x for 21.05.08 (looks like this is in 21.11 but not noted here yet) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28216 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28216 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28216 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED CC| |victor@tuxayo.net Resolution|--- |FIXED --- Comment #13 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28216 Andrew Nugged <nugged@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nugged@gmail.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org