[Bug 5804] New: duplicate warning when ordering needs design work
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5804 Bug #: 5804 Summary: duplicate warning when ordering needs design work Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: Templates AssignedTo: oleonard@myacpl.org ReportedBy: nengard@gmail.com QAContact: koha-bugs@lists.koha-community.org The patch for Bug 5782 added a duplicate check when ordering from an external source. The new template file could use some cleaning up and maybe some text clean up or streamlined display. I don't have any specific suggestions at this time, I just wanted to get the report out there. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5804 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> 2011-02-24 15:55:10 UTC --- Created attachment 3207 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3207 Screenshot of suggested revision -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5804 --- Comment #2 from Nicole C. Engard <nengard@gmail.com> 2011-02-24 18:16:11 UTC --- Owen, you never cease to amaze me! I love it! -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5804 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> 2011-02-24 19:38:36 UTC --- Created attachment 3210 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3210 Proposed fix -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5804 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Status|NEW |ASSIGNED Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5804 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5804 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Patch Status|Signed Off |Patch Pushed --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> 2011-02-27 21:45:10 UTC --- Pushed please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5804 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #5 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-02-28 08:13:34 UTC --- Good work! Two very small points that could be improved: 1) Typo: Crete new record -> Create new record 2) The third box doesn't align with the other two in my browser, since the line Return to the basket.. is shorter. I would prefer to see all three the same size with the command buttons at the same height. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5804 --- Comment #6 from Nicole C. Engard <nengard@gmail.com> 2011-02-28 12:42:44 UTC --- Oopsie! missed that typo. As for the boxes, what browser/operating system combo are you on? My boxes lined up in FF on Mac. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5804 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> 2011-02-28 13:52:40 UTC --- Created attachment 3225 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3225 Follow-up fix -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5804 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Patch Pushed |Needs Signoff --- Comment #8 from Owen Leonard <oleonard@myacpl.org> 2011-02-28 13:54:38 UTC --- With regard to the differently-sized boxes: These are independently-rendered <div>s, so without making the letter count of each box the same there will be differences. The alternative would be using jQuery to make them the same size, which I think is overkill for a minor size difference. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5804 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5804 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Needs Signoff --- Comment #9 from MJ Ray (software.coop) <mjr@ttllp.co.uk> 2011-03-04 10:26:46 UTC --- This bug is mentioned in: Fix for Bug 5804 - duplicate warning when ordering needs design work http://lists.koha-community.org/pipermail/koha-patches/2011-February/013926.... Fix for Bug 5804 - duplicate warning when ordering needs design work http://lists.koha-community.org/pipermail/koha-patches/2011-February/013924.... Follow-up fix for Bug 5804, acqui duplicate warning http://lists.koha-community.org/pipermail/koha-patches/2011-February/013946.... Follow-up fix for Bug 5804, acqui duplicate warning http://lists.koha-community.org/pipermail/koha-patches/2011-February/013947.... --- Comment #10 from Chris Cormack <chris@bigballofwax.co.nz> 2011-03-05 19:39:10 UTC --- Follow up patch needs signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5804 --- Comment #11 from Nicole C. Engard <nengard@gmail.com> 2011-03-06 14:16:55 UTC --- Does it? I tried to apply and test and it says it's already applied: Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all y Applying: Follow-up fix for Bug 5804, acqui duplicate warning Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... No changes -- Patch already applied. nengard@debian:~/kohaclone$ -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5804 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Patch Status|Needs Signoff |Patch Pushed Resolution| |FIXED --- Comment #12 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-03-07 07:31:03 UTC --- Has been pushed already. Tested and closed. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org