[Bug 36534] New: Batch operations when using limit in report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36534 Bug ID: 36534 Summary: Batch operations when using limit in report Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Reports Assignee: koha-bugs@lists.koha-community.org Reporter: mikko.liimatainen@turku.fi QA Contact: testopia@bugs.koha-community.org When running a report with defined limit larger than 20, batch operations reads "Batch operations with 20 visible records" even though more records are visible. However when doing a batch operation it is done to all visible records. To reproduce: 1. Create a report of items with a limit of over 20 2. Run report 3. See that number of results shown exceeds 20 4. Dropdown reads "Batch operations with 20 visible records" 5. Start Batch item modification 6. Batch modification opens with all visible records -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36534 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@libriotech.no --- Comment #1 from Magnus Enger <magnus@libriotech.no> --- Confirmed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36534 Katariina Pohto <trainee@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |trainee@koha-suomi.fi Assignee|koha-bugs@lists.koha-commun |trainee@koha-suomi.fi |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36534 --- Comment #2 from Katariina Pohto <trainee@koha-suomi.fi> --- Created attachment 166068 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166068&action=edit Bug 36534: Batch operations when using limit in report The issue appears also outside of using the SQL limit. The last page of results is usually smaller than the results-per-page setting, but the link for batch operations will show the results-per-page limit in that case too. The batch operations will open with all visible records, and the page already has a variable for visible records. This patch changes the variable to the visible records one. Test plan: 1) Create a report of items with a limit of e.g., 26. 2) Run report. 3) See that number of results shown exceeds 20 but the link says "Batch operations with 20 visible records". 4) See that the second page shows 6 results but the link is still for 20 records. 5) Apply patch. 6) Run report again. 7) See that the link texts will show correctly 26 records on the first page and 6 records on the second. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36534 Katariina Pohto <trainee@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36534 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36534 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166068|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 166154 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166154&action=edit Bug 36534: Batch operations when using limit in report When report results number exceeds the result per page limit, batch operations link reads "Batch operations with (page limit) records" even if there are more or less shown records (more when using limit in SQL or less in the last page of result). This patch fixes the link text to actual shown records. To test: 1) Create a report of items with a limit of e.g., 26. 2) Run report. 3) See that number of results shown exceeds 20 but the link says "Batch operations with 20 visible records". 4) See that the second page shows 6 results but the link is still for 20 records. 5) Apply patch. 6) Run report again. 7) See that the link texts will show correctly 26 records on the first page and 6 records on the second. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36534 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36534 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166154|0 |1 is obsolete| | --- Comment #4 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 166403 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166403&action=edit Bug 36534: Batch operations when using limit in report When report results number exceeds the result per page limit, batch operations link reads "Batch operations with (page limit) records" even if there are more or less shown records (more when using limit in SQL or less in the last page of result). This patch fixes the link text to actual shown records. To test: 1) Create a report of items with a limit of e.g., 26. 2) Run report. 3) See that number of results shown exceeds 20 but the link says "Batch operations with 20 visible records". 4) See that the second page shows 6 results but the link is still for 20 records. 5) Apply patch. 6) Run report again. 7) See that the link texts will show correctly 26 records on the first page and 6 records on the second. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36534 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36534 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36534 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00 |24.05.00,23.11.06 released in| | Status|Pushed to main |Pushed to stable CC| |fridolin.somers@biblibre.co | |m --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36534 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00,23.11.06 |24.05.00,23.11.06,23.05.12 released in| | CC| |lucas@bywatersolutions.com Status|Pushed to stable |Pushed to oldstable --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 23.05.x for upcoming 23.05.12 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36534 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED --- Comment #8 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org