[Bug 7069] New: Javascript errors in tags/review
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7069 Bug #: 7069 Summary: Javascript errors in tags/review Classification: Unclassified Change sponsored?: --- Product: Koha Version: rel_3_6 Platform: All OS/Version: All Status: NEW Severity: major Priority: PATCH-Sent Component: Tools AssignedTo: gmcharlt@gmail.com ReportedBy: pelletiermaxime@gmail.com QAContact: koha-bugs@lists.koha-community.org Created attachment 5992 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5992 patch to fix The strings are in ', so there's an error when the translated strings have ' in them. Using " instead fixes the problem. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7069 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-10-19 20:13:26 UTC --- Hi Maxime, only a short note for your next patch - please include the bug number in your subject line! I will fix it for this one when signing off. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7069 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5992|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-10-19 20:20:36 UTC --- Created attachment 6000 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6000 [SIGNED-OFF] Bug 7069: Put strings in "" instead of '' to fix the javascript not working when the translated string has a ' in it. http://bugs.koha-community.org/show_bug.cgi?id=7069 Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Patch changes '' to "" to make it work for strings which contain '. Patch does NOT add new strings to the po files. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7069 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|--- |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7069 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6000|0 |1 is obsolete| | --- Comment #3 from Paul Poulain <paul.poulain@biblibre.com> 2011-10-21 16:48:03 UTC --- Created attachment 6021 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6021 Bug 7069: Put strings in "" instead of '' to fix the javascript not working when the translated string has a ' in it. http://bugs.koha-community.org/show_bug.cgi?id=7069 Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Patch changes '' to "" to make it work for strings which contain '. Patch does NOT add new strings to the po files. Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7069 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |paul.poulain@biblibre.com Patch Status|Signed Off |Passed QA --- Comment #4 from Paul Poulain <paul.poulain@biblibre.com> 2011-10-21 16:48:39 UTC --- QA comment : trivial patch, no problem detected -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7069 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Passed QA |Patch Pushed --- Comment #5 from Paul Poulain <paul.poulain@biblibre.com> 2011-11-04 07:07:29 UTC --- Patch pushed, please test (my 1st push!!!) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7069 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #6 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This was included in the 3.6 branch prior to 3.6.4. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org