[Bug 30971] New: Recalls - log viewer error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30971 Bug ID: 30971 Summary: Recalls - log viewer error Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: david@davidnind.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com There is an error in the log viewer when displaying the recalls logs on the screen (exporting to a file works though): Template process failed: undef error - The method Koha::Recall->biblionumber is not covered by tests! Trace begun at /kohadevbox/koha/Koha/Object.pm line 875 Koha::Object::AUTOLOAD('Koha::Recall=HASH(0x55da45a77358)') called at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt line 385 eval {...} at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt line 385 eval {...} at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt line 409 eval {...} at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt line 18 Template::Provider::__ANON__('Template::Context=HASH(0x55da45d16528)') called at /usr/lib/x86_64-linux-gnu/perl5/5.32/Template/Document.pm line 163 eval {...} at /usr/lib/x86_64-linux-gnu/perl5/5.32/Template/Document.pm line 161 Templ ..... To replicate: 1. Enable recalls: set UseRecalls system preference to 'Use'. 2. Ensure the RecallsLog system preference is set to 'Log'. 3. Setup recalls circulation and fines rules: . Recalls allowed (total) = 5 . Recalls per record (count) = 2 . On shelf recalls allowed = 'If any unavailable' . Recall due date interval (day) = 3 . Recall overdue fine amount = 5 . Recall pickup period (day) = 2 4. Checkout an item to a patron: - Patron used: Mary Burton (Midway) - Record used: Programming Perl (biblionumber = 262, one item = 39999000011418, home library = Centerville) 5. Change username/password for a patron and login to the OPAC and place a recall for the item in step 4. - Patron used: Henry Acevedo (Midway) 6. View the checkout and details tab for patron used in step 4: . List of checkouts should display correctly . Message in the title column for the item with a recall: This item has been recalled and the due date updated. 7. Go to Tools > Log viewer and press submit (can limit the module to just Recalls if you wish). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30971 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29734 See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30907 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29734 [Bug 29734] [OMNIBUS] Recalls for Koha -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30971 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30971 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30971 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 136118 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136118&action=edit Bug 30971: Recalls log viewer error This patch addresses the itemnumber and biblionumber attributes for recalls having been renamed. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30971 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 136119 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136119&action=edit Bug 30971: (follow-up) Fix one more occurence To test: 1. Run: $ git grep 'recall.itemnumber' => SUCCESS: No more occurences 2. Run: $ git grep 'recall.biblionumber' => SUCCESS: No more occurences 3. Run: $ git grep 'recall\->biblionumber' => SUCCESS: No more occurences 4. Run: $ git grep 'recall\->itemnumber' => FAIL: One standing occurence 5. Apply this patch 6. Repeat 4 => SUCCESS: No more occurences 7. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30971 --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 136120 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136120&action=edit Bug 30971: (follow-up) Fix recall.branchcode occurences This fixes a couple cases actually. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30971 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30971 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136118|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 136121 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136121&action=edit Bug 30971: Recalls log viewer error This patch addresses the itemnumber and biblionumber attributes for recalls having been renamed. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30971 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136119|0 |1 is obsolete| | --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 136122 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136122&action=edit Bug 30971: (follow-up) Fix one more occurence To test: 1. Run: $ git grep 'recall.itemnumber' => SUCCESS: No more occurences 2. Run: $ git grep 'recall.biblionumber' => SUCCESS: No more occurences 3. Run: $ git grep 'recall\->biblionumber' => SUCCESS: No more occurences 4. Run: $ git grep 'recall\->itemnumber' => FAIL: One standing occurence 5. Apply this patch 6. Repeat 4 => SUCCESS: No more occurences 7. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30971 --- Comment #6 from David Nind <david@davidnind.com> --- Thanks Tomás! There are no more occurrences of the git grep queries after the patches are applied, and the log viewer now works for recalls. David -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30971 --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to David Nind from comment #6)
Thanks Tomás!
There are no more occurrences of the git grep queries after the patches are applied, and the log viewer now works for recalls.
David
David, thanks to you. I also did this: Generated a 'recalls' file: $ cat recalls borrowernumber recalldate biblionumber branchcode cancellationdate recallnotes itemnumber waitingdate expirationdate old item_level_recall and then: $ for i in $(cat ~/recalls) ; do \ git grep "recall\.$i" | grep -v translator; \ git grep "recall\->$i" | grep -v translator; \ done And no more results. Chances are that in some places variables could've been named differently. Hopefully QA didn't allow that :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30971 --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to David Nind from comment #6)
Thanks Tomás!
There are no more occurrences of the git grep queries after the patches are applied, and the log viewer now works for recalls.
David
You missed one of the patches to SO -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30971 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136120|0 |1 is obsolete| | --- Comment #9 from David Nind <david@davidnind.com> --- Created attachment 136123 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136123&action=edit Bug 30971: (follow-up) Fix recall.branchcode occurences This fixes a couple cases actually. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> https://bugs.koha-community.org/show_bug.cgi?id=30917 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30971 --- Comment #10 from David Nind <david@davidnind.com> --- (In reply to Tomás Cohen Arazi from comment #8)
You missed one of the patches to SO
I was too quick! Now signed off as well. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30971 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136121|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136139 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136139&action=edit Bug 30971: Recalls log viewer error This patch addresses the itemnumber and biblionumber attributes for recalls having been renamed. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30971 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136122|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136140 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136140&action=edit Bug 30971: (follow-up) Fix one more occurence To test: 1. Run: $ git grep 'recall.itemnumber' => SUCCESS: No more occurences 2. Run: $ git grep 'recall.biblionumber' => SUCCESS: No more occurences 3. Run: $ git grep 'recall\->biblionumber' => SUCCESS: No more occurences 4. Run: $ git grep 'recall\->itemnumber' => FAIL: One standing occurence 5. Apply this patch 6. Repeat 4 => SUCCESS: No more occurences 7. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30971 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136123|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136141 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136141&action=edit Bug 30971: (follow-up) Fix recall.branchcode occurences This fixes a couple cases actually. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30971 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize@ptfs-europe | |.com --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- All works as expected now, thanks for following through on all this Tomas. PQA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30971 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30971 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30971 --- Comment #15 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30971 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_22_05_candidate CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30971 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00 |22.11.00, 22.05.01 released in| | Status|Pushed to master |Pushed to stable --- Comment #16 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 22.05.x for 22.05.01 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30971 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes an error that release notes| |occurred when viewing | |recalls log entries. The | |error was caused by the | |renaming of itemnumber, | |biblionumber, and | |branchcode attributes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30971 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_22_05_candidate | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org