https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12388 --- Comment #13 from Emmi Takkinen <emmi.takkinen@outlook.com> --- (In reply to Joonas Kylmälä from comment #12)

Hi,

the tests didn't remove/replace the now unneeded code under the comments

...

# Set timestamps to the same value to avoid a different order Hmm, sure, I guess there's no point to adjust timestamp anymore since we sort result from pending_checkouts by date_due. So those code lines can be removed.

Also the test cases now only test sorting with issue date, not by date due. Testing of date due sorting should be added to cover this change fully. Sorry, I don't fully understand what you mean by this. I don't see any test where we specially test sorting with issue date. However every test expects output to have issues in correct order and that includes having correct date due value.

-- You are receiving this mail because: You are watching all bug changes.