[Bug 10497] New: star ratings not showing right in ccsr detail
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10497 Bug ID: 10497 Summary: star ratings not showing right in ccsr detail Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: nengard@gmail.com Created attachment 19162 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19162&action=edit site without custom css On the detail page in ccsr the star ratings are either showing as radio buttons (on my custom css) or as nothing at all (on my site without custom css). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10497 --- Comment #1 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 19163 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19163&action=edit site with custom css -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10497 Ed Veal <ed.veal@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ed.veal@bywatersolutions.co | |m --- Comment #2 from Ed Veal <ed.veal@bywatersolutions.com> --- This is also an issue with the results page. I checked the code and the star on the results page is not showing because it is looking for "../../images/star-ratings-sprite.png" and the image is not present there. Regarding the details page and the start rating. It appears that there is no css for the ratings for the ccsr theme. Ed -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10497 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10497 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 19277 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19277&action=edit Bug 10497 - star ratings not showing right in ccsr detail Star ratings do not appear correctly in the CCSR theme because it lacks the image sprite used to display them. This patch adds the required file. To test, apply the patch and view a search results set which includes titles which have an existing rating. Ratings should appear correctly. View a detail page for an title which has a rating, and add a rating to a title which has no rating. Ratings should look correct and work correctly. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10497 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19277|0 |1 is obsolete| | --- Comment #4 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 19280 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19280&action=edit [SIGNED-OFF] Bug 10497 - star ratings not showing right in ccsr detail -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10497 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10497 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Nicole, please remember to tick the 'patch' checkbox when uploading a patch manually. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10497 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19280|0 |1 is patch| | Attachment #19280|application/mbox |text/plain mime type| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10497 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10497 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19280|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 19295 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19295&action=edit [PASSED QA] Bug 10497 - star ratings not showing right in ccsr detail Star ratings do not appear correctly in the CCSR theme because it lacks the image sprite used to display them. This patch adds the required file. To test, apply the patch and view a search results set which includes titles which have an existing rating. Ratings should appear correctly. View a detail page for an title which has a rating, and add a rating to a title which has no rating. Ratings should look correct and work correctly. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> All tests pass - including leaving a rating on the newly visible stars Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> In order to test this, make sure you have set OpacStarRatings set to 'results and details'. The star images show up in OPAC results with the correct amount of stars after applying the patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10497 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10497 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #7 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10497 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen@gmail.com --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This patch has been pushed to 3.12.x, will be in 3.12.2. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10497 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com --- Comment #9 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Pushed to 3.10.x, will be in 3.10.10 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10497 Chris Hall <chrish@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chrish@catalyst.net.nz --- Comment #10 from Chris Hall <chrish@catalyst.net.nz> --- Pushed to 3.8.x, will be in 3.8.17 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org