[Bug 14923] New: Remove C4::Dates from labels/label-item-search.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14923 Bug ID: 14923 Summary: Remove C4::Dates from labels/label-item-search.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: veron@veron.ch QA Contact: testopia@bugs.koha-community.org This patch removes C4::Dates from labels/label-item-search.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14923 --- Comment #1 from Marc Véron <veron@veron.ch> --- Created attachment 42952 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42952&action=edit Bug 14923 - Remove C4::Dates from labels/label-item-search.pl This patch removes C4::Dates from labels/label-item-search.pl To test: - Go to Home > Tools > Labels home > Manage label batches - Click "Add item(s)" - Verify that selection with date after and date before works the same as without patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14923 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14870 Status|NEW |Needs Signoff Assignee|gmcharlt@gmail.com |veron@veron.ch Patch complexity|--- |Trivial patch Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 [Bug 14870] Delete C4/Dates.pm from System -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14923 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42952|0 |1 is obsolete| | --- Comment #2 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 42960 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42960&action=edit [SIGNED-OFF]Bug 14923 - Remove C4::Dates from labels/label-item-search.pl This patch removes C4::Dates from labels/label-item-search.pl To test: - Go to Home > Tools > Labels home > Manage label batches - Click "Add item(s)" - Verify that selection with date after and date before works the same as without patch. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised. C4::Dates is deprecated according to Coding Guidelines Wiki. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14923 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |hector.hecaxmmx@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14923 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|Signed Off |Failed QA --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Marc, sorry but I get a software error if the date is not correctly formatted. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14923 --- Comment #4 from Marc Véron <veron@veron.ch> --- Created attachment 43030 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43030&action=edit Bug 14923 - (follow-up) Test for invalid date input See comment #3 To test: - Make sure that you test on top of Bug 14936 (Add validation for date strings to Koha::DateUtils - Apply patch - Go to Home > Tools > Labels home > Manage label batches - Click "Add item(s)" - Verify that selection with date after and date before works the same as without patch. - Verify that you can not trigger a software error using invalid dates as 0000-00-00 or 32/01/1970 (copy/paste to date fields). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14923 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14936 Patch complexity|Trivial patch |Small patch Status|Failed QA |Needs Signoff Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14936 [Bug 14936] Add validation for date strings to Koha::DateUtils -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14923 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |BLOCKED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14923 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch --- Comment #5 from Marc Véron <veron@veron.ch> --- Comment on attachment 43030 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43030 Bug 14923 - (follow-up) Test for invalid date input Obsoleted to implement solution without using is_formatted_date_string -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14923 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43030|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14923 --- Comment #6 from Marc Véron <veron@veron.ch> --- Created attachment 43064 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43064&action=edit Bug 14923 - (follow up) Add test for invalid dates using eval To test: - Apply patch - Go to Home > Tools > Labels home > Manage label batches - Click "Add item(s)" - Verify that selection with date after and date before works the same as without patch. - Verify that you can not trigger a software error using invalid dates as 0000-00-00 or 32/01/1970 (copy/paste to date fields). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14923 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Needs Signoff Depends on|14936 | Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14936 [Bug 14936] Add validation for date strings to Koha::DateUtils -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14923 Joonas Kylmälä <j.kylmala@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |j.kylmala@gmail.com Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14923 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43064|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14923 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42960|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14923 --- Comment #7 from Marc Véron <veron@veron.ch> --- I re-do the patch from scratch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14923 --- Comment #8 from Marc Véron <veron@veron.ch> --- Created attachment 43139 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43139&action=edit Bug 14923 - Remove C4::Dates from labels/label-item-search.pl This patch removes C4::Dates from labels/label-item-search.pl To test: - Go to Home > Tools > Labels home > Manage label batches - Click "Add item(s)" - Verify that selection with date after and date before works the same as without patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14923 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14923 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43139|0 |1 is obsolete| | --- Comment #9 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 43145 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43145&action=edit [SIGNED-OFF]Bug 14923 - Remove C4::Dates from labels/label-item-search.pl This patch removes C4::Dates from labels/label-item-search.pl To test: - Go to Home > Tools > Labels home > Manage label batches - Click "Add item(s)" - Verify that selection with date after and date before works the same as without patch. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised. Tested with bad dates -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14923 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14923 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14923 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43145|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 43154 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43154&action=edit Bug 14923 - Remove C4::Dates from labels/label-item-search.pl This patch removes C4::Dates from labels/label-item-search.pl To test: - Go to Home > Tools > Labels home > Manage label batches - Click "Add item(s)" - Verify that selection with date after and date before works the same as without patch. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised. Tested with bad dates Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Todo later: Some checks should be added on client side. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14923 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #11 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Marc! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14923 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14975 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14923 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14975 | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org