[Bug 26926] New: Update all occurrences of <input type="number"> to apply ACC2 coding guideline
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26926 Bug ID: 26926 Summary: Update all occurrences of <input type="number"> to apply ACC2 coding guideline Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org Retroactively apply ACC2 coding guideline We need to update all `input type="number"` occurrences to use `<input type="text" inputmode="numeric" pattern="[0-9]*">` as per the new accessibility guideline. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26926 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bolshawh@parliament.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26926 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_21_05_candidate CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26926 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23003 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23003 [Bug 23003] Accessibility improvements -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26926 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This bug split into multiple might make a good Academy task? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26926 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27290 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27290 [Bug 27290] Cash register allows for 'amount tendered' less than amount being paid -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26926 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27404 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27404 [Bug 27404] Update intranet-tmpl/prog/en/modules/labels/label-edit-range.tt for ACC2 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26926 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27405 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27405 [Bug 27405] Update intranet-tmpl/prog/en/modules/pos/register.tt for ACC2 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26926 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27406 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27406 [Bug 27406] Update intranet-tmpl/prog/en/modules/admin/searchengine/elasticsearch/mappings.tt to adhere to ACC2 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26926 --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Katrin Fischer from comment #1)
This bug split into multiple might make a good Academy task?
Done -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26926 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27407 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27407 [Bug 27407] Update intranet-tmpl/prog/en/modules/reserve/request.tt for ACC2 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26926 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27408 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27408 [Bug 27408] Update intranet-tmpl/prog/en/modules/members/mancredit.tt for ACC2 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26926 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27409 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27409 [Bug 27409] Update intranet-tmpl/prog/en/modules/members/boraccount.tt for ACC2 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26926 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27410 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27410 [Bug 27410] Update intranet-tmpl/prog/en/modules/members/maninvoice.tt to reflect ACC2 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26926 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27411 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27411 [Bug 27411] Update intranet-tmpl/prog/en/modules/tools/automatic_item_modification_by_age.tt to reflect ACC2 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26926 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27412 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27412 [Bug 27412] Update intranet-tmpl/prog/en/modules/tools/overduerules.tt to adhere to ACC2 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26926 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Update all occurrences of |Omnibus: Update all |<input type="number"> to |occurrences of <input |apply ACC2 coding guideline |type="number"> to apply | |ACC2 coding guideline CC| |aleisha@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26926 --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- https://wiki.koha-community.org/wiki/Coding_Guidelines#ACC2:_Input_type_.22n... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26926 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |https://wiki.koha-community | |.org/wiki/Coding_Guidelines | |#ACC2:_Input_type_.22number | |.22_should_be_avoided -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26926 Catherine <catherinem2003@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |catherinem2003@gmail.com Assignee|koha-bugs@lists.koha-commun |catherinem2003@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26926 Catherine <catherinem2003@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|catherinem2003@gmail.com |koha-bugs@lists.koha-commun | |ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26926 Eden <eden.bacani@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eden.bacani@gmail.com Assignee|koha-bugs@lists.koha-commun |eden.bacani@gmail.com |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26926 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26926 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #4 from David Nind <david@davidnind.com> --- Owen Leonard updated Bug 27408 and Bug 27410 for currency strings, and I've updated Bug 27405: - inputmode changed to "decimal" - regex pattern changed to "^\d+(\.\d{2})?$" as found in admin/debit_types.tt "The regex validating the modified field doesn't allow for currency-formatted values like "1.00" because of the dot." -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26926 --- Comment #5 from Henry Bolshaw <bolshawh@parliament.uk> --- I think all of these occurrences have been fixed now. Is that correct? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26926 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28134 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28134 [Bug 28134] Replace use of input type number in onboarding templates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26926 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28135 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28135 [Bug 28135] Replace use of input type number in onboarding templates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26926 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Henry Bolshaw from comment #5)
I think all of these occurrences have been fixed now. Is that correct?
I think Bug 28134 and 28135 are the last. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26926 Henry Bolshaw <bolshawh@parliament.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |accessibility -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26926 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|Academy | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26926 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28283 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28283 [Bug 28283] `Quantity received` should have inputmode="numeric" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26926 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Keywords|rel_21_05_candidate | Status|NEW |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org