[Bug 12495] New: Street number missing from hold alert on checkin page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12495 Bug ID: 12495 Summary: Street number missing from hold alert on checkin page Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: david.roberts@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com When an item with a hold is checked in, the "hold found" alert does not display the street number. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12495 --- Comment #1 from David Roberts <david.roberts@ptfs-europe.com> --- Created attachment 29378 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29378&action=edit Proposed patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12495 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Please don't forget to assign bugs to yourself if you are supplying a patch. If the patch is ready for testing the status of the bug should be changed to "needs signoff." A patch which is ready for testing should include a test plan in the commit message. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12495 David Roberts <david.roberts@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |david.roberts@ptfs-europe.c |ity.org |om --- Comment #3 from David Roberts <david.roberts@ptfs-europe.com> --- To test this, place a hold on an item that is on-loan, having first made sure that the requesting user has a value in the street number field of his address. Check the item in, and an alert should appear giving the name and address of the requesting user. This address should include the contents of the street number address field. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12495 --- Comment #4 from David Roberts <david.roberts@ptfs-europe.com> --- (In reply to Owen Leonard from comment #2)
Please don't forget to assign bugs to yourself if you are supplying a patch. If the patch is ready for testing the status of the bug should be changed to "needs signoff." A patch which is ready for testing should include a test plan in the commit message.
Sorry - I'm new to this! :-) Hope everything is OK now. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12495 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12495 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29378|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 29380 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29380&action=edit [SIGNED-OFF] Bug 12495 - Include streetnumber in hold alert address Steetnumber is not included in the addess in the hold alert add the field to those displayed To test this, place a hold on an item that is on-loan, having first made sure that the requesting user has a value in the street number field of his address. Check the item in, and an alert should appear giving the name and address of the requesting user. This address should include the contents of the street number address field. Signed-off-by: Owen Leonard <oleonard@myacpl.org> I was able to confirm three of the four template changes for the following cases: - Item placed on hold for a patron at the current library, not waiting - Item placed on hold for a patron at the current library, already waiting - Item placed on hold for a patron at another library, not waiting I don't know how to trigger the case [% IF ( diffbranch ) %]. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12495 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12495 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12495 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29380|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 29526 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29526&action=edit [PASSED QA] Bug 12495 - Include streetnumber in hold alert address Steetnumber is not included in the addess in the hold alert add the field to those displayed To test this, place a hold on an item that is on-loan, having first made sure that the requesting user has a value in the street number field of his address. Check the item in, and an alert should appear giving the name and address of the requesting user. This address should include the contents of the street number address field. Signed-off-by: Owen Leonard <oleonard@myacpl.org> I was able to confirm three of the four template changes for the following cases: - Item placed on hold for a patron at the current library, not waiting - Item placed on hold for a patron at the current library, already waiting - Item placed on hold for a patron at another library, not waiting I don't know how to trigger the case [% IF ( diffbranch ) %]. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes QA script and tests. Note: Maybe sample slip templates should also include street number? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12495 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi David, I believe this is your first patch - thanks and congratulations :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12495 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12495 --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks, and congratulations David! Note: a discussion on how to compose addresses with different naming schemas (a.k.a. 'localized') is in place, but belongs to another bug. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12495 --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 34902 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34902&action=edit Bug 12495 [QA Followup] - Re-work "Renew or return" button as well -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12495 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34902|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 34903 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34903&action=edit Bug 12495 [QA Followup] - Re-work "Renew or return" button as well -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12495 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34903|0 |1 is obsolete| | CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12495 --- Comment #11 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 34904 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34904&action=edit Bug 12495 [QA Followup] - Re-word "Renew or return" button as well -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12495 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34904|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org