[Bug 26539] New: Inconsistent case sensitivity around patron attribute code - potential data loss
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26539 Bug ID: 26539 Summary: Inconsistent case sensitivity around patron attribute code - potential data loss Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com To recreate: 1 - have a patron attribute with code "TEST" 2 - using import_borrowers.pl, import a patron with "test:1" in the patron_attributes field of your CSV 3 - load your patron, confirm the value of 1 shows on moremember.pl 4 - click to edit your patron, confirm the value of 1 does not show on memberentry.pl 5 - query the database, SELECT * from borrower_attributes where borrowernumber=[your borrower], see code="test" 6 - update the database, UPDATE borrower_attributes set code="TEST" where id=[your attribute id] 7 - reload memberentry.pl, it now shows a 1 Back at step 4, if we'd saved our patron, that value would have been lost -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26539 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- What is the expected behaviour here? I'd say we should print an error if you try to load a patron record with non-existing patron attribute codes. And maybe a note on the patron import page about the use of codes? What do you think? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26539 --- Comment #2 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- If possible, I'd like them to just not be case sensitive at all. We don't generally expect users to have to worry about case on things. Just about the only place in the staff interface where we make them interact with code values is in reports and SQL isn't case sensitive. So that'd mean making memberentry.pl fetch and display those values regardless of case. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26539 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, yeah, that could also work. I was worried before libraries might have added both cases, but I think we catch that in the extended attributes GUI? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26539 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 111523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111523&action=edit Bug 26539: Display patron's attributes without case sensitivity -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26539 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Version|19.11 |master Status|NEW |In Discussion --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- This patch will fix the original issue, but I'd like to be sure it is what we really want here. If we go this way we will certainly need to adjust the batch mod patrons tool as well. Maybe we should fix the case when the attribute is stored instead. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26539 Patrick Robitaille <patrick.robitaille@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille@collecto | |.ca -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org