http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11579 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 24509 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24509&action=edit Bug 11579: Show ordernumber in basket.pl tables Test plan: Verify the ordernumber is correctly displayed on the basket page (acqui/basket.pl?basketno=X) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11579 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes@biblibre.com --- Comment #2 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by silvere <silvere.hanguehard@enc.sorbonne.fr> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11579 --- Comment #3 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 24651 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24651&action=edit Bug 11056: Delete dead code in basketgroup.pl In basketgroup.pl, some code is supposed to be executed if $op = "validate". But this value is no longer assigned to the $op variable since 2009. This patch suppressed dead code, along with parseinputbaskets and parseinputbasketgroups subs, which are obsolete. No functional changes expected Regression test : * Check basketgroup are shown as before the patch, and can be closed and reopened. * Check you can add or remove a basket from a basketgroup, and change information about it (like delivery place) * Check you can create a basketgroup when you close a basket. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> The following commands return nothing: - grep validate acqui/basketgroup.tt - grep -R basketgroup.pl -C 2 | grep validate - git grep parseinputbaskets - git grep parseinputbasketgroups - git grep basketgroup.pl | grep validate Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: silvere <silvere.hanguehard@enc.sorbonne.fr> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11579 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24651|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11579 --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- Sylvère has tested the patch in a sandbox but he applied it yesterday and signed off it today. Meanwhile the sandbox has been reset to master, so the master HEAD has been uploaded. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11579 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24652|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 24726 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24726&action=edit [PASSED QA] Bug 11579: Show ordernumber in basket.pl tables Test plan: Verify the ordernumber is correctly displayed on the basket page (acqui/basket.pl?basketno=X) Signed-off-by: silvere <silvere.hanguehard@enc.sorbonne.fr> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Fixed a tiny typo in the HTML: </th> > </td>. Passes all tests and QA script. Tested that the ordernumber is now displayed and table sorting works for the smaller and more detailed table. -- You are receiving this mail because: You are watching all bug changes.