[Bug 36141] New: Add classes to CAS text on OPAC login page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36141 Bug ID: 36141 Summary: Add classes to CAS text on OPAC login page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: fridolin.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org Like Bug 35147 for Shibboleth, add classes to CAS authentication on OPAC to make it easier to customize. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36141 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |35147 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35147 [Bug 35147] Add classes to Shibboleth text on OPAC login page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36141 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |fridolin.somers@biblibre.co | |m Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36141 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36141 --- Comment #1 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 162315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162315&action=edit Bug 36141 - Add classes to CAS text on OPAC login page This enhancement makes it easier for libraries to change the CAS-related messages on the OPAC login page. It moved the invalid CAS login message above the CAS loging heading, like for Shibboleth login. Test plan : 1) Enable system preference 'casAuthentication' 2) Restart all caches (restart_all in koha-testing-docker) 3) Go to OPAC, logged out 4) Click on 'Log in to your account' 5) In the staff interface, edit the OPACUserJS system preference. Add the following JS and Save: $(".cas_invalid").text("Test changing the invalid CAS login message."); $(".cas_title").text("Test changing the CAS login heading."); $(".cas_url").text("Test changing the CAS account link text."); $(".cas_url").after(' <i class="fa fa-globe" aria-hidden="true"></i>'); 6) Refresh the OPAC and confirm the text changes to reflect your JS. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36141 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36141 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162315|0 |1 is obsolete| | --- Comment #2 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 166676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166676&action=edit Bug 36141 - Add classes to CAS text on OPAC login page This enhancement makes it easier for libraries to change the CAS-related messages on the OPAC login page. It moved the invalid CAS login message above the CAS loging heading, like for Shibboleth login. Test plan : 1) Enable system preference 'casAuthentication' 2) Restart all caches (restart_all in koha-testing-docker) 3) Go to OPAC, logged out 4) Click on 'Log in to your account' 5) In the staff interface, edit the OPACUserJS system preference. Add the following JS and Save: $(".cas_invalid").text("Test changing the invalid CAS login message."); $(".cas_title").text("Test changing the CAS login heading."); $(".cas_url").text("Test changing the CAS account link text."); $(".cas_url").after(' <i class="fa fa-globe" aria-hidden="true"></i>'); 6) Refresh the OPAC and confirm the text changes to reflect your JS. Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36141 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- What about these messages? -If you have a CAS account, you may use that below. -If you have a CAS account, please choose against which one you would like to authenticate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36141 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Picking an easy one out of the QA queue for main. Fixed inline: * Commit title does not start with 'Bug XXXXX: ' - b62a82e347d -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36141 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36141 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36141 --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> ---
Fixed inline: * Commit title does not start with 'Bug XXXXX: ' - b62a82e347d
Oups I did it again :D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36141 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.11.00 |24.11.00,24.05.02 released in| | Status|Pushed to main |Pushed to stable --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 24.05.x for upcoming 24.05.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36141 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.11.00,24.05.02 |24.11.00,24.05.02,23.11.07 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.07 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36141 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement adds release notes| |classes to the CAS-related | |messages on the OPAC login | |page. This will make it | |easier for libraries to | |customize using CSS and | |JavaScript. The new classes | |are cas_invalid, cas_title, | |and cas_url. It also moves | |the invalid CAS login | |message to above the CAS | |login heading (the same as | |for the Shibboleth login). CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36141 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #9 from wainuiwitikapark@catalyst.net.nz --- Not backporting to 23.05.x unless requested -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36141 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Needs documenting -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36141 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED CC| |caroline.cyr-la-rose@inlibr | |o.com --- Comment #10 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Internal architecture, nothing to add/edit in the manual. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org