[Bug 5881] New: CSV export : deal with control fields to avoid an error (C4/Record.pm)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5881 Bug #: 5881 Summary: CSV export : deal with control fields to avoid an error (C4/Record.pm) Classification: Unclassified Change sponsored?: --- Product: Koha Version: rel_3_4 Platform: All OS/Version: All Status: NEW Severity: normal Priority: P5 Component: Tools AssignedTo: gmcharlt@gmail.com ReportedBy: chris@bigballofwax.co.nz QAContact: koha-bugs@lists.koha-community.org -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5881 --- Comment #1 from Chris Cormack <chris@bigballofwax.co.nz> 2011-03-16 03:11:47 UTC --- Created attachment 3319 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3319 Proposed Patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5881 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5881 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|gmcharlt@gmail.com |paul.poulain@biblibre.com -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5881 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #3319|0 |1 is obsolete| | --- Comment #2 from MJ Ray (software.coop) <mjr@ttllp.co.uk> 2011-04-02 11:41:24 UTC --- This bug is mentioned in: Bug 5881 : CSV export : deal with control fields to avoid an error (C4/Record.pm) http://lists.koha-community.org/pipermail/koha-patches/2011-March/014076.htm... --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> 2011-05-12 23:27:44 UTC --- Created attachment 4089 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4089 Signed off patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5881 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5881 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4089|0 |1 is obsolete| | --- Comment #4 from Paul Poulain <paul.poulain@biblibre.com> 2011-08-09 14:17:28 UTC --- Created attachment 4907 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4907 proposed patch (passed QA) QA comment This patch is critical in fact : if you try to export a field <010 in CSV export (like 001, or 009), it results in a nasty Perl error, as fields <010 have a specific accessor The only 'usefull' part of this patch is : + # If it is a control field + if ($_->is_control_field) { + $value = defined $authvalues->{$_->as_string} ? $authvalues->{$_->as_string} : $_->as_string; + } else { (the rest is reindenting) I'm not the real author of this patch, it's critical, marking passed QA. Chris, if you object, switch to signed off and bug Ian for another QA checking ! -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5881 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Passed QA Severity|normal |critical -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5881 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Passed QA |Signed Off --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> 2011-08-10 01:10:09 UTC --- As I did the original sign off, Id like to get Ian to take a look at this as well. Just for another pair of eyes. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5881 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ian.walls@bywatersolutions. | |com --- Comment #6 from Ian Walls <ian.walls@bywatersolutions.com> 2011-09-02 13:38:41 UTC --- First off, there is no description of this bug and how to reproduce it. I can only guess as to the nature of the problem. Here's what I've done: 1. on master, create a CSV profile exporting 001 and 245 2. Add an item to cart 3. Download 4. Select CSV profile 5. Open in LibreOffice This does not give me any trouble, so I have to conclude that I cannot reproduce the error. Please provide step by step instructions for reproducing this error, so I can test whether or not the proposed patch actually solves the issue or not. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5881 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |INVALID --- Comment #7 from Paul Poulain <paul.poulain@biblibre.com> 2011-09-05 15:13:59 UTC --- mmm... strange... I can't reproduce the error. I've checked changes in MARC::Record that could explain this (a change in ->as_string behaviour), but couldn't find one. I also have checked C4/Record.pm and can't find a change that explain this bug disappearing. Marking RESO > INVALID -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org