https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26979 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- +1 :) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26979 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 123338 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123338&action=edit Bug 26979: Show correctly-pluralized labels on checkouts page tabs This patch modifies the tabs shown on the checkout and patron detail page so that counts of checkouts, etc. have the correct pluralization. This avoids the use of labels like "Checkout(s)" To test, apply the patch and check out to a patron. - The tabs showing checkouts, holds, claims, etc. should show the correct plural or singular on each label, e.g.: 14 Checkouts 20 Holds 0 Article requests 1 Club - Test that each plural/singular changes appropriately when you add checkouts, holds, clubs, etc. To test translation, apply the patch and test that the correct strings are translatable. In this example I'm testing fr-FR: - Update a translation:

gulp po:update cd misc/translator perl translate update fr-FR

- Open the corresponding .po file for the strings pulled from the templates e.g. misc/translator/po/fr-FR-messages.po - Locate strings pulled from circulation.tt and moremember.tt translation, e.g.: #: koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt:770 msgid "Relatives' checkout" msgid_plural "Relatives' checkouts" msgstr[0] "" msgstr[1] "" - Edit the "msgstr[0]" and "msgstr[1]" strings however you want (it's just for testing) - Install the updated translation:

perl translate install fr-FR

In the staff client, switch to the language you're testing. Confirm that your translated strings appear correctly in singular and plural cases. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26979 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123338|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 123350 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123350&action=edit Bug 26979: Show correctly-pluralized labels on checkouts page tabs This patch modifies the tabs shown on the checkout and patron detail page so that counts of checkouts, etc. have the correct pluralization. This avoids the use of labels like "Checkout(s)" To test, apply the patch and check out to a patron. - The tabs showing checkouts, holds, claims, etc. should show the correct plural or singular on each label, e.g.: 14 Checkouts 20 Holds 0 Article requests 1 Club - Test that each plural/singular changes appropriately when you add checkouts, holds, clubs, etc. To test translation, apply the patch and test that the correct strings are translatable. In this example I'm testing fr-FR: - Update a translation:

gulp po:update cd misc/translator perl translate update fr-FR

- Open the corresponding .po file for the strings pulled from the templates e.g. misc/translator/po/fr-FR-messages.po - Locate strings pulled from circulation.tt and moremember.tt translation, e.g.: #: koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt:770 msgid "Relatives' checkout" msgid_plural "Relatives' checkouts" msgstr[0] "" msgstr[1] "" - Edit the "msgstr[0]" and "msgstr[1]" strings however you want (it's just for testing) - Install the updated translation:

perl translate install fr-FR

In the staff client, switch to the language you're testing. Confirm that your translated strings appear correctly in singular and plural cases. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26979 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This patch set adds a few warns to the logs, but I believe that these will likely appear on other pages using the plural translations: Argument "" isn't numeric in subroutine entry at /usr/local/share/perl/5.24.1/Locale/Messages.pm line 285. Argument "" isn't numeric in subroutine entry at /usr/local/share/perl/5.24.1/Locale/Messages.pm line 285. Argument "" isn't numeric in subroutine entry at /usr/local/share/perl/5.24.1/Locale/Messages.pm line 285. So I am moving them to a separate bug 28877. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26979 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123350|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 123932 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123932&action=edit Bug 26979: Show correctly-pluralized labels on checkouts page tabs This patch modifies the tabs shown on the checkout and patron detail page so that counts of checkouts, etc. have the correct pluralization. This avoids the use of labels like "Checkout(s)" To test, apply the patch and check out to a patron. - The tabs showing checkouts, holds, claims, etc. should show the correct plural or singular on each label, e.g.: 14 Checkouts 20 Holds 0 Article requests 1 Club - Test that each plural/singular changes appropriately when you add checkouts, holds, clubs, etc. To test translation, apply the patch and test that the correct strings are translatable. In this example I'm testing fr-FR: - Update a translation:

gulp po:update cd misc/translator perl translate update fr-FR

- Open the corresponding .po file for the strings pulled from the templates e.g. misc/translator/po/fr-FR-messages.po - Locate strings pulled from circulation.tt and moremember.tt translation, e.g.: #: koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt:770 msgid "Relatives' checkout" msgid_plural "Relatives' checkouts" msgstr[0] "" msgstr[1] "" - Edit the "msgstr[0]" and "msgstr[1]" strings however you want (it's just for testing) - Install the updated translation:

perl translate install fr-FR

In the staff client, switch to the language you're testing. Confirm that your translated strings appear correctly in singular and plural cases. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26979 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #7 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- You must html filter the tn (not raw). -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26979 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30695 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26979 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Hmm, I think I actually prefer the consistency of bug 30695 to the pluralisation this introduces personally.. Example Holds (0) Holds (5) vs 0 Holds 1 Hold 2 Holds Whilst the latter which this introduces is nice enough, given we have the bracketed approach elsewhere fairly consistently I currently prefer that for wider consistency.. I also feel that works better with the (X/Y) approaches (though the `([X] [Y])` block does make me wince a little) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26979 --- Comment #9 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Martin Renvoize from comment #8)

Hmm, I think I actually prefer the consistency of bug 30695 to the pluralisation this introduces personally..

Example

Holds (0) Holds (5)

vs

0 Holds 1 Hold 2 Holds

Whilst the latter which this introduces is nice enough, given we have the bracketed approach elsewhere fairly consistently I currently prefer that for wider consistency.. I also feel that works better with the (X/Y) approaches (though the `([X] [Y])` block does make me wince a little)

It would be interesting to have end-user's opinions on that. You certainly prefer "Holds (X)" because of your developer's brain :D -- You are receiving this mail because: You are watching all bug changes.