[Bug 26479] New: Self checkout: option for returning items is missing with SCOAllowCheckin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26479 Bug ID: 26479 Summary: Self checkout: option for returning items is missing with SCOAllowCheckin Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Self checkout Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org When returning items from the self checkout screens is allowed, there is no link to do so in GUI. It looks like the table of checkouts should have a return item link in the manual, but there is only a renew link visible https://koha-community.org/manual/20.05/en/html/circulation.html#self-checko... To test: - Activate WebBasedSelfCheck and SCOAllowCheckin - Go to the self checkout in OPAC - Check an item out - Verify there is only a renew link and no visible option to return it -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26479 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com --- Comment #1 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Seems like this may relate to Bug 25147? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26479 Oliver Behnke <oliver.behnke@aei.mpg.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oliver.behnke@aei.mpg.de --- Comment #2 from Oliver Behnke <oliver.behnke@aei.mpg.de> --- @Andrew, it doesn't since SCOAllowCheckin is already the renamed setting. Anyhow, I'd like to bump this up again as I just came across this issue in Koha 24.05.01 - after using this feature for years. Unfortunately, I don't know when exactly this did start to occur. And, interestingly, it only affects some users... Will report back when I know more... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26479 --- Comment #3 from Oliver Behnke <oliver.behnke@aei.mpg.de> --- My issue was caused by a recent regression. See bug 37525. That said, I agree that the UX is not as intuitive as it could be. When you allow "SCOAllowCheckin" this enables multiple buttons to "Return" or "Check in" an item. The one you're missing is the "Check in" button in the "Renew" column of the "Checkouts" table (on the main SCO page). That's only visible for items that cannot be renewed. To lessen the confusion this causes, I set "SCOLoadCheckoutsByDefault" to "Don't show", such that the occasional "Check in" button isn't visible by default. The standard button(s) to return an item are provided *after* you've entered the barcode of the item to be returned. What's making this UX worse are the prominent warnings like "You cannot renew this item again" or "This item is already checked out to you" - things I never intended or know anyway. IMHO, the return workflow needs some love here. 1) When "SCOAllowCheckin" is allowed, add a "Return" column to the "Checkouts" table with a single "Check in" item in it. This speeds up bulk self-checkins and makes the "Renew -> Check in" button less confusing 2) Rephrase the individual return dialog to make returns a first-class citizen, not just a (felt) exception. Cheers -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26479 Oliver Behnke <oliver.behnke@aei.mpg.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=37525 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26479 --- Comment #4 from Olli-Antti Kivilahti <olli-antti.kivilahti@hypernova.fi> --- Created attachment 170758 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170758&action=edit Bug 26479 - Self checkout: option for returning items is missing with SCOAllowCheckin Also. When reading a barcode to the checkout-input box, and when it already is checked-out to the logged-in-patron, SCO used to show the "cancel", "return" and "renew" -options. Now the "return" is missing. This fixes the issue -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26479 Olli-Antti Kivilahti <olli-antti.kivilahti@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |olli-antti.kivilahti@hypern | |ova.fi -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26479 --- Comment #5 from Olli-Antti Kivilahti <olli-antti.kivilahti@hypernova.fi> --- *** Bug 37525 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26479 Oliver Behnke <oliver.behnke@aei.mpg.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170758|0 |1 is obsolete| | --- Comment #6 from Oliver Behnke <oliver.behnke@aei.mpg.de> --- Created attachment 170808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170808&action=edit Signed-off patch I signed off the patch as requested, but mainly in the context of related bug 37525. Thus I'll keep the current status and let Katrin do the final testing/sign-off. Cheers -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26479 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Oliver Behnke from comment #3)
My issue was caused by a recent regression. See bug 37525.
That said, I agree that the UX is not as intuitive as it could be. When you allow "SCOAllowCheckin" this enables multiple buttons to "Return" or "Check in" an item. The one you're missing is the "Check in" button in the "Renew" column of the "Checkouts" table (on the main SCO page). That's only visible for items that cannot be renewed. To lessen the confusion this causes, I set "SCOLoadCheckoutsByDefault" to "Don't show", such that the occasional "Check in" button isn't visible by default.
The standard button(s) to return an item are provided *after* you've entered the barcode of the item to be returned. What's making this UX worse are the prominent warnings like "You cannot renew this item again" or "This item is already checked out to you" - things I never intended or know anyway. IMHO, the return workflow needs some love here.
1) When "SCOAllowCheckin" is allowed, add a "Return" column to the "Checkouts" table with a single "Check in" item in it. This speeds up bulk self-checkins and makes the "Renew -> Check in" button less confusing 2) Rephrase the individual return dialog to make returns a first-class citizen, not just a (felt) exception.
Cheers
I believe these are indeed different bugs. Mine was about the button in the checkous table, that doesn't appear to be fixed here, since Olli wrote: "But I felt like the user should not be able to check-in books from that list, because there is no guarantee the user actually has the book." So the patch should indeed probably go on bug 37525. With self checks you never know if the user actually has the item, it's all about trust. Please be aware that there is also a separate GUI for checkins that is more advanced probably, see SelfCheckInModule system preference. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26479 Olli-Antti Kivilahti <olli-antti.kivilahti@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #8 from Olli-Antti Kivilahti <olli-antti.kivilahti@hypernova.fi> --- (In reply to Oliver Behnke from comment #6)
Created attachment 170808 [details] [review] Signed-off patch
I signed off the patch as requested, but mainly in the context of related bug 37525. Thus I'll keep the current status and let Katrin do the final testing/sign-off.
Cheers
Thank you for the sign-off. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26479 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Summary|Self checkout: option for |Self checkout: checkouts |returning items is missing |table: option for returning |with SCOAllowCheckin |items is missing with | |SCOAllowCheckin -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26479 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170808|0 |1 is obsolete| | --- Comment #9 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Comment on attachment 170808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170808 Signed-off patch Obsoleting the patch that is actually addressing Bug 37525 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26479 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED --- Comment #10 from Victor Grousset/tuxayo <victor@tuxayo.net> --- I guess this is back to assigned status then. (for lack of being able to go back to new) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26479 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@libriotech.no --- Comment #11 from Magnus Enger <magnus@libriotech.no> --- I think the problem here is in this part of the SCO template (koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt): [% IF ISSUE.can_be_renewed %] ... [% ELSE %] ... [% IF Koha.Preference('SCOAllowCheckin') %] <div> <input type="submit" value="Check in item" name="confirm" class="btn btn-info btn-sm return" /> <input type="hidden" name="op" value="cud-returnbook" /> <input type="hidden" name="confirmed" value="" /> </div> [% END %] [% END %] If the issue/item/loan can be renewed, the "Check in item"-button is not shown. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26479 --- Comment #12 from Oliver Behnke <oliver.behnke@aei.mpg.de> --- Yep, see me analysis in comment #3 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26479 --- Comment #13 from Magnus Enger <magnus@libriotech.no> --- It looks like the logic of the code has been the way it is now for about 9 years, changed by bug 16873 and this patch: https://git.koha-community.org/Koha-community/Koha/commit/8dce1cde3a8b1d0cd7... SCOAllowCheckin was called AllowSelfCheckReturns back then, see bug 25147 and https://git.koha-community.org/Koha-community/Koha/commit/081a4c75be2431e1a6... But we do have at least one library reporting a change in functionality, where the "Check in" button "used to work perfectly, but is now missing". (Could this be because of some change to their renewal policies, so that items that used to be non-renewable and display the "Check in" button are now renewable, and missing the button?) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26479 --- Comment #14 from Magnus Enger <magnus@libriotech.no> --- I can do a patch for this, but I wonder about the best way to do it. My idea so far is - To introduce a new column "Check in" to the right of the "Renew" column - Put a button in the column that always says "Check in item" - Never display the "Check in item" button in the "Renew column" The main question I have is: Should there be a syspref to enable/disable this new behaviour? Or is it OK to always show the "Check in item" button? (To me it seems better than only showing it once an item can not be renewed, which I would think looks inconsistent to patrons.) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26479 --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I can't imagine it was intentional. I should always have the option to return an item if I want and have it on hand when at the library? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26479 --- Comment #16 from Magnus Enger <magnus@libriotech.no> --- (In reply to Katrin Fischer from comment #15)
I can't imagine it was intentional. I should always have the option to return an item if I want and have it on hand when at the library?
Agreed! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26479 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Self checkout: checkouts |Always show "Check |table: option for returning |in"-button if |items is missing with |SCOAllowCheckin |SCOAllowCheckin | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26479 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26479 --- Comment #17 from Magnus Enger <magnus@libriotech.no> --- Created attachment 182063 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182063&action=edit Bug 26479: Always show "Check in"-button if SCOAllowCheckin To reproduce: - Make sure SCO is enabled and SCOAllowCheckin = Allow - Log in to SCO in the OPAC - Check an item out to yourself - The item has a green "Renew item" button. Click this button until all renewals have been used up, and you get a blue "Check in item" button. To test: - Apply the patch - Check an item out to yourself - Verify the item has a green "Renew item" button in the "Renew" column, and a blue "Check in item" button in the "Check in" column - Click "Renew item" until all renewals are used up. Verify you eventually get the "No renewals allowed" message in the "Renew" column, but no blue "Check in item" button (in that column) - Verify the "Check in item" button works as expected - Set SCOAllowCheckin = Don't allow, reload the SCO page and verify that no "Check in" column and no blue "Check in item" button is shown, even after all renewals has been used up -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26479 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26479 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182063|0 |1 is obsolete| | --- Comment #18 from David Nind <david@davidnind.com> --- Created attachment 182068 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182068&action=edit Bug 26479: Always show "Check in"-button if SCOAllowCheckin To reproduce: - Make sure SCO is enabled and SCOAllowCheckin = Allow - Log in to SCO in the OPAC - Check an item out to yourself - The item has a green "Renew item" button. Click this button until all renewals have been used up, and you get a blue "Check in item" button. To test: - Apply the patch - Check an item out to yourself - Verify the item has a green "Renew item" button in the "Renew" column, and a blue "Check in item" button in the "Check in" column - Click "Renew item" until all renewals are used up. Verify you eventually get the "No renewals allowed" message in the "Renew" column, but no blue "Check in item" button (in that column) - Verify the "Check in item" button works as expected - Set SCOAllowCheckin = Don't allow, reload the SCO page and verify that no "Check in" column and no blue "Check in item" button is shown, even after all renewals has been used up Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26479 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |magnus@libriotech.no |ity.org | CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26479 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182068|0 |1 is obsolete| | --- Comment #19 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 182081 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182081&action=edit Bug 26479: Always show "Check in"-button if SCOAllowCheckin To reproduce: - Make sure SCO is enabled and SCOAllowCheckin = Allow - Log in to SCO in the OPAC - Check an item out to yourself - The item has a green "Renew item" button. Click this button until all renewals have been used up, and you get a blue "Check in item" button. To test: - Apply the patch - Check an item out to yourself - Verify the item has a green "Renew item" button in the "Renew" column, and a blue "Check in item" button in the "Check in" column - Click "Renew item" until all renewals are used up. Verify you eventually get the "No renewals allowed" message in the "Renew" column, but no blue "Check in item" button (in that column) - Verify the "Check in item" button works as expected - Set SCOAllowCheckin = Don't allow, reload the SCO page and verify that no "Check in" column and no blue "Check in item" button is shown, even after all renewals has been used up Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26479 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@openfifth.c |y.org |o.uk Status|Signed Off |Passed QA CC| |martin.renvoize@openfifth.c | |o.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26479 --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Annoying bug, thanks for your perseverance Magnus! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26479 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26479 --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26479 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #22 from Fridolin Somers <fridolin.somers@biblibre.com> --- I prefer not impact 24.11.x LTS for UI stability -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26479 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major --- Comment #23 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This fixed a major broken feature - returning items from the self check. It's often not feasible to use both the separate checkin and checkout pages. So having both options in the self checkout is an important feature. Can you please reconsider? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26479 --- Comment #24 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Also: this feature is tied to a pref, so there won't be GUI surprises for peope not wanting to allow checkins. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26479 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |Pushed to main --- Comment #25 from Fridolin Somers <fridolin.somers@biblibre.com> --- Ah OK, I work on rebase -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26479 --- Comment #26 from Fridolin Somers <fridolin.somers@biblibre.com> --- Arf template moved a lot. I someone can create a patch for 24.11. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26479 --- Comment #27 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thx for trying Frido -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26479 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org