https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27548 --- Comment #1 from Peter Vashchuk <stalkernoid@gmail.com> --- Created attachment 115781 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115781&action=edit Bug 27548: "use of uninitialized value" warning on branchoverdues.pl On the beginning we have empty "location" parameter for this form, but that not taken into account in comparison and undef warning emitted: "Use of uninitialized value $location in string eq at /usr/share/koha/intranet/cgi-bin/circ/branchoverdues.pl line 72" in branchoverdues.pl Fixed by adding pre-check for $location. To reproduce: 1) Head over to "Circulation ->Overdues with fines" page. Check intranet-error.log where there will be many warnings "Use of uninitialized value $location in string eq at /usr/share/koha/intranet/cgi-bin/circ/branchoverdues.pl line 72". 2) Apply the patch, refresh the "Overdues with fines" page. 3) Ensure that the new "use of uninitialized value" warnings didn't appear in the console. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27548 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27548 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- Testing notes: - When using koha-testing-docker the warnings are logged to /var/log/koha/kohadev/plack-intranet-error.log -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27548 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115794|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 116099 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116099&action=edit Bug 27548: "use of uninitialized value" warning on branchoverdues.pl On the beginning we have empty "location" parameter for this form, but that not taken into account in comparison and undef warning emitted: "Use of uninitialized value $location in string eq at /usr/share/koha/intranet/cgi-bin/circ/branchoverdues.pl line 72" in branchoverdues.pl Fixed by adding pre-check for $location. To reproduce: 1) Head over to "Circulation ->Overdues with fines" page. Check intranet-error.log where there will be many warnings "Use of uninitialized value $location in string eq at /usr/share/koha/intranet/cgi-bin/circ/branchoverdues.pl line 72". 2) Apply the patch, refresh the "Overdues with fines" page. 3) Ensure that the new "use of uninitialized value" warnings didn't appear in the console. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27548 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27548 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27548 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the cause of release notes| |unnecessary "use of | |uninitialized value" | |warnings in the log files | |generated by Circulation > | |Overdues with fines | |(/cgi-bin/koha/circ/brancho | |verdues.pl). | | | |This was | |caused by not taking into | |account that the "location" | |parameter for this form is | |initially empty. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27548 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Version(s)|21.05.00, 20.11.03,20.05.09 |21.05.00, released in| |20.11.03,20.05.09,19.11.15 Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #9 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Backported: Pushed to 19.11.x branch for 19.11.15 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27548 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|25790 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25790 [Bug 25790] [OMNIBUS] warnings removal -- You are receiving this mail because: You are watching all bug changes.