[Bug 39185] New: Holds priority drop-down contains extraneous 0's if there are found holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39185 Bug ID: 39185 Summary: Holds priority drop-down contains extraneous 0's if there are found holds Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: emily.lamancusa@montgomerycountymd.gov Reporter: emily.lamancusa@montgomerycountymd.gov QA Contact: testopia@bugs.koha-community.org To reproduce: 1. Place several holds on a biblio record 2. Check in items from that record and confirm some (but not all) of those holds 3. View the current holds on that record 4. Click on the drop-down to change priority on one of the holds --> Note that the drop-down contains some "0" options - one for each in-transit or waiting hold 5. Try clicking on a "0" option --> The hold moves above the lowest found hold on the list 6. Click "Update holds" --> The hold moves to priority 1, and priorities of other pending holds are updated accordingly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39185 --- Comment #1 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 178540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178540&action=edit Bug 39185: Don't add select option if priority is 0 To test: 1. Place several holds on a biblio record 2. Check in items from that record and confirm some (but not all) of the holds 3. View the current holds on that record 4. Click on the drop-down to change the priority of a hold --> Note that the drop-down contains one or more "0" options - one for each in-transit or waiting hold 5. Apply patch and refresh the page 6. Click on the drop-down again --> The drop-down now contains the correct options 7. Use the drop-down and the "Update holds" button to change hold hold priorities a few times --> Confirm that the priority is updated correctly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39185 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39185 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39185 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178540|0 |1 is obsolete| | --- Comment #2 from Phil Ringnalda <phil@chetcolibrary.org> --- Created attachment 178543 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178543&action=edit Bug 39185: Don't add select option if priority is 0 To test: 1. Place several holds on a biblio record 2. Check in items from that record and confirm some (but not all) of the holds 3. View the current holds on that record 4. Click on the drop-down to change the priority of a hold --> Note that the drop-down contains one or more "0" options - one for each in-transit or waiting hold 5. Apply patch and refresh the page 6. Click on the drop-down again --> The drop-down now contains the correct options 7. Use the drop-down and the "Update holds" button to change hold hold priorities a few times --> Confirm that the priority is updated correctly Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39185 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phil@chetcolibrary.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39185 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |baptiste.wojtkowski@biblibr |y.org |e.com CC| |baptiste.wojtkowski@biblibr | |e.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39185 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39185 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178543|0 |1 is obsolete| | --- Comment #3 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 178782 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178782&action=edit Bug 39185: Don't add select option if priority is 0 To test: 1. Place several holds on a biblio record 2. Check in items from that record and confirm some (but not all) of the holds 3. View the current holds on that record 4. Click on the drop-down to change the priority of a hold --> Note that the drop-down contains one or more "0" options - one for each in-transit or waiting hold 5. Apply patch and refresh the page 6. Click on the drop-down again --> The drop-down now contains the correct options 7. Use the drop-down and the "Update holds" button to change hold hold priorities a few times --> Confirm that the priority is updated correctly Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39185 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39185 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39185 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.05.00 |25.05.00,24.11.08 released in| | Status|Pushed to main |Pushed to stable --- Comment #5 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Pushed into 24.11.x for 24.11.08 nice work everyone -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39185 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting --- Comment #6 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org