[Bug 23140] New: Typo in returns.tt prevents printing branchcode in transfer slips
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23140 Bug ID: 23140 Summary: Typo in returns.tt prevents printing branchcode in transfer slips Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Target Milestone: --- data-url="transfer-slip.pl?transferitem=ITEMNUMBER&&branchcodeCODE&op=slip" should be: data-url="transfer-slip.pl?transferitem=ITEMNUMBER&&branchcode=CODE&op=slip" Note the missing '=' after branchcode -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23140 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23140 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 90686 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90686&action=edit Bug 23140: Fix typo in branchcode parameters for print slip To test: 1 - Have [% branch.branchcode %] in your TRANSFERSLIP 2 - Checkin an item from another branch (with AutomaticItemReturn = do ) 3 - Inspect the button in the browser to see the typo 4 - Click 'Print slip' 5 - Note the branchcode is not populated 6 - Clear the transfer 7 - Apply patch 8 - Repeat 9 - Note typo is fixed and slip correctly populated -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23140 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23140 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23120 CC| |mtompset@hotmail.com --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Found that I didn't get an internal error with this applied. So, I just made this see also bug 23120. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23140 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23140 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90686|0 |1 is obsolete| | --- Comment #3 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 90710 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90710&action=edit Bug 23140: Fix typo in branchcode parameters for print slip To test: 1 - Have [% branch.branchcode %] in your TRANSFERSLIP 2 - Checkin an item from another branch (with AutomaticItemReturn = do ) 3 - Inspect the button in the browser to see the typo 4 - Click 'Print slip' 5 - Note the branchcode is not populated 6 - Clear the transfer 7 - Apply patch 8 - Repeat 9 - Note typo is fixed and slip correctly populated Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23140 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22977 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22977 [Bug 22977] OMNIBUS: Ensure hidden fields are correctly passed during circulation -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23140 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23140 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90710|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 90876 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90876&action=edit Bug 23140: Fix typo in branchcode parameters for print slip To test: 1 - Have [% branch.branchcode %] in your TRANSFERSLIP 2 - Checkin an item from another branch (with AutomaticItemReturn = do ) 3 - Inspect the button in the browser to see the typo 4 - Click 'Print slip' 5 - Note the branchcode is not populated 6 - Clear the transfer 7 - Apply patch 8 - Repeat 9 - Note typo is fixed and slip correctly populated Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23140 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23140 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23140 --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23140 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Version(s)|19.11.00 |19.11.00,19.05.02 released in| | Status|Pushed to master |Pushed to stable --- Comment #6 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 19.05.x for 19.05.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23140 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 18.11.x for 18.11.08 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org