http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3162 Summary: Authority subfileds defintions and Show/Show Collapsed/Hide option Product: Koha Version: rel_3_0 Platform: All OS/Version: All Status: NEW Severity: normal Priority: P5 Component: Cataloging AssignedTo: galen.charlton@liblime.com ReportedBy: tajoli@cilea.it CC: tajoli@cilea.it Estimated Hours: 0.0 The defintion of visibilty of MARC subfields in the enviroments used (Opac, Intranet, Editor) is different between MARC Bibliographic framework [http://<your site>:8080/cgi-bin/koha/admin/biblio_framework.pl] and Authority framework [http://<your site>:8080/cgi-bin/koha/admin/authtypes.pl] In MARC Bibliographic framework to setup this option we use an input box that accepts values between -7 to 8. The meaning of the values is explained into the on-line help. No problems here. In Authority framework there are 3 List boxes (one for Opac, one for Intranet, one for Editor). The CGI with the bug is .../admin/auth_subfields_structure.pl For example see the defintion of field 035 (on Unimarc or MARC21 default framework): http://<your site>:8080/cgi-bin/koha/admin/auth_subfields_structure.pl?op=add_form&tagfield=035&authtypecode= But those 3 values are managed by only one SQL field, auth_subfield_structure.hidden. This field is a tinyint(3) field. So, when the system tries to save a value like '000', Mysql transform it into '0'. So not all option avaible in the inteface are recoredable into auth_subfield_structure.hidden The defintions of Authority subfields in installer/data/mysql/fr-FR/marcflavour/unimarc_complet/Obligatoire/autorites_norme_unimarc.sql and in installer/data/mysql/en/marcflavour/marc21/mandatory/authorities_normal_marc21.sql still use the scale -7 ... 8 And in fact the CGI for the display .../opac/opac-authoritiesdetail.pl .../authorities/detail-biblio-search.pl .../authorities/detail.pl still use the scale -7 ... 8 with problems. In fact the lines used in ../opac/opac-authoritiesdetail.pl .../authorities/detail-biblio-search.pl .../authorities/detail.pl to check the value of auth_subfield_structure.hidden are: $subfield_data{visibility} = "display:none;" if ( ($tagslib->{$tag}->{$subfield}->{hidden} % 2 == 1) and $value ne '' or ($value eq '' and !$tagslib->{$tag}->{$subfield}->{mandatory}) ); So the only two values that it is possible to use are 0 (or every evan value that means 'show all') and -7 (or ever odd value that means hide all). Well, this the problem. About solution ? My proposal is: -- for tree 3.0 I will write a patch to use the values '0','-5' with the meanings 'show all' vs 'hide all'. I select those two values because are just now used into SQL authority default defintions. So I need to change only the code of ../admin/auth_subfields_structure.pl, the help template and display template No changes in SQL defintion, into others CGI or into SQL authority default defintions. -- for tree 3.2 I think we need to plan a better system. Probably use 3 list box is better but we need to decide: a)Do we do the work with one SQL field or with three fields ? b)And what about MARC Bibliographic framework c)And about migration of framework from 3.0 to 3.2 ? That's all, I think Bye -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.