[Bug 28389] New: One should be able to see details for refunds on the register summary page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28389 Bug ID: 28389 Summary: One should be able to see details for refunds on the register summary page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org If you issue a refund for an charge and then view the transactions on the register page, you currently have no way of displaying what the refund was against. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28389 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 121175 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121175&action=edit Bug 28389: Add 'Details' link to refund type payout lines in POS This patch adds a link to the account-details page for refund type payout lines displaying on the register details page of cash management. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28389 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com Status|NEW |Needs Signoff Blocks| |13985 CC| |sally.healey@cheshireshared | |services.gov.uk Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 [Bug 13985] Cash Management - Koha as 'Point of Sale' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28389 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28389 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28389 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121175|0 |1 is obsolete| | --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 121189 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121189&action=edit Bug 28389: Add 'Details' link to refund type payout lines in POS This patch adds a link to the account-details page for refund type payout lines displaying on the register details page of cash management. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28389 --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- This works well and should defenitly come in handy! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28389 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28389 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Just wondering about this kind of naming: debit.credit.description -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28389 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- <td>[%- PROCESS account_type_description account=debit.credit -%]</td> [%- IF debit.credit.description %][% debit.credit.description | html %][%- END -%] [%- IF ( debit.credit.itemnumber ) -%] (<a href="/cgi-bin/koha/catalogue/moredetail.pl?biblionumber=[% debit.credit.item.biblionumber | uri %]&itemnumber=[% debit.credit.itemnumber | uri %]">[% debit.credit.item.biblio.title | html %]</a>)[%- END -%] <td>[% debit.credit.amount | $Price %]</td> This does not look good to me at first glance. You remove <td> and move data outside data tags? Please explain/correct. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28389 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121189|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 123477 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123477&action=edit Bug 28389: Add 'Details' link to refund type payout lines in POS This patch adds a link to the account-details page for refund type payout lines displaying on the register details page of cash management. Test plan 1/ Enable 'UseCashRegisters' 2/ Add some transactions with at least one including a 'Refund' 3/ Look at the transaction history for the current register (Tools > Cash management > Transaction history for X) 4/ Note the refund line does not contain a link to 'Details' 5/ Apply the patch 6/ The refund line should now have a 'Details' button on the right. 7/ Bonus points, perform a cashup and then search for older transactions and check the 'Details' button appears in this table too. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28389 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Marcel de Rooy from comment #5)
<td>[%- PROCESS account_type_description account=debit.credit -%]</td> [%- IF debit.credit.description %][% debit.credit.description | html %][%- END -%] [%- IF ( debit.credit.itemnumber ) -%] (<a href="/cgi-bin/koha/catalogue/moredetail.pl?biblionumber=[% debit.credit.item.biblionumber | uri %]&itemnumber=[% debit.credit.itemnumber | uri %]">[% debit.credit.item.biblio.title | html %]</a>)[%- END -%] <td>[% debit.credit.amount | $Price %]</td>
This does not look good to me at first glance. You remove <td> and move data outside data tags? Please explain/correct.
Good catch, my brain was clearly on a go slow there. I've rebased the patch, added a more details test plan and fixed an additional error with regards the historical transactions table not adding this field. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28389 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28390 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28390 [Bug 28390] Transaction timestamps should be part of the transaction grouping row instead of repeated for each breakdown row -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28389 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123477|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 123479 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123479&action=edit Bug 28389: Add 'Details' link to refund type payout lines in POS This patch adds a link to the account-details page for refund type payout lines displaying on the register details page of cash management. Test plan 1/ Enable 'UseCashRegisters' 2/ Add some transactions with at least one including a 'Refund' 3/ Look at the transaction history for the current register (Tools > Cash management > Transaction history for X) 4/ Note the refund line does not contain a link to 'Details' 5/ Apply the patch 6/ The refund line should now have a 'Details' button on the right. 7/ Bonus points, perform a cashup and then search for older transactions and check the 'Details' button appears in this table too. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28389 Bug 28389 depends on bug 28390, which changed state. Bug 28390 Summary: Transaction timestamps should be part of the transaction grouping row instead of repeated for each breakdown row https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28390 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28389 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28389 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123479|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 126023 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126023&action=edit Bug 28389: Add 'Details' link to refund type payout lines in POS This patch adds a link to the account-details page for refund type payout lines displaying on the register details page of cash management. Test plan 1/ Enable 'UseCashRegisters' 2/ Add some transactions with at least one including a 'Refund' 3/ Look at the transaction history for the current register (Tools > Cash management > Transaction history for X) 4/ Note the refund line does not contain a link to 'Details' 5/ Apply the patch 6/ The refund line should now have a 'Details' button on the right. 7/ Bonus points, perform a cashup and then search for older transactions and check the 'Details' button appears in this table too. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28389 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28389 --- Comment #10 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28389 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org