[Bug 23139] New: Koha::SharedContent->get_sharing_url is not used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23139 Bug ID: 23139 Summary: Koha::SharedContent->get_sharing_url is not used Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Mana-kb Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@ptfs-europe.com Target Milestone: --- The `get_sharing_url` method in Koha::SharedContent is currently only used in the unit tests. We should either convert code to use this routine or remove it. Personally, I think it could perhaps serve a similar use to shib_ok in C4::Auth_with_shibboleth in that we could add a cached config check (which would hit the Mana server to test it's actually there) and then return undef for failure or pass through the mana base url otherwise. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23139 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23075 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23139 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- It's also used in Koha::SharedContent::build_request 187 my $mana_url = get_sharing_url(); -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23139 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Jonathan Druart from comment #1)
It's also used in Koha::SharedContent::build_request
187 my $mana_url = get_sharing_url();
Closing. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org