[Bug 18127] New: Add batch modified records to an existing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18127 Bug ID: 18127 Summary: Add batch modified records to an existing list Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt@gmail.com Reporter: aleishaamohia@hotmail.com QA Contact: testopia@bugs.koha-community.org
From Bug 12759 Comment 1
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18127 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch Depends on| |12759 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12759 [Bug 12759] Add ability to pass list contents to batch record modification/deletion tools -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18127 --- Comment #1 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 60299 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60299&action=edit Bug 18127: Add batch modified records to an existing list This patch is based off a suggestion from bug 12759 to allow a user to add records to a list after they have been batch modified. To test: 1) Apply 12759 2) Pick a list to modify, go through batch modification process 3) Once the modification is done and successful, there should now be a 'Next' box with options in it 4) Confirm the 'New batch record modification' button takes you back to the start of the process. 5) Repeat step 2 6) Select a list from the dropdown to add your records to 7) Confirm that the correct records show in the pop up window 8) Once saved, go to your lists and confirm unique records were saved to the list Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18127 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |aleishaamohia@hotmail.com Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18127 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60299|0 |1 is obsolete| | --- Comment #2 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 60366 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60366&action=edit Bug 18127: Add batch modified records to an existing list This patch is based off a suggestion from bug 12759 to allow a user to add records to a list after they have been batch modified. To test: 1) Apply 12759 2) Pick a list to modify, go through batch modification process 3) Once the modification is done and successful, there should now be a 'Next' box with options in it 4) Confirm the 'New batch record modification' button takes you back to the start of the process. 5) Repeat step 2 6) Select a list from the dropdown to add your records to 7) Confirm that the correct records show in the pop up window 8) Once saved, go to your lists and confirm unique records were saved to the list 9) Go back to batch record modifications 10) Select Authorities as the record type. Enter an authority id in the record number list. Click Continue 11) Click modify selected records 12) Confirm that there is no dropdown to add to lists (since you can't add authorities to lists) and the link to New batch record modification works as expected. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18127 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18133 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18133 [Bug 18133] Batch record modification/deletion is not optimised for authorities -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18127 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|Needs Signoff |BLOCKED --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Blocked by bug 12759. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18127 Bug 18127 depends on bug 12759, which changed state. Bug 12759 Summary: Add ability to pass list contents to batch record modification/deletion tools https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12759 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18127 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Patch doesn't apply CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18127 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18127 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60366|0 |1 is obsolete| | --- Comment #4 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 98422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98422&action=edit Bug 18127: Add batch modified records to an existing list To test: 1) Start by having no (zero) lists 2) Go to Tools -> Batch record modification 3) Go through the batch record modification process, confirm everything works as normal and there is a link to do a new batch record modification at the end 4) In another tab, go to Lists and create a new list 5) Go back to the first tab and start a new batch modification process 6) At the end of the process, there should be a new option to add modified records to an existing list 7) Select a list from the dropdown and confirm you are able to save your modified records to the list as expected 8) Start a new batch modification process, this time for authorities records 9) At the end confirm there is no option to add modified records to a list, because authorities cannot be added to lists Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18127 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98422|0 |1 is obsolete| | --- Comment #5 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 98971 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98971&action=edit Bug 18127: Add batch modified records to an existing list To test: 1) Start by having no (zero) lists 2) Go to Tools -> Batch record modification 3) Go through the batch record modification process, confirm everything works as normal and there is a link to do a new batch record modification at the end 4) In another tab, go to Lists and create a new list 5) Go back to the first tab and start a new batch modification process 6) At the end of the process, there should be a new option to add modified records to an existing list 7) Select a list from the dropdown and confirm you are able to save your modified records to the list as expected 8) Start a new batch modification process, this time for authorities records 9) At the end confirm there is no option to add modified records to a list, because authorities cannot be added to lists Sponsored-by: Catalyst IT Signed-off-by: Jessica Zairo <jzairo@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18127 Jessie Zairo <jzairo@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |jzairo@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18127 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org Status|Signed Off |Failed QA --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Hi Aleisha, A couple of things: 1. After 7, I still have the "Add to a list:" popup that does not close. I think that is not correct. 2. I am wondering how we could improve the ergonomic of the last view, maybe Owen could help us? https://snipboard.io/GYxbaS.jpg Especially if there is no list, we see """ Next steps: * New batch record modification """ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18127 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18127 --- Comment #7 from Aleisha Amohia <aleisha@catalyst.net.nz> --- (In reply to Jonathan Druart from comment #6)
Hi Aleisha,
A couple of things:
1. After 7, I still have the "Add to a list:" popup that does not close. I think that is not correct.
Hi Jonathan. I don't get this bug - The popup closes when you click 'Save' and when you click 'Cancel'. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18127 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- When I select a list, the popup is displayed with /cgi-bin/koha/virtualshelves/addbybiblionumber.pl?shelfnumber=4&confirm=1&biblionumber=1&biblionumber=2&biblionumber=3&biblionumber=4&biblionumber=5 I then click "Save", the popup reloads with /cgi-bin/koha/virtualshelves/addbybiblionumber.pl and I see https://snipboard.io/lGR2fE.jpg -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18127 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #9 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Sorry Jonathan I'm still unable to reproduce that, and I've asked others to test and they couldn't reproduce either. Setting back to Needs signoff to see if this is working (or not working) for someone else. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18127 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Could this be a browser issue? I seem to remember we had issues with 'not closing windows' on another bug report a while ago. Which browsers have you 2 been testing with? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18127 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Ok with Chromium, Not OK with Firefox. I indeed see <html><meta http-equiv="refresh" content="0" /><body onload="self.close();"></body></html> in the source, but the window does not close. Same behavior when adding a record to a list from the search result page actually, so not (directly) related to this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18127 --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #11)
Ok with Chromium, Not OK with Firefox.
I indeed see <html><meta http-equiv="refresh" content="0" /><body onload="self.close();"></body></html> in the source, but the window does not close. Same behavior when adding a record to a list from the search result page actually, so not (directly) related to this.
Well, I am confused. It works in FF in a private window, I guess I have an extension that is missing with that close(). Sorry! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18127 --- Comment #13 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Thanks anyway Jonathan. I am testing in Firefox and it works fine for me. Will leave as Needs signoff for someone else to test. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18127 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18127 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98971|0 |1 is obsolete| | --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 100449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100449&action=edit Bug 18127: Add batch modified records to an existing list To test: 1) Start by having no (zero) lists 2) Go to Tools -> Batch record modification 3) Go through the batch record modification process, confirm everything works as normal and there is a link to do a new batch record modification at the end 4) In another tab, go to Lists and create a new list 5) Go back to the first tab and start a new batch modification process 6) At the end of the process, there should be a new option to add modified records to an existing list 7) Select a list from the dropdown and confirm you are able to save your modified records to the list as expected 8) Start a new batch modification process, this time for authorities records 9) At the end confirm there is no option to add modified records to a list, because authorities cannot be added to lists Sponsored-by: Catalyst IT Signed-off-by: Jessica Zairo <jzairo@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18127 --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 100450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100450&action=edit Bug 18127: Add missing html filters Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18127 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #16 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- That works, and could be considered a first step. IMO the ergonomic should be improved on a follow-up bug report. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18127 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18127 --- Comment #17 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18127 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com --- Comment #18 from Joy Nelson <joy@bywatersolutions.com> --- enhancement not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18127 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |With this enhancement you release notes| |can add all the records of | |a batch record modification | |to an existing list after | |successful modification. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18127 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Summary|Add batch modified records |Add ability to add batch |to an existing list |modified records to an | |existing list -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org